Re: [PATCH 1/1] arm64: dts: allwinner: a64: olinuxino: Add VCC-PG supply

From: Maxime Ripard <mripard@kernel.org>
To: Stefan Mavrodiev <stefan@olimex.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	linux-sunxi@googlegroups.com,
	open list <linux-kernel@vger.kernel.org>,
	Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
	"moderated list:ARM/Allwinner sunXi SoC support"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/1] arm64: dts: allwinner: a64: olinuxino: Add VCC-PG supply
Date: Thu, 28 Nov 2019 11:33:01 +0100	[thread overview]
Message-ID: <20191128103301.vjpkvjscy45ycgwg@gilmour.lan> (raw)
In-Reply-To: <0c1d7377-7064-f509-ffc5-bd1e8f2fbaa8@olimex.com>

[-- Attachment #1.1: Type: text/plain, Size: 1673 bytes --]

Hi Stefan,

On Wed, Nov 27, 2019 at 09:07:40AM +0200, Stefan Mavrodiev wrote:
> On 11/26/19 6:27 PM, Maxime Ripard wrote:
> > Hi Stefan,
> >
> > On Tue, Nov 26, 2019 at 01:05:08PM +0200, Stefan Mavrodiev wrote:
> > > On A64-OLinuXino boards, PG9 is used for USB1 enable/disable. The
> > > port is supplied by DLDO4, which is disabled by default. The patch
> > > adds the regulator as vcc-pg, which is later used by the pinctrl.
> > >
> > > Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>
> > > ---
> > >   arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts | 4 ++++
> > >   1 file changed, 4 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > > index 01a9a52edae4..c9d8c9c4ef20 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > > @@ -163,6 +163,10 @@
> > >   	status = "okay";
> > >   };
> > >
> > > +&pio {
> > > +	vcc-pg-supply=<&reg_dldo4>;
> > The equal sign should have spaces around it.
> >
> > Also, can you please list all the bank supplies while you're at it?
>
> Sure. Should the supplies defined as regulators names be added also to the
> pio node?
> For example reg_aldo1 is named "vcc-pe".

As far as I can tell, the A64 has regulators for PC, PD, PE, PG and
PL, so you should list those (PL being under r_pio)

> Also, since the commit message will be different for better representation
> of the changes, should I send the next
> patch as v2 or as a new one?

Either way works for me as long as the commit message matches the changes.

Thanks!
Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel