From: Stephan Gerhold <stephan@gerhold.net>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] ARM: dts: ux500: Fix up DSI controller nodes
Date: Tue, 26 Nov 2019 19:14:18 +0100 [thread overview]
Message-ID: <20191126181418.GC12811@gerhold.net> (raw)
In-Reply-To: <20191126124738.77690-4-linus.walleij@linaro.org>
On Tue, Nov 26, 2019 at 01:47:38PM +0100, Linus Walleij wrote:
> These nodes should be named dsi-controller@* so fix it up.
The device tree specification suggests "dsi@*" as far as I can tell:
https://github.com/devicetree-org/devicetree-specification/commit/424946c228baca7b49df2be8fdd8ccda18a8b8f6
>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> arch/arm/boot/dts/ste-dbx5x0.dtsi | 6 +++---
> arch/arm/boot/dts/ste-href-tvk1281618-r2.dtsi | 2 +-
> arch/arm/boot/dts/ste-href-tvk1281618-r3.dtsi | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ste-dbx5x0.dtsi b/arch/arm/boot/dts/ste-dbx5x0.dtsi
> index 4e02b1b6c0bf..f4fb782d3afc 100644
> --- a/arch/arm/boot/dts/ste-dbx5x0.dtsi
> +++ b/arch/arm/boot/dts/ste-dbx5x0.dtsi
> @@ -1092,7 +1092,7 @@
> ranges;
> status = "disabled";
>
> - dsi0: dsi@a0351000 {
> + dsi0: dsi-controller@a0351000 {
> compatible = "ste,mcde-dsi";
> reg = <0xa0351000 0x1000>;
> clocks = <&prcmu_clk PRCMU_DSI0CLK>, <&prcmu_clk PRCMU_DSI0ESCCLK>;
> @@ -1100,7 +1100,7 @@
> #address-cells = <1>;
> #size-cells = <0>;
> };
> - dsi1: dsi@a0352000 {
> + dsi1: dsi-controller@a0352000 {
> compatible = "ste,mcde-dsi";
> reg = <0xa0352000 0x1000>;
> clocks = <&prcmu_clk PRCMU_DSI1CLK>, <&prcmu_clk PRCMU_DSI1ESCCLK>;
> @@ -1108,7 +1108,7 @@
> #address-cells = <1>;
> #size-cells = <0>;
> };
> - dsi2: dsi@a0353000 {
> + dsi2: dsi-controller@a0353000 {
> compatible = "ste,mcde-dsi";
> reg = <0xa0353000 0x1000>;
> /* This DSI port only has the Low Power / Energy Save clock */
> diff --git a/arch/arm/boot/dts/ste-href-tvk1281618-r2.dtsi b/arch/arm/boot/dts/ste-href-tvk1281618-r2.dtsi
> index e024520f4d47..de82b9db956f 100644
> --- a/arch/arm/boot/dts/ste-href-tvk1281618-r2.dtsi
> +++ b/arch/arm/boot/dts/ste-href-tvk1281618-r2.dtsi
> @@ -66,7 +66,7 @@
> mcde@a0350000 {
> status = "okay";
>
> - dsi@a0351000 {
> + dsi-controller@a0351000 {
> panel {
> compatible = "samsung,s6d16d0";
> reg = <0>;
> diff --git a/arch/arm/boot/dts/ste-href-tvk1281618-r3.dtsi b/arch/arm/boot/dts/ste-href-tvk1281618-r3.dtsi
> index cb3677f0a1cb..9f285c7cf914 100644
> --- a/arch/arm/boot/dts/ste-href-tvk1281618-r3.dtsi
> +++ b/arch/arm/boot/dts/ste-href-tvk1281618-r3.dtsi
> @@ -45,7 +45,7 @@
> mcde@a0350000 {
> status = "okay";
>
> - dsi@a0351000 {
> + dsi-controller@a0351000 {
> panel {
> compatible = "sony,acx424akp";
> reg = <0>;
> --
> 2.23.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-26 18:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 12:47 [PATCH 1/4] ARM: dts: ux500: Break out DB8500 DTSI Linus Walleij
2019-11-26 12:47 ` [PATCH 2/4] ARM: dts: ux500: Split TVK DTSI files in two Linus Walleij
2019-11-26 12:47 ` [PATCH 3/4] ARM: dts: ux500: Add devicetree for HREF520 Linus Walleij
2019-11-26 12:47 ` [PATCH 4/4] ARM: dts: ux500: Fix up DSI controller nodes Linus Walleij
2019-11-26 18:14 ` Stephan Gerhold [this message]
2019-11-27 14:04 ` Linus Walleij
2019-11-26 18:03 ` [PATCH 1/4] ARM: dts: ux500: Break out DB8500 DTSI Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126181418.GC12811@gerhold.net \
--to=stephan@gerhold.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).