linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V2] ARM: dts: imx6q-logicpd: Enable ili2117a Touchscreen
@ 2019-11-06 14:23 Adam Ford
  2019-11-06 16:18 ` Marco Felsch
  2019-12-04  2:45 ` Shawn Guo
  0 siblings, 2 replies; 4+ messages in thread
From: Adam Ford @ 2019-11-06 14:23 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Mark Rutland, devicetree, Fabio Estevam, Adam Ford, Sascha Hauer,
	linux-kernel, Rob Herring, NXP Linux Team,
	Pengutronix Kernel Team, Shawn Guo

The LCD used with the imx6q-logicpd board has an integrated
ili2117a touch controller connected to i2c1.

This patch adds the node to enable this feature.

Signed-off-by: Adam Ford <aford173@gmail.com>
---
ili2117 support is scheduled to be introduced for Kernel v5.5.

V2:  Change node to touchscreen@26 and move comment about 5.5 to under the dashes

diff --git a/arch/arm/boot/dts/imx6q-logicpd.dts b/arch/arm/boot/dts/imx6q-logicpd.dts
index d96ae54be338..7a3d1d3e54a9 100644
--- a/arch/arm/boot/dts/imx6q-logicpd.dts
+++ b/arch/arm/boot/dts/imx6q-logicpd.dts
@@ -73,6 +73,16 @@
 	status = "okay";
 };
 
+&i2c1 {
+	touchscreen@26 {
+		compatible = "ilitek,ili2117";
+		reg = <0x26>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_touchscreen>;
+		interrupts-extended = <&gpio1 6 IRQ_TYPE_EDGE_RISING>;
+	};
+};
+
 &ldb {
 	status = "okay";
 
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH V2] ARM: dts: imx6q-logicpd: Enable ili2117a Touchscreen
  2019-11-06 14:23 [PATCH V2] ARM: dts: imx6q-logicpd: Enable ili2117a Touchscreen Adam Ford
@ 2019-11-06 16:18 ` Marco Felsch
  2019-11-06 16:21   ` Adam Ford
  2019-12-04  2:45 ` Shawn Guo
  1 sibling, 1 reply; 4+ messages in thread
From: Marco Felsch @ 2019-11-06 16:18 UTC (permalink / raw)
  To: Adam Ford
  Cc: Mark Rutland, devicetree, Shawn Guo, Sascha Hauer, linux-kernel,
	Rob Herring, NXP Linux Team, Pengutronix Kernel Team,
	Fabio Estevam, linux-arm-kernel

Hi Adam,

On 19-11-06 08:23, Adam Ford wrote:
> The LCD used with the imx6q-logicpd board has an integrated
> ili2117a touch controller connected to i2c1.
> 
> This patch adds the node to enable this feature.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> ili2117 support is scheduled to be introduced for Kernel v5.5.
> 
> V2:  Change node to touchscreen@26 and move comment about 5.5 to under the dashes
> 
> diff --git a/arch/arm/boot/dts/imx6q-logicpd.dts b/arch/arm/boot/dts/imx6q-logicpd.dts
> index d96ae54be338..7a3d1d3e54a9 100644
> --- a/arch/arm/boot/dts/imx6q-logicpd.dts
> +++ b/arch/arm/boot/dts/imx6q-logicpd.dts
> @@ -73,6 +73,16 @@
>  	status = "okay";
>  };
>  
> +&i2c1 {
> +	touchscreen@26 {
> +		compatible = "ilitek,ili2117";
> +		reg = <0x26>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_touchscreen>;

This phandle already exists?

Regards,
  Marco

> +		interrupts-extended = <&gpio1 6 IRQ_TYPE_EDGE_RISING>;
> +	};
> +};
> +
>  &ldb {
>  	status = "okay";
>  
> -- 
> 2.20.1
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH V2] ARM: dts: imx6q-logicpd: Enable ili2117a Touchscreen
  2019-11-06 16:18 ` Marco Felsch
@ 2019-11-06 16:21   ` Adam Ford
  0 siblings, 0 replies; 4+ messages in thread
From: Adam Ford @ 2019-11-06 16:21 UTC (permalink / raw)
  To: Marco Felsch
  Cc: Mark Rutland, devicetree, Shawn Guo, Sascha Hauer,
	Linux Kernel Mailing List, Rob Herring, NXP Linux Team,
	Pengutronix Kernel Team, Fabio Estevam, arm-soc

On Wed, Nov 6, 2019 at 10:18 AM Marco Felsch <m.felsch@pengutronix.de> wrote:
>
> Hi Adam,
>
> On 19-11-06 08:23, Adam Ford wrote:
> > The LCD used with the imx6q-logicpd board has an integrated
> > ili2117a touch controller connected to i2c1.
> >
> > This patch adds the node to enable this feature.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> > ---
> > ili2117 support is scheduled to be introduced for Kernel v5.5.
> >
> > V2:  Change node to touchscreen@26 and move comment about 5.5 to under the dashes
> >
> > diff --git a/arch/arm/boot/dts/imx6q-logicpd.dts b/arch/arm/boot/dts/imx6q-logicpd.dts
> > index d96ae54be338..7a3d1d3e54a9 100644
> > --- a/arch/arm/boot/dts/imx6q-logicpd.dts
> > +++ b/arch/arm/boot/dts/imx6q-logicpd.dts
> > @@ -73,6 +73,16 @@
> >       status = "okay";
> >  };
> >
> > +&i2c1 {
> > +     touchscreen@26 {
> > +             compatible = "ilitek,ili2117";
> > +             reg = <0x26>;
> > +             pinctrl-names = "default";
> > +             pinctrl-0 = <&pinctrl_touchscreen>;
>
> This phandle already exists?

Yes it does exist, but it probably should not have been since there
was no user of it.  At least this fixes that.  :-)

adam

>
> Regards,
>   Marco
>
> > +             interrupts-extended = <&gpio1 6 IRQ_TYPE_EDGE_RISING>;
> > +     };
> > +};
> > +
> >  &ldb {
> >       status = "okay";
> >
> > --
> > 2.20.1
> >
> >
> >
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH V2] ARM: dts: imx6q-logicpd: Enable ili2117a Touchscreen
  2019-11-06 14:23 [PATCH V2] ARM: dts: imx6q-logicpd: Enable ili2117a Touchscreen Adam Ford
  2019-11-06 16:18 ` Marco Felsch
@ 2019-12-04  2:45 ` Shawn Guo
  1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2019-12-04  2:45 UTC (permalink / raw)
  To: Adam Ford
  Cc: Mark Rutland, devicetree, Sascha Hauer, linux-kernel,
	Rob Herring, NXP Linux Team, Pengutronix Kernel Team,
	Fabio Estevam, linux-arm-kernel

On Wed, Nov 06, 2019 at 08:23:08AM -0600, Adam Ford wrote:
> The LCD used with the imx6q-logicpd board has an integrated
> ili2117a touch controller connected to i2c1.
> 
> This patch adds the node to enable this feature.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>

Applied, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-12-04  2:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06 14:23 [PATCH V2] ARM: dts: imx6q-logicpd: Enable ili2117a Touchscreen Adam Ford
2019-11-06 16:18 ` Marco Felsch
2019-11-06 16:21   ` Adam Ford
2019-12-04  2:45 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).