* [PATCH] lib/stackdepot: Fix global out-of-bounds in stackdepot
@ 2019-12-09 5:48 Walter Wu
0 siblings, 0 replies; only message in thread
From: Walter Wu @ 2019-12-09 5:48 UTC (permalink / raw)
To: Matthias Brugger, Thomas Gleixner, Alexander Potapenko, Josh Poimboeuf
Cc: Walter Wu, linux-mediatek, linux-kernel, linux-arm-kernel, wsd_upstream
If the depot_index = STACK_ALLOC_MAX_SLABS - 2, then it will cause
array out-of-bounds access, so that we should modify the detection
to avoid this array out-of-bounds bug.
Consider following call flow sequence:
stack_depot_save()
depot_alloc_stack()
if (unlikely(depot_index + 1 >= STACK_ALLOC_MAX_SLABS)) //pass
depot_index++ //depot_index = STACK_ALLOC_MAX_SLABS - 1
stack_depot_save()
init_stack_slab()
stack_slabs[depot_index + 1] //here get global out-of-bounds
Signed-off-by: Walter Wu <walter-zh.wu@mediatek.com>
---
lib/stackdepot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index ed717dd08ff3..7e8a15e41600 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -106,7 +106,7 @@ static struct stack_record *depot_alloc_stack(unsigned long *entries, int size,
required_size = ALIGN(required_size, 1 << STACK_ALLOC_ALIGN);
if (unlikely(depot_offset + required_size > STACK_ALLOC_SIZE)) {
- if (unlikely(depot_index + 1 >= STACK_ALLOC_MAX_SLABS)) {
+ if (unlikely(depot_index + 2 >= STACK_ALLOC_MAX_SLABS)) {
WARN_ONCE(1, "Stack depot reached limit capacity");
return NULL;
}
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-12-09 5:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-09 5:48 [PATCH] lib/stackdepot: Fix global out-of-bounds in stackdepot Walter Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).