* [PATCH 1/2] phy: mediatek: Fix Kconfig indentation @ 2019-12-30 17:24 Krzysztof Kozlowski 2019-12-30 17:24 ` [PATCH 2/2] phy: Enable compile testing for some of drivers Krzysztof Kozlowski 0 siblings, 1 reply; 4+ messages in thread From: Krzysztof Kozlowski @ 2019-12-30 17:24 UTC (permalink / raw) To: Kishon Vijay Abraham I, Chunfeng Yun, Matthias Brugger, Maxime Ripard, linux-kernel, linux-arm-kernel, linux-mediatek Cc: Krzysztof Kozlowski Adjust indentation from spaces to tab (+optional two spaces) as in coding style. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/phy/mediatek/Kconfig | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig index 376f5d189da0..7d19134c6b7c 100644 --- a/drivers/phy/mediatek/Kconfig +++ b/drivers/phy/mediatek/Kconfig @@ -3,12 +3,12 @@ # Phy drivers for Mediatek devices # config PHY_MTK_TPHY - tristate "MediaTek T-PHY Driver" - depends on ARCH_MEDIATEK && OF - select GENERIC_PHY - help - Say 'Y' here to add support for MediaTek T-PHY driver, - it supports multiple usb2.0, usb3.0 ports, PCIe and + tristate "MediaTek T-PHY Driver" + depends on ARCH_MEDIATEK && OF + select GENERIC_PHY + help + Say 'Y' here to add support for MediaTek T-PHY driver, + it supports multiple usb2.0, usb3.0 ports, PCIe and SATA, and meanwhile supports two version T-PHY which have different banks layout, the T-PHY with shared banks between multi-ports is first version, otherwise is second veriosn, @@ -25,10 +25,10 @@ config PHY_MTK_UFS specified M-PHYs. config PHY_MTK_XSPHY - tristate "MediaTek XS-PHY Driver" - depends on ARCH_MEDIATEK && OF - select GENERIC_PHY - help + tristate "MediaTek XS-PHY Driver" + depends on ARCH_MEDIATEK && OF + select GENERIC_PHY + help Enable this to support the SuperSpeedPlus XS-PHY transceiver for USB3.1 GEN2 controllers on MediaTek chips. The driver supports multiple USB2.0, USB3.1 GEN2 ports. -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] phy: Enable compile testing for some of drivers 2019-12-30 17:24 [PATCH 1/2] phy: mediatek: Fix Kconfig indentation Krzysztof Kozlowski @ 2019-12-30 17:24 ` Krzysztof Kozlowski 2019-12-30 20:10 ` Florian Fainelli 0 siblings, 1 reply; 4+ messages in thread From: Krzysztof Kozlowski @ 2019-12-30 17:24 UTC (permalink / raw) To: Kishon Vijay Abraham I, Chunfeng Yun, Matthias Brugger, Maxime Ripard, linux-kernel, linux-arm-kernel, linux-mediatek Cc: Krzysztof Kozlowski Some of the phy drivers can be compile tested to increase build coverage. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/phy/allwinner/Kconfig | 3 ++- drivers/phy/marvell/Kconfig | 8 +++++--- drivers/phy/mediatek/Kconfig | 9 ++++++--- drivers/phy/samsung/Kconfig | 8 ++++---- drivers/phy/ti/Kconfig | 4 ++-- 5 files changed, 19 insertions(+), 13 deletions(-) diff --git a/drivers/phy/allwinner/Kconfig b/drivers/phy/allwinner/Kconfig index 3dab79e9d52b..e760d89d3976 100644 --- a/drivers/phy/allwinner/Kconfig +++ b/drivers/phy/allwinner/Kconfig @@ -48,7 +48,8 @@ config PHY_SUN9I_USB config PHY_SUN50I_USB3 tristate "Allwinner H6 SoC USB3 PHY driver" - depends on ARCH_SUNXI && HAS_IOMEM && OF + depends on ARCH_SUNXI || COMPILE_TEST + depends on HAS_IOMEM && OF depends on RESET_CONTROLLER select GENERIC_PHY help diff --git a/drivers/phy/marvell/Kconfig b/drivers/phy/marvell/Kconfig index 005e02dd4a91..8f6273c837ec 100644 --- a/drivers/phy/marvell/Kconfig +++ b/drivers/phy/marvell/Kconfig @@ -10,14 +10,16 @@ config ARMADA375_USBCLUSTER_PHY config PHY_BERLIN_SATA tristate "Marvell Berlin SATA PHY driver" - depends on ARCH_BERLIN && HAS_IOMEM && OF + depends on ARCH_BERLIN || COMPILE_TEST + depends on OF && HAS_IOMEM select GENERIC_PHY help Enable this to support the SATA PHY on Marvell Berlin SoCs. config PHY_BERLIN_USB tristate "Marvell Berlin USB PHY Driver" - depends on ARCH_BERLIN && RESET_CONTROLLER && HAS_IOMEM && OF + depends on ARCH_BERLIN || COMPILE_TEST + depends on OF && HAS_IOMEM && RESET_CONTROLLER select GENERIC_PHY help Enable this to support the USB PHY on Marvell Berlin SoCs. @@ -95,7 +97,7 @@ config PHY_PXA_28NM_USB2 config PHY_PXA_USB tristate "Marvell PXA USB PHY Driver" - depends on ARCH_PXA || ARCH_MMP + depends on ARCH_PXA || ARCH_MMP || COMPILE_TEST select GENERIC_PHY help Enable this to support Marvell PXA USB PHY driver for Marvell diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig index 7d19134c6b7c..dee757c957f2 100644 --- a/drivers/phy/mediatek/Kconfig +++ b/drivers/phy/mediatek/Kconfig @@ -4,7 +4,8 @@ # config PHY_MTK_TPHY tristate "MediaTek T-PHY Driver" - depends on ARCH_MEDIATEK && OF + depends on ARCH_MEDIATEK || COMPILE_TEST + depends on OF select GENERIC_PHY help Say 'Y' here to add support for MediaTek T-PHY driver, @@ -16,7 +17,8 @@ config PHY_MTK_TPHY config PHY_MTK_UFS tristate "MediaTek UFS M-PHY driver" - depends on ARCH_MEDIATEK && OF + depends on ARCH_MEDIATEK || COMPILE_TEST + depends on OF select GENERIC_PHY help Support for UFS M-PHY on MediaTek chipsets. @@ -26,7 +28,8 @@ config PHY_MTK_UFS config PHY_MTK_XSPHY tristate "MediaTek XS-PHY Driver" - depends on ARCH_MEDIATEK && OF + depends on ARCH_MEDIATEK || COMPILE_TEST + depends on OF select GENERIC_PHY help Enable this to support the SuperSpeedPlus XS-PHY transceiver for diff --git a/drivers/phy/samsung/Kconfig b/drivers/phy/samsung/Kconfig index 290a6c70f570..349fcb23e5f3 100644 --- a/drivers/phy/samsung/Kconfig +++ b/drivers/phy/samsung/Kconfig @@ -32,7 +32,7 @@ config PHY_EXYNOS_PCIE config PHY_SAMSUNG_USB2 tristate "Samsung USB 2.0 PHY driver" depends on HAS_IOMEM - depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS || USB_DWC2 + depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS || USB_DWC2 || COMPILE_TEST select GENERIC_PHY select MFD_SYSCON default ARCH_EXYNOS @@ -60,7 +60,7 @@ config PHY_EXYNOS5250_USB2 config PHY_S5PV210_USB2 bool "Support for S5PV210" depends on PHY_SAMSUNG_USB2 - depends on ARCH_S5PV210 + depends on ARCH_S5PV210 || COMPILE_TEST help Enable USB PHY support for S5PV210. This option requires that Samsung USB 2.0 PHY driver is enabled and means that support for this @@ -69,7 +69,7 @@ config PHY_S5PV210_USB2 config PHY_EXYNOS5_USBDRD tristate "Exynos5 SoC series USB DRD PHY driver" - depends on ARCH_EXYNOS && OF + depends on (ARCH_EXYNOS && OF) || COMPILE_TEST depends on HAS_IOMEM depends on USB_DWC3_EXYNOS select GENERIC_PHY @@ -82,7 +82,7 @@ config PHY_EXYNOS5_USBDRD config PHY_EXYNOS5250_SATA tristate "Exynos5250 Sata SerDes/PHY driver" - depends on SOC_EXYNOS5250 + depends on SOC_EXYNOS5250 || COMPILE_TEST depends on HAS_IOMEM depends on OF select GENERIC_PHY diff --git a/drivers/phy/ti/Kconfig b/drivers/phy/ti/Kconfig index 174888609779..e231c0e369c5 100644 --- a/drivers/phy/ti/Kconfig +++ b/drivers/phy/ti/Kconfig @@ -4,7 +4,7 @@ # config PHY_DA8XX_USB tristate "TI DA8xx USB PHY Driver" - depends on ARCH_DAVINCI_DA8XX + depends on ARCH_DAVINCI_DA8XX || COMPILE_TEST select GENERIC_PHY select MFD_SYSCON help @@ -14,7 +14,7 @@ config PHY_DA8XX_USB config PHY_DM816X_USB tristate "TI dm816x USB PHY driver" - depends on ARCH_OMAP2PLUS + depends on ARCH_OMAP2PLUS || COMPILE_TEST depends on USB_SUPPORT select GENERIC_PHY select USB_PHY -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] phy: Enable compile testing for some of drivers 2019-12-30 17:24 ` [PATCH 2/2] phy: Enable compile testing for some of drivers Krzysztof Kozlowski @ 2019-12-30 20:10 ` Florian Fainelli 2019-12-31 8:20 ` Krzysztof Kozlowski 0 siblings, 1 reply; 4+ messages in thread From: Florian Fainelli @ 2019-12-30 20:10 UTC (permalink / raw) To: Krzysztof Kozlowski, Kishon Vijay Abraham I, Chunfeng Yun, Matthias Brugger, Maxime Ripard, linux-kernel, linux-arm-kernel, linux-mediatek Hi Krzysztof, On 12/30/19 9:24 AM, Krzysztof Kozlowski wrote: > Some of the phy drivers can be compile tested to increase build > coverage. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> This looks fine, you could also consider adding a bunch of other Broadcom PHY drivers which are not currently under COMPILE_TEST, yet build fine: diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig index d3d983c128ea..d56db6d375e1 100644 --- a/drivers/phy/broadcom/Kconfig +++ b/drivers/phy/broadcom/Kconfig @@ -50,7 +50,7 @@ config PHY_BCM_NS_USB3 config PHY_NS2_PCIE tristate "Broadcom Northstar2 PCIe PHY driver" - depends on OF && MDIO_BUS_MUX_BCM_IPROC + depends on (OF && MDIO_BUS_MUX_BCM_IPROC) || COMPILE_TEST select GENERIC_PHY default ARCH_BCM_IPROC help @@ -83,7 +83,7 @@ config PHY_BRCM_SATA config PHY_BRCM_USB tristate "Broadcom STB USB PHY driver" - depends on ARCH_BRCMSTB + depends on ARCH_BRCMSTB || COMPILE_TEST depends on OF select GENERIC_PHY select SOC_BRCMSTB > --- > drivers/phy/allwinner/Kconfig | 3 ++- > drivers/phy/marvell/Kconfig | 8 +++++--- > drivers/phy/mediatek/Kconfig | 9 ++++++--- > drivers/phy/samsung/Kconfig | 8 ++++---- > drivers/phy/ti/Kconfig | 4 ++-- > 5 files changed, 19 insertions(+), 13 deletions(-) > > diff --git a/drivers/phy/allwinner/Kconfig b/drivers/phy/allwinner/Kconfig > index 3dab79e9d52b..e760d89d3976 100644 > --- a/drivers/phy/allwinner/Kconfig > +++ b/drivers/phy/allwinner/Kconfig > @@ -48,7 +48,8 @@ config PHY_SUN9I_USB > > config PHY_SUN50I_USB3 > tristate "Allwinner H6 SoC USB3 PHY driver" > - depends on ARCH_SUNXI && HAS_IOMEM && OF > + depends on ARCH_SUNXI || COMPILE_TEST > + depends on HAS_IOMEM && OF > depends on RESET_CONTROLLER > select GENERIC_PHY > help > diff --git a/drivers/phy/marvell/Kconfig b/drivers/phy/marvell/Kconfig > index 005e02dd4a91..8f6273c837ec 100644 > --- a/drivers/phy/marvell/Kconfig > +++ b/drivers/phy/marvell/Kconfig > @@ -10,14 +10,16 @@ config ARMADA375_USBCLUSTER_PHY > > config PHY_BERLIN_SATA > tristate "Marvell Berlin SATA PHY driver" > - depends on ARCH_BERLIN && HAS_IOMEM && OF > + depends on ARCH_BERLIN || COMPILE_TEST > + depends on OF && HAS_IOMEM > select GENERIC_PHY > help > Enable this to support the SATA PHY on Marvell Berlin SoCs. > > config PHY_BERLIN_USB > tristate "Marvell Berlin USB PHY Driver" > - depends on ARCH_BERLIN && RESET_CONTROLLER && HAS_IOMEM && OF > + depends on ARCH_BERLIN || COMPILE_TEST > + depends on OF && HAS_IOMEM && RESET_CONTROLLER > select GENERIC_PHY > help > Enable this to support the USB PHY on Marvell Berlin SoCs. > @@ -95,7 +97,7 @@ config PHY_PXA_28NM_USB2 > > config PHY_PXA_USB > tristate "Marvell PXA USB PHY Driver" > - depends on ARCH_PXA || ARCH_MMP > + depends on ARCH_PXA || ARCH_MMP || COMPILE_TEST > select GENERIC_PHY > help > Enable this to support Marvell PXA USB PHY driver for Marvell > diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig > index 7d19134c6b7c..dee757c957f2 100644 > --- a/drivers/phy/mediatek/Kconfig > +++ b/drivers/phy/mediatek/Kconfig > @@ -4,7 +4,8 @@ > # > config PHY_MTK_TPHY > tristate "MediaTek T-PHY Driver" > - depends on ARCH_MEDIATEK && OF > + depends on ARCH_MEDIATEK || COMPILE_TEST > + depends on OF > select GENERIC_PHY > help > Say 'Y' here to add support for MediaTek T-PHY driver, > @@ -16,7 +17,8 @@ config PHY_MTK_TPHY > > config PHY_MTK_UFS > tristate "MediaTek UFS M-PHY driver" > - depends on ARCH_MEDIATEK && OF > + depends on ARCH_MEDIATEK || COMPILE_TEST > + depends on OF > select GENERIC_PHY > help > Support for UFS M-PHY on MediaTek chipsets. > @@ -26,7 +28,8 @@ config PHY_MTK_UFS > > config PHY_MTK_XSPHY > tristate "MediaTek XS-PHY Driver" > - depends on ARCH_MEDIATEK && OF > + depends on ARCH_MEDIATEK || COMPILE_TEST > + depends on OF > select GENERIC_PHY > help > Enable this to support the SuperSpeedPlus XS-PHY transceiver for > diff --git a/drivers/phy/samsung/Kconfig b/drivers/phy/samsung/Kconfig > index 290a6c70f570..349fcb23e5f3 100644 > --- a/drivers/phy/samsung/Kconfig > +++ b/drivers/phy/samsung/Kconfig > @@ -32,7 +32,7 @@ config PHY_EXYNOS_PCIE > config PHY_SAMSUNG_USB2 > tristate "Samsung USB 2.0 PHY driver" > depends on HAS_IOMEM > - depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS || USB_DWC2 > + depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS || USB_DWC2 || COMPILE_TEST > select GENERIC_PHY > select MFD_SYSCON > default ARCH_EXYNOS > @@ -60,7 +60,7 @@ config PHY_EXYNOS5250_USB2 > config PHY_S5PV210_USB2 > bool "Support for S5PV210" > depends on PHY_SAMSUNG_USB2 > - depends on ARCH_S5PV210 > + depends on ARCH_S5PV210 || COMPILE_TEST > help > Enable USB PHY support for S5PV210. This option requires that Samsung > USB 2.0 PHY driver is enabled and means that support for this > @@ -69,7 +69,7 @@ config PHY_S5PV210_USB2 > > config PHY_EXYNOS5_USBDRD > tristate "Exynos5 SoC series USB DRD PHY driver" > - depends on ARCH_EXYNOS && OF > + depends on (ARCH_EXYNOS && OF) || COMPILE_TEST > depends on HAS_IOMEM > depends on USB_DWC3_EXYNOS > select GENERIC_PHY > @@ -82,7 +82,7 @@ config PHY_EXYNOS5_USBDRD > > config PHY_EXYNOS5250_SATA > tristate "Exynos5250 Sata SerDes/PHY driver" > - depends on SOC_EXYNOS5250 > + depends on SOC_EXYNOS5250 || COMPILE_TEST > depends on HAS_IOMEM > depends on OF > select GENERIC_PHY > diff --git a/drivers/phy/ti/Kconfig b/drivers/phy/ti/Kconfig > index 174888609779..e231c0e369c5 100644 > --- a/drivers/phy/ti/Kconfig > +++ b/drivers/phy/ti/Kconfig > @@ -4,7 +4,7 @@ > # > config PHY_DA8XX_USB > tristate "TI DA8xx USB PHY Driver" > - depends on ARCH_DAVINCI_DA8XX > + depends on ARCH_DAVINCI_DA8XX || COMPILE_TEST > select GENERIC_PHY > select MFD_SYSCON > help > @@ -14,7 +14,7 @@ config PHY_DA8XX_USB > > config PHY_DM816X_USB > tristate "TI dm816x USB PHY driver" > - depends on ARCH_OMAP2PLUS > + depends on ARCH_OMAP2PLUS || COMPILE_TEST > depends on USB_SUPPORT > select GENERIC_PHY > select USB_PHY > -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] phy: Enable compile testing for some of drivers 2019-12-30 20:10 ` Florian Fainelli @ 2019-12-31 8:20 ` Krzysztof Kozlowski 0 siblings, 0 replies; 4+ messages in thread From: Krzysztof Kozlowski @ 2019-12-31 8:20 UTC (permalink / raw) To: Florian Fainelli Cc: linux-kernel, Maxime Ripard, Kishon Vijay Abraham I, Matthias Brugger, linux-mediatek, Chunfeng Yun, linux-arm-kernel On Mon, Dec 30, 2019 at 12:10:51PM -0800, Florian Fainelli wrote: > Hi Krzysztof, > > On 12/30/19 9:24 AM, Krzysztof Kozlowski wrote: > > Some of the phy drivers can be compile tested to increase build > > coverage. > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > This looks fine, you could also consider adding a bunch of other > Broadcom PHY drivers which are not currently under COMPILE_TEST, yet > build fine: I'll send a v2 with them as well. They seem to compile fine. Best regards, Krzysztof > > diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig > index d3d983c128ea..d56db6d375e1 100644 > --- a/drivers/phy/broadcom/Kconfig > +++ b/drivers/phy/broadcom/Kconfig > @@ -50,7 +50,7 @@ config PHY_BCM_NS_USB3 > > config PHY_NS2_PCIE > tristate "Broadcom Northstar2 PCIe PHY driver" > - depends on OF && MDIO_BUS_MUX_BCM_IPROC > + depends on (OF && MDIO_BUS_MUX_BCM_IPROC) || COMPILE_TEST > select GENERIC_PHY > default ARCH_BCM_IPROC > help > @@ -83,7 +83,7 @@ config PHY_BRCM_SATA > > config PHY_BRCM_USB > tristate "Broadcom STB USB PHY driver" > - depends on ARCH_BRCMSTB > + depends on ARCH_BRCMSTB || COMPILE_TEST > depends on OF > select GENERIC_PHY > select SOC_BRCMSTB > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-31 8:20 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-12-30 17:24 [PATCH 1/2] phy: mediatek: Fix Kconfig indentation Krzysztof Kozlowski 2019-12-30 17:24 ` [PATCH 2/2] phy: Enable compile testing for some of drivers Krzysztof Kozlowski 2019-12-30 20:10 ` Florian Fainelli 2019-12-31 8:20 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).