From: Shawn Guo <shawnguo@kernel.org>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, andreas@kemnade.info, Linux-imx@nxp.com,
kernel@pengutronix.de, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect power supply assignment
Date: Thu, 9 Jan 2020 16:06:01 +0800 [thread overview]
Message-ID: <20200109080600.GH4456@T480> (raw)
In-Reply-To: <1577670071-1322-1-git-send-email-Anson.Huang@nxp.com>
On Mon, Dec 30, 2019 at 09:41:07AM +0800, Anson Huang wrote:
> The vdd3p0's input should be from external USB VBUS directly, NOT
Shouldn't USB VBUS usually be 5V? It doesn't seem to match 3.0V which
is suggested by vdd3p0 name.
> PMIC's sw2, so remove the power supply assignment for vdd3p0.
>
> Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign corresponding power supply for LDOs")
Is it only a description correcting or is it fixing a real problem? I'm
trying to understand it is a 5.5-rc material or can be applied for 5.6.
Shawn
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index 71ca76a..fe59dde 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -749,10 +749,6 @@
> vin-supply = <&vgen5_reg>;
> };
>
> -®_vdd3p0 {
> - vin-supply = <&sw2_reg>;
> -};
> -
> ®_vdd2p5 {
> vin-supply = <&vgen5_reg>;
> };
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-09 8:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 1:41 [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect power supply assignment Anson Huang
2019-12-30 1:41 ` [PATCH 2/5] ARM: dts: imx6sx-sdb: " Anson Huang
2019-12-30 1:41 ` [PATCH 3/5] ARM: dts: imx6sl-evk: " Anson Huang
2019-12-30 1:41 ` [PATCH 4/5] ARM: dts: imx6sll-evk: " Anson Huang
2019-12-30 1:41 ` [PATCH 5/5] ARM: dts: imx6sl-tolino-shine3: " Anson Huang
2020-01-09 8:06 ` Shawn Guo [this message]
2020-01-09 8:25 ` [PATCH 1/5] ARM: dts: imx6qdl-sabresd: " Anson Huang
2020-01-09 9:09 ` Shawn Guo
2020-01-09 9:25 ` Anson Huang
2020-01-09 9:28 ` Anson Huang
2020-01-09 10:38 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109080600.GH4456@T480 \
--to=shawnguo@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).