From: Anson Huang <anson.huang@nxp.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"andreas@kemnade.info" <andreas@kemnade.info>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect power supply assignment
Date: Thu, 9 Jan 2020 09:25:35 +0000 [thread overview]
Message-ID: <DB3PR0402MB3916EBF00EECB42C1F4E2D40F5390@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200109090950.GJ4456@T480>
Hi, Shawn
> Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> power supply assignment
>
> On Thu, Jan 09, 2020 at 08:25:03AM +0000, Anson Huang wrote:
> > Hi, Shawn
> >
> > > Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> > > power supply assignment
> > >
> > > On Mon, Dec 30, 2019 at 09:41:07AM +0800, Anson Huang wrote:
> > > > The vdd3p0's input should be from external USB VBUS directly, NOT
> > >
> > > Shouldn't USB VBUS usually be 5V? It doesn't seem to match 3.0V
> > > which is suggested by vdd3p0 name.
> > >
> > > > PMIC's sw2, so remove the power supply assignment for vdd3p0.
> > > >
> > > > Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign
> > > > corresponding power supply for LDOs")
> > >
> > > Is it only a description correcting or is it fixing a real problem?
> > > I'm trying to understand it is a 5.5-rc material or can be applied for 5.6.
> > >
> >
> > It is fixing a real problem about USB LDO voltage, that is why we noticed
> this issue.
>
> Okay, please describe the problem a little bit in the commit log. Also squash
> the series into one patch, which is easier to be merged into -rc as a fix.
OK, will send a new patch with squashing them together, but will NOT have the fix tag,
is it OK? As the fix tag are different for each patch.
>
> My question above that USB VUBS is 5V which doesn't match 3.0V suggested
> by vdd3p0 name remains unaddressed though.
The vdd3p0 is a LDO, the input is the USB VBUS 5V, output can be programmed to
3.2V, I think the name is from the target output voltage.
Anson
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-09 9:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 1:41 [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect power supply assignment Anson Huang
2019-12-30 1:41 ` [PATCH 2/5] ARM: dts: imx6sx-sdb: " Anson Huang
2019-12-30 1:41 ` [PATCH 3/5] ARM: dts: imx6sl-evk: " Anson Huang
2019-12-30 1:41 ` [PATCH 4/5] ARM: dts: imx6sll-evk: " Anson Huang
2019-12-30 1:41 ` [PATCH 5/5] ARM: dts: imx6sl-tolino-shine3: " Anson Huang
2020-01-09 8:06 ` [PATCH 1/5] ARM: dts: imx6qdl-sabresd: " Shawn Guo
2020-01-09 8:25 ` Anson Huang
2020-01-09 9:09 ` Shawn Guo
2020-01-09 9:25 ` Anson Huang [this message]
2020-01-09 9:28 ` Anson Huang
2020-01-09 10:38 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB3916EBF00EECB42C1F4E2D40F5390@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).