* [PATCH v1 1/1] pinctrl: iproc: Use platform_get_irq_optional() to avoid error message
@ 2020-01-10 3:55 Rayagonda Kokatanur
2020-01-12 20:00 ` Chris Packham
2020-01-15 12:46 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Rayagonda Kokatanur @ 2020-01-10 3:55 UTC (permalink / raw)
To: Linus Walleij, Ray Jui, Scott Branden, bcm-kernel-feedback-list,
Chris Packham, Li Jin, YueHaibing, linux-gpio, linux-arm-kernel,
linux-kernel
Cc: Rayagonda Kokatanur
Use platform_get_irq_optional() instead of platform_get_irq() to avoid
below error message during probe:
[ 0.589121] iproc-gpio 66424800.gpio: IRQ index 0 not found
Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
---
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
index 831a9318c384..0d2bdb818d41 100644
--- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
@@ -843,7 +843,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
"gpio-ranges");
/* optional GPIO interrupt support */
- irq = platform_get_irq(pdev, 0);
+ irq = platform_get_irq_optional(pdev, 0);
if (irq > 0) {
struct irq_chip *irqc;
struct gpio_irq_chip *girq;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] pinctrl: iproc: Use platform_get_irq_optional() to avoid error message
2020-01-10 3:55 [PATCH v1 1/1] pinctrl: iproc: Use platform_get_irq_optional() to avoid error message Rayagonda Kokatanur
@ 2020-01-12 20:00 ` Chris Packham
2020-01-15 12:46 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Chris Packham @ 2020-01-12 20:00 UTC (permalink / raw)
To: linux-kernel, bcm-kernel-feedback-list, yuehaibing,
linus.walleij, linux-gpio, rjui, rayagonda.kokatanur, sbranden,
linux-arm-kernel, li.jin
On Fri, 2020-01-10 at 09:25 +0530, Rayagonda Kokatanur wrote:
> Use platform_get_irq_optional() instead of platform_get_irq() to avoid
> below error message during probe:
>
> [ 0.589121] iproc-gpio 66424800.gpio: IRQ index 0 not found
>
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> index 831a9318c384..0d2bdb818d41 100644
> --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> @@ -843,7 +843,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
> "gpio-ranges");
>
> /* optional GPIO interrupt support */
> - irq = platform_get_irq(pdev, 0);
> + irq = platform_get_irq_optional(pdev, 0);
> if (irq > 0) {
> struct irq_chip *irqc;
> struct gpio_irq_chip *girq;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] pinctrl: iproc: Use platform_get_irq_optional() to avoid error message
2020-01-10 3:55 [PATCH v1 1/1] pinctrl: iproc: Use platform_get_irq_optional() to avoid error message Rayagonda Kokatanur
2020-01-12 20:00 ` Chris Packham
@ 2020-01-15 12:46 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2020-01-15 12:46 UTC (permalink / raw)
To: Rayagonda Kokatanur
Cc: Scott Branden, Ray Jui, YueHaibing, linux-kernel,
open list:GPIO SUBSYSTEM, Chris Packham,
bcm-kernel-feedback-list, Li Jin, Linux ARM
On Fri, Jan 10, 2020 at 4:55 AM Rayagonda Kokatanur
<rayagonda.kokatanur@broadcom.com> wrote:
> Use platform_get_irq_optional() instead of platform_get_irq() to avoid
> below error message during probe:
>
> [ 0.589121] iproc-gpio 66424800.gpio: IRQ index 0 not found
>
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Patch applied with Chris' ACK.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-15 12:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-10 3:55 [PATCH v1 1/1] pinctrl: iproc: Use platform_get_irq_optional() to avoid error message Rayagonda Kokatanur
2020-01-12 20:00 ` Chris Packham
2020-01-15 12:46 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).