From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Paul Elliott" <paul.elliott@arm.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Andrew Jones" <drjones@redhat.com>,
"Amit Kachhap" <amit.kachhap@arm.com>,
"Vincenzo Frascino" <vincenzo.frascino@arm.com>,
"Will Deacon" <will@kernel.org>,
linux-arch@vger.kernel.org, "Marc Zyngier" <maz@kernel.org>,
"Eugene Syromiatnikov" <esyr@redhat.com>,
"Szabolcs Nagy" <szabolcs.nagy@arm.com>,
"Dave Martin" <Dave.Martin@arm.com>,
"H.J. Lu" <hjl.tools@gmail.com>,
"Yu-cheng Yu" <yu-cheng.yu@intel.com>,
"Kees Cook" <keescook@chromium.org>,
"Arnd Bergmann" <arnd@arndb.de>, "Jann Horn" <jannh@google.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Kristina Martšenko" <kristina.martsenko@arm.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
"Florian Weimer" <fweimer@redhat.com>,
linux-kernel@vger.kernel.org, "Sudakshina Das" <sudi.das@arm.com>
Subject: Re: [PATCH v4 06/12] arm64: elf: Enable BTI at exec based on ELF program properties
Date: Tue, 14 Jan 2020 17:33:37 +0000 [thread overview]
Message-ID: <20200114173336.GJ30444@arrakis.emea.arm.com> (raw)
In-Reply-To: <20191211154206.46260-7-broonie@kernel.org>
On Wed, Dec 11, 2019 at 03:42:00PM +0000, Mark Brown wrote:
> +static inline int arch_parse_elf_property(u32 type, const void *data,
> + size_t datasz, bool compat,
> + struct arch_elf_state *arch)
> +{
> + /* No known properties for AArch32 yet */
> + if (IS_ENABLED(CONFIG_COMPAT) && compat)
> + return 0;
> +
> + if (type == GNU_PROPERTY_AARCH64_FEATURE_1_AND) {
> + const u32 *p = data;
> +
> + if (datasz != sizeof(*p))
> + return -EIO;
Is this -EIO or -ENOEXEC sounds better?
Apart from this, the patch looks fine.
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-14 17:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 15:41 [PATCH v4 00/12] arm64: ARMv8.5-A: Branch Target Identification support Mark Brown
2019-12-11 15:41 ` [PATCH v4 01/12] ELF: UAPI and Kconfig additions for ELF program properties Mark Brown
2020-01-14 15:03 ` Catalin Marinas
2019-12-11 15:41 ` [PATCH v4 02/12] ELF: Add ELF program property parsing support Mark Brown
2020-01-14 16:34 ` Catalin Marinas
2020-01-14 17:28 ` Mark Brown
2019-12-11 15:41 ` [PATCH v4 03/12] mm: Reserve asm-generic prot flag 0x10 for arch use Mark Brown
2019-12-12 10:48 ` Catalin Marinas
2019-12-12 16:16 ` Mark Brown
2019-12-11 15:41 ` [PATCH v4 04/12] arm64: Basic Branch Target Identification support Mark Brown
2020-01-10 18:28 ` Catalin Marinas
2020-01-13 14:00 ` Mark Brown
2019-12-11 15:41 ` [PATCH v4 05/12] elf: Allow arch to tweak initial mmap prot flags Mark Brown
2020-01-14 16:38 ` Catalin Marinas
2019-12-11 15:42 ` [PATCH v4 06/12] arm64: elf: Enable BTI at exec based on ELF program properties Mark Brown
2020-01-14 17:33 ` Catalin Marinas [this message]
2019-12-11 15:42 ` [PATCH v4 07/12] arm64: BTI: Decode BYTPE bits when printing PSTATE Mark Brown
2020-01-14 17:34 ` Catalin Marinas
2019-12-11 15:42 ` [PATCH v4 08/12] arm64: unify native/compat instruction skipping Mark Brown
2020-01-13 16:43 ` Catalin Marinas
2019-12-11 15:42 ` [PATCH v4 09/12] arm64: traps: Shuffle code to eliminate forward declarations Mark Brown
2020-01-14 17:35 ` Catalin Marinas
2019-12-11 15:42 ` [PATCH v4 10/12] arm64: BTI: Reset BTYPE when skipping emulated instructions Mark Brown
2020-01-14 17:36 ` Catalin Marinas
2019-12-11 15:42 ` [PATCH v4 11/12] KVM: " Mark Brown
2020-01-14 17:36 ` Catalin Marinas
2019-12-11 15:42 ` [PATCH v4 12/12] arm64: mm: Display guarded pages in ptdump Mark Brown
2020-01-14 17:37 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114173336.GJ30444@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=Dave.Martin@arm.com \
--cc=amit.kachhap@arm.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=drjones@redhat.com \
--cc=esyr@redhat.com \
--cc=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=kristina.martsenko@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=paul.elliott@arm.com \
--cc=peterz@infradead.org \
--cc=richard.henderson@linaro.org \
--cc=sudi.das@arm.com \
--cc=szabolcs.nagy@arm.com \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).