Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v7] mfd: mt6360: add pmic mt6360 driver
@ 2020-01-07 15:33 Gene Chen
  2020-01-09 18:51 ` kbuild test robot
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Gene Chen @ 2020-01-07 15:33 UTC (permalink / raw)
  To: lee.jones, matthias.bgg
  Cc: gene_chen, linux-kernel, cy_huang, linux-mediatek, Wilma.Wu,
	linux-arm-kernel, shufan_lee

From: Gene Chen <gene_chen@richtek.com>

Add mfd driver for mt6360 pmic chip include
Battery Charger/USB_PD/Flash LED/RGB LED/LDO/Buck

Signed-off-by: Gene Chen <gene_chen@richtek.com
---
 drivers/mfd/Kconfig        |  12 ++
 drivers/mfd/Makefile       |   1 +
 drivers/mfd/mt6360-core.c  | 424 +++++++++++++++++++++++++++++++++++++
 include/linux/mfd/mt6360.h | 240 +++++++++++++++++++++
 4 files changed, 677 insertions(+)
 create mode 100644 drivers/mfd/mt6360-core.c
 create mode 100644 include/linux/mfd/mt6360.h

changelogs between v1 & v2
- include missing header file

changelogs between v2 & v3
- add changelogs

changelogs between v3 & v4
- fix Kconfig description
- replace mt6360_pmu_info with mt6360_pmu_data
- replace probe with probe_new
- remove unnecessary irq_chip variable
- remove annotation
- replace MT6360_MFD_CELL with OF_MFD_CELL

changelogs between v4 & v5
- remove unnecessary parse dt function
- use devm_i2c_new_dummy_device
- add base-commit message

changelogs between v5 & v6
- review return value
- remove i2c id_table
- use GPL license v2

changelogs between v6 & v7
- add author description
- replace MT6360_REGMAP_IRQ_REG by REGMAP_IRQ_REG_LINE
- remove mt6360-private.h

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 420900852166..e6df91d55405 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -856,6 +856,18 @@ config MFD_MAX8998
 	  additional drivers must be enabled in order to use the functionality
 	  of the device.
 
+config MFD_MT6360
+	tristate "Mediatek MT6360 SubPMIC"
+	select MFD_CORE
+	select REGMAP_I2C
+	select REGMAP_IRQ
+	depends on I2C
+	help
+	  Say Y here to enable MT6360 PMU/PMIC/LDO functional support.
+	  PMU part includes Charger, Flashlight, RGB LED
+	  PMIC part includes 2-channel BUCKs and 2-channel LDOs
+	  LDO part includes 4-channel LDOs
+
 config MFD_MT6397
 	tristate "MediaTek MT6397 PMIC Support"
 	select MFD_CORE
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index aed99f08739f..f5f80d75ee53 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -237,6 +237,7 @@ obj-$(CONFIG_INTEL_SOC_PMIC)	+= intel-soc-pmic.o
 obj-$(CONFIG_INTEL_SOC_PMIC_BXTWC)	+= intel_soc_pmic_bxtwc.o
 obj-$(CONFIG_INTEL_SOC_PMIC_CHTWC)	+= intel_soc_pmic_chtwc.o
 obj-$(CONFIG_INTEL_SOC_PMIC_CHTDC_TI)	+= intel_soc_pmic_chtdc_ti.o
+obj-$(CONFIG_MFD_MT6360)	+= mt6360-core.o
 mt6397-objs	:= mt6397-core.o mt6397-irq.o
 obj-$(CONFIG_MFD_MT6397)	+= mt6397.o
 obj-$(CONFIG_INTEL_SOC_PMIC_MRFLD)	+= intel_soc_pmic_mrfld.o
diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c
new file mode 100644
index 000000000000..9a0a0584d3ba
--- /dev/null
+++ b/drivers/mfd/mt6360-core.c
@@ -0,0 +1,424 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2019 MediaTek Inc.
+ *
+ * Author: Gene Chen <gene_chen@richtek.com>
+ */
+
+#include <linux/i2c.h>
+#include <linux/init.h>
+#include <linux/kernel.h>
+#include <linux/mfd/core.h>
+#include <linux/module.h>
+#include <linux/of_irq.h>
+#include <linux/of_platform.h>
+#include <linux/version.h>
+
+#include <linux/mfd/mt6360.h>
+
+/* reg 0 -> 0 ~ 7 */
+#define MT6360_CHG_TREG_EVT		(4)
+#define MT6360_CHG_AICR_EVT		(5)
+#define MT6360_CHG_MIVR_EVT		(6)
+#define MT6360_PWR_RDY_EVT		(7)
+/* REG 1 -> 8 ~ 15 */
+#define MT6360_CHG_BATSYSUV_EVT		(9)
+#define MT6360_FLED_CHG_VINOVP_EVT	(11)
+#define MT6360_CHG_VSYSUV_EVT		(12)
+#define MT6360_CHG_VSYSOV_EVT		(13)
+#define MT6360_CHG_VBATOV_EVT		(14)
+#define MT6360_CHG_VBUSOV_EVT		(15)
+/* REG 2 -> 16 ~ 23 */
+/* REG 3 -> 24 ~ 31 */
+#define MT6360_WD_PMU_DET		(25)
+#define MT6360_WD_PMU_DONE		(26)
+#define MT6360_CHG_TMRI			(27)
+#define MT6360_CHG_ADPBADI		(29)
+#define MT6360_CHG_RVPI			(30)
+#define MT6360_OTPI			(31)
+/* REG 4 -> 32 ~ 39 */
+#define MT6360_CHG_AICCMEASL		(32)
+#define MT6360_CHGDET_DONEI		(34)
+#define MT6360_WDTMRI			(35)
+#define MT6360_SSFINISHI		(36)
+#define MT6360_CHG_RECHGI		(37)
+#define MT6360_CHG_TERMI		(38)
+#define MT6360_CHG_IEOCI		(39)
+/* REG 5 -> 40 ~ 47 */
+#define MT6360_PUMPX_DONEI		(40)
+#define MT6360_BAT_OVP_ADC_EVT		(41)
+#define MT6360_TYPEC_OTP_EVT		(42)
+#define MT6360_ADC_WAKEUP_EVT		(43)
+#define MT6360_ADC_DONEI		(44)
+#define MT6360_BST_BATUVI		(45)
+#define MT6360_BST_VBUSOVI		(46)
+#define MT6360_BST_OLPI			(47)
+/* REG 6 -> 48 ~ 55 */
+#define MT6360_ATTACH_I			(48)
+#define MT6360_DETACH_I			(49)
+#define MT6360_QC30_STPDONE		(51)
+#define MT6360_QC_VBUSDET_DONE		(52)
+#define MT6360_HVDCP_DET		(53)
+#define MT6360_CHGDETI			(54)
+#define MT6360_DCDTI			(55)
+/* REG 7 -> 56 ~ 63 */
+#define MT6360_FOD_DONE_EVT		(56)
+#define MT6360_FOD_OV_EVT		(57)
+#define MT6360_CHRDET_UVP_EVT		(58)
+#define MT6360_CHRDET_OVP_EVT		(59)
+#define MT6360_CHRDET_EXT_EVT		(60)
+#define MT6360_FOD_LR_EVT		(61)
+#define MT6360_FOD_HR_EVT		(62)
+#define MT6360_FOD_DISCHG_FAIL_EVT	(63)
+/* REG 8 -> 64 ~ 71 */
+#define MT6360_USBID_EVT		(64)
+#define MT6360_APWDTRST_EVT		(65)
+#define MT6360_EN_EVT			(66)
+#define MT6360_QONB_RST_EVT		(67)
+#define MT6360_MRSTB_EVT		(68)
+#define MT6360_OTP_EVT			(69)
+#define MT6360_VDDAOV_EVT		(70)
+#define MT6360_SYSUV_EVT		(71)
+/* REG 9 -> 72 ~ 79 */
+#define MT6360_FLED_STRBPIN_EVT		(72)
+#define MT6360_FLED_TORPIN_EVT		(73)
+#define MT6360_FLED_TX_EVT		(74)
+#define MT6360_FLED_LVF_EVT		(75)
+#define MT6360_FLED2_SHORT_EVT		(78)
+#define MT6360_FLED1_SHORT_EVT		(79)
+/* REG 10 -> 80 ~ 87 */
+#define MT6360_FLED2_STRB_EVT		(80)
+#define MT6360_FLED1_STRB_EVT		(81)
+#define MT6360_FLED2_STRB_TO_EVT	(82)
+#define MT6360_FLED1_STRB_TO_EVT	(83)
+#define MT6360_FLED2_TOR_EVT		(84)
+#define MT6360_FLED1_TOR_EVT		(85)
+/* REG 11 -> 88 ~ 95 */
+/* REG 12 -> 96 ~ 103 */
+#define MT6360_BUCK1_PGB_EVT		(96)
+#define MT6360_BUCK1_OC_EVT		(100)
+#define MT6360_BUCK1_OV_EVT		(101)
+#define MT6360_BUCK1_UV_EVT		(102)
+/* REG 13 -> 104 ~ 111 */
+#define MT6360_BUCK2_PGB_EVT		(104)
+#define MT6360_BUCK2_OC_EVT		(108)
+#define MT6360_BUCK2_OV_EVT		(109)
+#define MT6360_BUCK2_UV_EVT		(110)
+/* REG 14 -> 112 ~ 119 */
+#define MT6360_LDO1_OC_EVT		(113)
+#define MT6360_LDO2_OC_EVT		(114)
+#define MT6360_LDO3_OC_EVT		(115)
+#define MT6360_LDO5_OC_EVT		(117)
+#define MT6360_LDO6_OC_EVT		(118)
+#define MT6360_LDO7_OC_EVT		(119)
+/* REG 15 -> 120 ~ 127 */
+#define MT6360_LDO1_PGB_EVT		(121)
+#define MT6360_LDO2_PGB_EVT		(122)
+#define MT6360_LDO3_PGB_EVT		(123)
+#define MT6360_LDO5_PGB_EVT		(125)
+#define MT6360_LDO6_PGB_EVT		(126)
+#define MT6360_LDO7_PGB_EVT		(127)
+
+static const struct regmap_irq mt6360_pmu_irqs[] =  {
+	REGMAP_IRQ_REG_LINE(MT6360_CHG_TREG_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHG_AICR_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHG_MIVR_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_PWR_RDY_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHG_BATSYSUV_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_FLED_CHG_VINOVP_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHG_VSYSUV_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHG_VSYSOV_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHG_VBATOV_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHG_VBUSOV_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_WD_PMU_DET, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_WD_PMU_DONE, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHG_TMRI, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHG_ADPBADI, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHG_RVPI, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_OTPI, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHG_AICCMEASL, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHGDET_DONEI, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_WDTMRI, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_SSFINISHI, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHG_RECHGI, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHG_TERMI, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHG_IEOCI, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_PUMPX_DONEI, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHG_TREG_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_BAT_OVP_ADC_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_TYPEC_OTP_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_ADC_WAKEUP_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_ADC_DONEI, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_BST_BATUVI, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_BST_VBUSOVI, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_BST_OLPI, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_ATTACH_I, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_DETACH_I, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_QC30_STPDONE, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_QC_VBUSDET_DONE, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_HVDCP_DET, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHGDETI, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_DCDTI, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_FOD_DONE_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_FOD_OV_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHRDET_UVP_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHRDET_OVP_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_CHRDET_EXT_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_FOD_LR_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_FOD_HR_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_FOD_DISCHG_FAIL_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_USBID_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_APWDTRST_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_EN_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_QONB_RST_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_MRSTB_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_OTP_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_VDDAOV_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_SYSUV_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_FLED_STRBPIN_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_FLED_TORPIN_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_FLED_TX_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_FLED_LVF_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_FLED2_SHORT_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_FLED1_SHORT_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_FLED2_STRB_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_FLED1_STRB_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_FLED2_STRB_TO_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_FLED1_STRB_TO_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_FLED2_TOR_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_FLED1_TOR_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_BUCK1_PGB_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_BUCK1_OC_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_BUCK1_OV_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_BUCK1_UV_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_BUCK2_PGB_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_BUCK2_OC_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_BUCK2_OV_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_BUCK2_UV_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_LDO1_OC_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_LDO2_OC_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_LDO3_OC_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_LDO5_OC_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_LDO6_OC_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_LDO7_OC_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_LDO1_PGB_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_LDO2_PGB_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_LDO3_PGB_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_LDO5_PGB_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_LDO6_PGB_EVT, 8),
+	REGMAP_IRQ_REG_LINE(MT6360_LDO7_PGB_EVT, 8),
+};
+
+static int mt6360_pmu_handle_post_irq(void *irq_drv_data)
+{
+	struct mt6360_pmu_data *mpd = irq_drv_data;
+
+	return regmap_update_bits(mpd->regmap,
+		MT6360_PMU_IRQ_SET, MT6360_IRQ_RETRIG, MT6360_IRQ_RETRIG);
+}
+
+static struct regmap_irq_chip mt6360_pmu_irq_chip = {
+	.irqs = mt6360_pmu_irqs,
+	.num_irqs = ARRAY_SIZE(mt6360_pmu_irqs),
+	.num_regs = MT6360_PMU_IRQ_REGNUM,
+	.mask_base = MT6360_PMU_CHG_MASK1,
+	.status_base = MT6360_PMU_CHG_IRQ1,
+	.ack_base = MT6360_PMU_CHG_IRQ1,
+	.init_ack_masked = true,
+	.use_ack = true,
+	.handle_post_irq = mt6360_pmu_handle_post_irq,
+};
+
+static const struct regmap_config mt6360_pmu_regmap_config = {
+	.reg_bits = 8,
+	.val_bits = 8,
+	.max_register = MT6360_PMU_MAXREG,
+};
+
+static const struct resource mt6360_adc_resources[] = {
+	DEFINE_RES_IRQ_NAMED(MT6360_ADC_DONEI, "adc_donei"),
+};
+
+static const struct resource mt6360_chg_resources[] = {
+	DEFINE_RES_IRQ_NAMED(MT6360_CHG_TREG_EVT, "chg_treg_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_PWR_RDY_EVT, "pwr_rdy_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_CHG_BATSYSUV_EVT, "chg_batsysuv_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_CHG_VSYSUV_EVT, "chg_vsysuv_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_CHG_VSYSOV_EVT, "chg_vsysov_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_CHG_VBATOV_EVT, "chg_vbatov_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_CHG_VBUSOV_EVT, "chg_vbusov_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_CHG_AICCMEASL, "chg_aiccmeasl"),
+	DEFINE_RES_IRQ_NAMED(MT6360_WDTMRI, "wdtmri"),
+	DEFINE_RES_IRQ_NAMED(MT6360_CHG_RECHGI, "chg_rechgi"),
+	DEFINE_RES_IRQ_NAMED(MT6360_CHG_TERMI, "chg_termi"),
+	DEFINE_RES_IRQ_NAMED(MT6360_CHG_IEOCI, "chg_ieoci"),
+	DEFINE_RES_IRQ_NAMED(MT6360_PUMPX_DONEI, "pumpx_donei"),
+	DEFINE_RES_IRQ_NAMED(MT6360_ATTACH_I, "attach_i"),
+	DEFINE_RES_IRQ_NAMED(MT6360_CHRDET_EXT_EVT, "chrdet_ext_evt"),
+};
+
+static const struct resource mt6360_led_resources[] = {
+	DEFINE_RES_IRQ_NAMED(MT6360_FLED_CHG_VINOVP_EVT, "fled_chg_vinovp_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_FLED_LVF_EVT, "fled_lvf_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_FLED2_SHORT_EVT, "fled2_short_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_FLED1_SHORT_EVT, "fled1_short_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_FLED2_STRB_TO_EVT, "fled2_strb_to_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_FLED1_STRB_TO_EVT, "fled1_strb_to_evt"),
+};
+
+static const struct resource mt6360_pmic_resources[] = {
+	DEFINE_RES_IRQ_NAMED(MT6360_BUCK1_PGB_EVT, "buck1_pgb_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_BUCK1_OC_EVT, "buck1_oc_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_BUCK1_OV_EVT, "buck1_ov_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_BUCK1_UV_EVT, "buck1_uv_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_BUCK2_PGB_EVT, "buck2_pgb_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_BUCK2_OC_EVT, "buck2_oc_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_BUCK2_OV_EVT, "buck2_ov_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_BUCK2_UV_EVT, "buck2_uv_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_LDO6_OC_EVT, "ldo6_oc_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_LDO7_OC_EVT, "ldo7_oc_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_LDO6_PGB_EVT, "ldo6_pgb_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_LDO7_PGB_EVT, "ldo7_pgb_evt"),
+};
+
+static const struct resource mt6360_ldo_resources[] = {
+	DEFINE_RES_IRQ_NAMED(MT6360_LDO1_OC_EVT, "ldo1_oc_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_LDO2_OC_EVT, "ldo2_oc_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_LDO3_OC_EVT, "ldo3_oc_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_LDO5_OC_EVT, "ldo5_oc_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_LDO1_PGB_EVT, "ldo1_pgb_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_LDO2_PGB_EVT, "ldo2_pgb_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_LDO3_PGB_EVT, "ldo3_pgb_evt"),
+	DEFINE_RES_IRQ_NAMED(MT6360_LDO5_PGB_EVT, "ldo5_pgb_evt"),
+};
+
+static const struct mfd_cell mt6360_devs[] = {
+	OF_MFD_CELL("mt6360_adc", mt6360_adc_resources,
+		    NULL, 0, 0, "mediatek,mt6360_adc"),
+	OF_MFD_CELL("mt6360_chg", mt6360_chg_resources,
+		    NULL, 0, 0, "mediatek,mt6360_chg"),
+	OF_MFD_CELL("mt6360_led", mt6360_led_resources,
+		    NULL, 0, 0, "mediatek,mt6360_led"),
+	OF_MFD_CELL("mt6360_pmic", mt6360_pmic_resources,
+		    NULL, 0, 0, "mediatek,mt6360_pmic"),
+	OF_MFD_CELL("mt6360_ldo", mt6360_ldo_resources,
+		    NULL, 0, 0, "mediatek,mt6360_ldo"),
+	OF_MFD_CELL("mt6360_tcpc", NULL,
+		    NULL, 0, 0, "mediatek,mt6360_tcpc"),
+};
+
+static const unsigned short mt6360_slave_addr[MT6360_SLAVE_MAX] = {
+	MT6360_PMU_SLAVEID,
+	MT6360_PMIC_SLAVEID,
+	MT6360_LDO_SLAVEID,
+	MT6360_TCPC_SLAVEID,
+};
+
+static int mt6360_pmu_probe(struct i2c_client *client)
+{
+	struct mt6360_pmu_data *mpd;
+	unsigned int reg_data;
+	int i, ret;
+
+	mpd = devm_kzalloc(&client->dev, sizeof(*mpd), GFP_KERNEL);
+	if (!mpd)
+		return -ENOMEM;
+
+	mpd->dev = &client->dev;
+	i2c_set_clientdata(client, mpd);
+
+	mpd->regmap = devm_regmap_init_i2c(client, &mt6360_pmu_regmap_config);
+	if (IS_ERR(mpd->regmap)) {
+		dev_err(&client->dev, "Failed to register regmap\n");
+		return PTR_ERR(mpd->regmap);
+	}
+
+	ret = regmap_read(mpd->regmap, MT6360_PMU_DEV_INFO, &reg_data);
+	if (ret) {
+		dev_err(&client->dev, "Device not found\n");
+		return ret;
+	}
+
+	mpd->chip_rev = reg_data & CHIP_REV_MASK;
+	if (mpd->chip_rev != CHIP_VEN_MT6360) {
+		dev_err(&client->dev, "Device not supported\n");
+		return -ENODEV;
+	}
+
+	mt6360_pmu_irq_chip.irq_drv_data = mpd;
+	ret = devm_regmap_add_irq_chip(&client->dev, mpd->regmap, client->irq,
+				       IRQF_TRIGGER_FALLING, 0,
+				       &mt6360_pmu_irq_chip, &mpd->irq_data);
+	if (ret) {
+		dev_err(&client->dev, "Failed to add Regmap IRQ Chip\n");
+		return ret;
+	}
+
+	mpd->i2c[0] = client;
+	for (i = 1; i < MT6360_SLAVE_MAX; i++) {
+		mpd->i2c[i] = devm_i2c_new_dummy_device(&client->dev,
+							client->adapter,
+							mt6360_slave_addr[i]);
+		if (IS_ERR(mpd->i2c[i])) {
+			dev_err(&client->dev,
+				"Failed to get new dummy I2C device for address 0x%x",
+				mt6360_slave_addr[i]);
+			return PTR_ERR(mpd->i2c[i]);
+		}
+		i2c_set_clientdata(mpd->i2c[i], mpd);
+	}
+
+	ret = devm_mfd_add_devices(&client->dev, PLATFORM_DEVID_AUTO,
+				   mt6360_devs, ARRAY_SIZE(mt6360_devs), NULL,
+				   0, regmap_irq_get_domain(mpd->irq_data));
+	if (ret) {
+		dev_err(&client->dev,
+			"Failed to register subordinate devices\n");
+		return ret;
+	}
+
+	return 0;
+}
+
+static int __maybe_unused mt6360_pmu_suspend(struct device *dev)
+{
+	struct i2c_client *i2c = to_i2c_client(dev);
+
+	if (device_may_wakeup(dev))
+		enable_irq_wake(i2c->irq);
+
+	return 0;
+}
+
+static int __maybe_unused mt6360_pmu_resume(struct device *dev)
+{
+
+	struct i2c_client *i2c = to_i2c_client(dev);
+
+	if (device_may_wakeup(dev))
+		disable_irq_wake(i2c->irq);
+
+	return 0;
+}
+
+static SIMPLE_DEV_PM_OPS(mt6360_pmu_pm_ops,
+			 mt6360_pmu_suspend, mt6360_pmu_resume);
+
+static const struct of_device_id __maybe_unused mt6360_pmu_of_id[] = {
+	{ .compatible = "mediatek,mt6360_pmu", },
+	{},
+};
+MODULE_DEVICE_TABLE(of, mt6360_pmu_of_id);
+
+static struct i2c_driver mt6360_pmu_driver = {
+	.driver = {
+		.pm = &mt6360_pmu_pm_ops,
+		.of_match_table = of_match_ptr(mt6360_pmu_of_id),
+	},
+	.probe_new = mt6360_pmu_probe,
+};
+module_i2c_driver(mt6360_pmu_driver);
+
+MODULE_AUTHOR("Gene Chen <gene_chen@richtek.com>");
+MODULE_DESCRIPTION("MT6360 PMU I2C Driver");
+MODULE_LICENSE("GPL v2");
diff --git a/include/linux/mfd/mt6360.h b/include/linux/mfd/mt6360.h
new file mode 100644
index 000000000000..c03e6d1d9a02
--- /dev/null
+++ b/include/linux/mfd/mt6360.h
@@ -0,0 +1,240 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2019 MediaTek Inc.
+ */
+
+#ifndef __MT6360_H__
+#define __MT6360_H__
+
+#include <linux/regmap.h>
+
+enum {
+	MT6360_SLAVE_PMU = 0,
+	MT6360_SLAVE_PMIC,
+	MT6360_SLAVE_LDO,
+	MT6360_SLAVE_TCPC,
+	MT6360_SLAVE_MAX,
+};
+
+#define MT6360_PMU_SLAVEID	(0x34)
+#define MT6360_PMIC_SLAVEID	(0x1A)
+#define MT6360_LDO_SLAVEID	(0x64)
+#define MT6360_TCPC_SLAVEID	(0x4E)
+
+struct mt6360_pmu_data {
+	struct i2c_client *i2c[MT6360_SLAVE_MAX];
+	struct device *dev;
+	struct regmap *regmap;
+	struct regmap_irq_chip_data *irq_data;
+	unsigned int chip_rev;
+};
+
+/* PMU register defininition */
+#define MT6360_PMU_DEV_INFO			(0x00)
+#define MT6360_PMU_CORE_CTRL1			(0x01)
+#define MT6360_PMU_RST1				(0x02)
+#define MT6360_PMU_CRCEN			(0x03)
+#define MT6360_PMU_RST_PAS_CODE1		(0x04)
+#define MT6360_PMU_RST_PAS_CODE2		(0x05)
+#define MT6360_PMU_CORE_CTRL2			(0x06)
+#define MT6360_PMU_TM_PAS_CODE1			(0x07)
+#define MT6360_PMU_TM_PAS_CODE2			(0x08)
+#define MT6360_PMU_TM_PAS_CODE3			(0x09)
+#define MT6360_PMU_TM_PAS_CODE4			(0x0A)
+#define MT6360_PMU_IRQ_IND			(0x0B)
+#define MT6360_PMU_IRQ_MASK			(0x0C)
+#define MT6360_PMU_IRQ_SET			(0x0D)
+#define MT6360_PMU_SHDN_CTRL			(0x0E)
+#define MT6360_PMU_TM_INF			(0x0F)
+#define MT6360_PMU_I2C_CTRL			(0x10)
+#define MT6360_PMU_CHG_CTRL1			(0x11)
+#define MT6360_PMU_CHG_CTRL2			(0x12)
+#define MT6360_PMU_CHG_CTRL3			(0x13)
+#define MT6360_PMU_CHG_CTRL4			(0x14)
+#define MT6360_PMU_CHG_CTRL5			(0x15)
+#define MT6360_PMU_CHG_CTRL6			(0x16)
+#define MT6360_PMU_CHG_CTRL7			(0x17)
+#define MT6360_PMU_CHG_CTRL8			(0x18)
+#define MT6360_PMU_CHG_CTRL9			(0x19)
+#define MT6360_PMU_CHG_CTRL10			(0x1A)
+#define MT6360_PMU_CHG_CTRL11			(0x1B)
+#define MT6360_PMU_CHG_CTRL12			(0x1C)
+#define MT6360_PMU_CHG_CTRL13			(0x1D)
+#define MT6360_PMU_CHG_CTRL14			(0x1E)
+#define MT6360_PMU_CHG_CTRL15			(0x1F)
+#define MT6360_PMU_CHG_CTRL16			(0x20)
+#define MT6360_PMU_CHG_AICC_RESULT		(0x21)
+#define MT6360_PMU_DEVICE_TYPE			(0x22)
+#define MT6360_PMU_QC_CONTROL1			(0x23)
+#define MT6360_PMU_QC_CONTROL2			(0x24)
+#define MT6360_PMU_QC30_CONTROL1		(0x25)
+#define MT6360_PMU_QC30_CONTROL2		(0x26)
+#define MT6360_PMU_USB_STATUS1			(0x27)
+#define MT6360_PMU_QC_STATUS1			(0x28)
+#define MT6360_PMU_QC_STATUS2			(0x29)
+#define MT6360_PMU_CHG_PUMP			(0x2A)
+#define MT6360_PMU_CHG_CTRL17			(0x2B)
+#define MT6360_PMU_CHG_CTRL18			(0x2C)
+#define MT6360_PMU_CHRDET_CTRL1			(0x2D)
+#define MT6360_PMU_CHRDET_CTRL2			(0x2E)
+#define MT6360_PMU_DPDN_CTRL			(0x2F)
+#define MT6360_PMU_CHG_HIDDEN_CTRL1		(0x30)
+#define MT6360_PMU_CHG_HIDDEN_CTRL2		(0x31)
+#define MT6360_PMU_CHG_HIDDEN_CTRL3		(0x32)
+#define MT6360_PMU_CHG_HIDDEN_CTRL4		(0x33)
+#define MT6360_PMU_CHG_HIDDEN_CTRL5		(0x34)
+#define MT6360_PMU_CHG_HIDDEN_CTRL6		(0x35)
+#define MT6360_PMU_CHG_HIDDEN_CTRL7		(0x36)
+#define MT6360_PMU_CHG_HIDDEN_CTRL8		(0x37)
+#define MT6360_PMU_CHG_HIDDEN_CTRL9		(0x38)
+#define MT6360_PMU_CHG_HIDDEN_CTRL10		(0x39)
+#define MT6360_PMU_CHG_HIDDEN_CTRL11		(0x3A)
+#define MT6360_PMU_CHG_HIDDEN_CTRL12		(0x3B)
+#define MT6360_PMU_CHG_HIDDEN_CTRL13		(0x3C)
+#define MT6360_PMU_CHG_HIDDEN_CTRL14		(0x3D)
+#define MT6360_PMU_CHG_HIDDEN_CTRL15		(0x3E)
+#define MT6360_PMU_CHG_HIDDEN_CTRL16		(0x3F)
+#define MT6360_PMU_CHG_HIDDEN_CTRL17		(0x40)
+#define MT6360_PMU_CHG_HIDDEN_CTRL18		(0x41)
+#define MT6360_PMU_CHG_HIDDEN_CTRL19		(0x42)
+#define MT6360_PMU_CHG_HIDDEN_CTRL20		(0x43)
+#define MT6360_PMU_CHG_HIDDEN_CTRL21		(0x44)
+#define MT6360_PMU_CHG_HIDDEN_CTRL22		(0x45)
+#define MT6360_PMU_CHG_HIDDEN_CTRL23		(0x46)
+#define MT6360_PMU_CHG_HIDDEN_CTRL24		(0x47)
+#define MT6360_PMU_CHG_HIDDEN_CTRL25		(0x48)
+#define MT6360_PMU_BC12_CTRL			(0x49)
+#define MT6360_PMU_CHG_STAT			(0x4A)
+#define MT6360_PMU_RESV1			(0x4B)
+#define MT6360_PMU_TYPEC_OTP_TH_SEL_CODEH	(0x4E)
+#define MT6360_PMU_TYPEC_OTP_TH_SEL_CODEL	(0x4F)
+#define MT6360_PMU_TYPEC_OTP_HYST_TH		(0x50)
+#define MT6360_PMU_TYPEC_OTP_CTRL		(0x51)
+#define MT6360_PMU_ADC_BAT_DATA_H		(0x52)
+#define MT6360_PMU_ADC_BAT_DATA_L		(0x53)
+#define MT6360_PMU_IMID_BACKBST_ON		(0x54)
+#define MT6360_PMU_IMID_BACKBST_OFF		(0x55)
+#define MT6360_PMU_ADC_CONFIG			(0x56)
+#define MT6360_PMU_ADC_EN2			(0x57)
+#define MT6360_PMU_ADC_IDLE_T			(0x58)
+#define MT6360_PMU_ADC_RPT_1			(0x5A)
+#define MT6360_PMU_ADC_RPT_2			(0x5B)
+#define MT6360_PMU_ADC_RPT_3			(0x5C)
+#define MT6360_PMU_ADC_RPT_ORG1			(0x5D)
+#define MT6360_PMU_ADC_RPT_ORG2			(0x5E)
+#define MT6360_PMU_BAT_OVP_TH_SEL_CODEH		(0x5F)
+#define MT6360_PMU_BAT_OVP_TH_SEL_CODEL		(0x60)
+#define MT6360_PMU_CHG_CTRL19			(0x61)
+#define MT6360_PMU_VDDASUPPLY			(0x62)
+#define MT6360_PMU_BC12_MANUAL			(0x63)
+#define MT6360_PMU_CHGDET_FUNC			(0x64)
+#define MT6360_PMU_FOD_CTRL			(0x65)
+#define MT6360_PMU_CHG_CTRL20			(0x66)
+#define MT6360_PMU_CHG_HIDDEN_CTRL26		(0x67)
+#define MT6360_PMU_CHG_HIDDEN_CTRL27		(0x68)
+#define MT6360_PMU_RESV2			(0x69)
+#define MT6360_PMU_USBID_CTRL1			(0x6D)
+#define MT6360_PMU_USBID_CTRL2			(0x6E)
+#define MT6360_PMU_USBID_CTRL3			(0x6F)
+#define MT6360_PMU_FLED_CFG			(0x70)
+#define MT6360_PMU_RESV3			(0x71)
+#define MT6360_PMU_FLED1_CTRL			(0x72)
+#define MT6360_PMU_FLED_STRB_CTRL		(0x73)
+#define MT6360_PMU_FLED1_STRB_CTRL2		(0x74)
+#define MT6360_PMU_FLED1_TOR_CTRL		(0x75)
+#define MT6360_PMU_FLED2_CTRL			(0x76)
+#define MT6360_PMU_RESV4			(0x77)
+#define MT6360_PMU_FLED2_STRB_CTRL2		(0x78)
+#define MT6360_PMU_FLED2_TOR_CTRL		(0x79)
+#define MT6360_PMU_FLED_VMIDTRK_CTRL1		(0x7A)
+#define MT6360_PMU_FLED_VMID_RTM		(0x7B)
+#define MT6360_PMU_FLED_VMIDTRK_CTRL2		(0x7C)
+#define MT6360_PMU_FLED_PWSEL			(0x7D)
+#define MT6360_PMU_FLED_EN			(0x7E)
+#define MT6360_PMU_FLED_Hidden1			(0x7F)
+#define MT6360_PMU_RGB_EN			(0x80)
+#define MT6360_PMU_RGB1_ISNK			(0x81)
+#define MT6360_PMU_RGB2_ISNK			(0x82)
+#define MT6360_PMU_RGB3_ISNK			(0x83)
+#define MT6360_PMU_RGB_ML_ISNK			(0x84)
+#define MT6360_PMU_RGB1_DIM			(0x85)
+#define MT6360_PMU_RGB2_DIM			(0x86)
+#define MT6360_PMU_RGB3_DIM			(0x87)
+#define MT6360_PMU_RESV5			(0x88)
+#define MT6360_PMU_RGB12_Freq			(0x89)
+#define MT6360_PMU_RGB34_Freq			(0x8A)
+#define MT6360_PMU_RGB1_Tr			(0x8B)
+#define MT6360_PMU_RGB1_Tf			(0x8C)
+#define MT6360_PMU_RGB1_TON_TOFF		(0x8D)
+#define MT6360_PMU_RGB2_Tr			(0x8E)
+#define MT6360_PMU_RGB2_Tf			(0x8F)
+#define MT6360_PMU_RGB2_TON_TOFF		(0x90)
+#define MT6360_PMU_RGB3_Tr			(0x91)
+#define MT6360_PMU_RGB3_Tf			(0x92)
+#define MT6360_PMU_RGB3_TON_TOFF		(0x93)
+#define MT6360_PMU_RGB_Hidden_CTRL1		(0x94)
+#define MT6360_PMU_RGB_Hidden_CTRL2		(0x95)
+#define MT6360_PMU_RESV6			(0x97)
+#define MT6360_PMU_SPARE1			(0x9A)
+#define MT6360_PMU_SPARE2			(0xA0)
+#define MT6360_PMU_SPARE3			(0xB0)
+#define MT6360_PMU_SPARE4			(0xC0)
+#define MT6360_PMU_CHG_IRQ1			(0xD0)
+#define MT6360_PMU_CHG_IRQ2			(0xD1)
+#define MT6360_PMU_CHG_IRQ3			(0xD2)
+#define MT6360_PMU_CHG_IRQ4			(0xD3)
+#define MT6360_PMU_CHG_IRQ5			(0xD4)
+#define MT6360_PMU_CHG_IRQ6			(0xD5)
+#define MT6360_PMU_QC_IRQ			(0xD6)
+#define MT6360_PMU_FOD_IRQ			(0xD7)
+#define MT6360_PMU_BASE_IRQ			(0xD8)
+#define MT6360_PMU_FLED_IRQ1			(0xD9)
+#define MT6360_PMU_FLED_IRQ2			(0xDA)
+#define MT6360_PMU_RGB_IRQ			(0xDB)
+#define MT6360_PMU_BUCK1_IRQ			(0xDC)
+#define MT6360_PMU_BUCK2_IRQ			(0xDD)
+#define MT6360_PMU_LDO_IRQ1			(0xDE)
+#define MT6360_PMU_LDO_IRQ2			(0xDF)
+#define MT6360_PMU_CHG_STAT1			(0xE0)
+#define MT6360_PMU_CHG_STAT2			(0xE1)
+#define MT6360_PMU_CHG_STAT3			(0xE2)
+#define MT6360_PMU_CHG_STAT4			(0xE3)
+#define MT6360_PMU_CHG_STAT5			(0xE4)
+#define MT6360_PMU_CHG_STAT6			(0xE5)
+#define MT6360_PMU_QC_STAT			(0xE6)
+#define MT6360_PMU_FOD_STAT			(0xE7)
+#define MT6360_PMU_BASE_STAT			(0xE8)
+#define MT6360_PMU_FLED_STAT1			(0xE9)
+#define MT6360_PMU_FLED_STAT2			(0xEA)
+#define MT6360_PMU_RGB_STAT			(0xEB)
+#define MT6360_PMU_BUCK1_STAT			(0xEC)
+#define MT6360_PMU_BUCK2_STAT			(0xED)
+#define MT6360_PMU_LDO_STAT1			(0xEE)
+#define MT6360_PMU_LDO_STAT2			(0xEF)
+#define MT6360_PMU_CHG_MASK1			(0xF0)
+#define MT6360_PMU_CHG_MASK2			(0xF1)
+#define MT6360_PMU_CHG_MASK3			(0xF2)
+#define MT6360_PMU_CHG_MASK4			(0xF3)
+#define MT6360_PMU_CHG_MASK5			(0xF4)
+#define MT6360_PMU_CHG_MASK6			(0xF5)
+#define MT6360_PMU_QC_MASK			(0xF6)
+#define MT6360_PMU_FOD_MASK			(0xF7)
+#define MT6360_PMU_BASE_MASK			(0xF8)
+#define MT6360_PMU_FLED_MASK1			(0xF9)
+#define MT6360_PMU_FLED_MASK2			(0xFA)
+#define MT6360_PMU_FAULTB_MASK			(0xFB)
+#define MT6360_PMU_BUCK1_MASK			(0xFC)
+#define MT6360_PMU_BUCK2_MASK			(0xFD)
+#define MT6360_PMU_LDO_MASK1			(0xFE)
+#define MT6360_PMU_LDO_MASK2			(0xFF)
+#define MT6360_PMU_MAXREG			(MT6360_PMU_LDO_MASK2)
+
+/* MT6360_PMU_IRQ_SET */
+#define MT6360_PMU_IRQ_REGNUM	(MT6360_PMU_LDO_IRQ2 - MT6360_PMU_CHG_IRQ1 + 1)
+#define MT6360_IRQ_RETRIG	BIT(2)
+
+#define CHIP_VEN_MASK				(0xF0)
+#define CHIP_VEN_MT6360				(0x50)
+#define CHIP_REV_MASK				(0x0F)
+
+#endif /* __MT6360_H__ */
-- 
2.23.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v7] mfd: mt6360: add pmic mt6360 driver
  2020-01-07 15:33 [PATCH v7] mfd: mt6360: add pmic mt6360 driver Gene Chen
@ 2020-01-09 18:51 ` kbuild test robot
  2020-01-10 10:48 ` kbuild test robot
  2020-01-15  7:10 ` Gene Chen
  2 siblings, 0 replies; 5+ messages in thread
From: kbuild test robot @ 2020-01-09 18:51 UTC (permalink / raw)
  To: Gene Chen
  Cc: gene_chen, kbuild-all, Wilma.Wu, linux-kernel, cy_huang,
	linux-mediatek, matthias.bgg, lee.jones, linux-arm-kernel,
	shufan_lee

[-- Attachment #1: Type: text/plain, Size: 5081 bytes --]

Hi Gene,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on ljones-mfd/for-mfd-next]
[also build test ERROR on v5.5-rc5 next-20200109]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Gene-Chen/mfd-mt6360-add-pmic-mt6360-driver/20200108-190516
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=c6x 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/mfd/mt6360-core.c: In function 'mt6360_pmu_probe':
>> drivers/mfd/mt6360-core.c:350:12: error: 'IRQF_TRIGGER_FALLING' undeclared (first use in this function); did you mean 'IRQD_TRIGGER_MASK'?
               IRQF_TRIGGER_FALLING, 0,
               ^~~~~~~~~~~~~~~~~~~~
               IRQD_TRIGGER_MASK
   drivers/mfd/mt6360-core.c:350:12: note: each undeclared identifier is reported only once for each function it appears in
   drivers/mfd/mt6360-core.c: In function 'mt6360_pmu_suspend':
>> drivers/mfd/mt6360-core.c:388:3: error: implicit declaration of function 'enable_irq_wake'; did you mean 'local_irq_save'? [-Werror=implicit-function-declaration]
      enable_irq_wake(i2c->irq);
      ^~~~~~~~~~~~~~~
      local_irq_save
   drivers/mfd/mt6360-core.c: In function 'mt6360_pmu_resume':
>> drivers/mfd/mt6360-core.c:399:3: error: implicit declaration of function 'disable_irq_wake'; did you mean 'local_irq_save'? [-Werror=implicit-function-declaration]
      disable_irq_wake(i2c->irq);
      ^~~~~~~~~~~~~~~~
      local_irq_save
   cc1: some warnings being treated as errors

vim +350 drivers/mfd/mt6360-core.c

   316	
   317	static int mt6360_pmu_probe(struct i2c_client *client)
   318	{
   319		struct mt6360_pmu_data *mpd;
   320		unsigned int reg_data;
   321		int i, ret;
   322	
   323		mpd = devm_kzalloc(&client->dev, sizeof(*mpd), GFP_KERNEL);
   324		if (!mpd)
   325			return -ENOMEM;
   326	
   327		mpd->dev = &client->dev;
   328		i2c_set_clientdata(client, mpd);
   329	
   330		mpd->regmap = devm_regmap_init_i2c(client, &mt6360_pmu_regmap_config);
   331		if (IS_ERR(mpd->regmap)) {
   332			dev_err(&client->dev, "Failed to register regmap\n");
   333			return PTR_ERR(mpd->regmap);
   334		}
   335	
   336		ret = regmap_read(mpd->regmap, MT6360_PMU_DEV_INFO, &reg_data);
   337		if (ret) {
   338			dev_err(&client->dev, "Device not found\n");
   339			return ret;
   340		}
   341	
   342		mpd->chip_rev = reg_data & CHIP_REV_MASK;
   343		if (mpd->chip_rev != CHIP_VEN_MT6360) {
   344			dev_err(&client->dev, "Device not supported\n");
   345			return -ENODEV;
   346		}
   347	
   348		mt6360_pmu_irq_chip.irq_drv_data = mpd;
   349		ret = devm_regmap_add_irq_chip(&client->dev, mpd->regmap, client->irq,
 > 350					       IRQF_TRIGGER_FALLING, 0,
   351					       &mt6360_pmu_irq_chip, &mpd->irq_data);
   352		if (ret) {
   353			dev_err(&client->dev, "Failed to add Regmap IRQ Chip\n");
   354			return ret;
   355		}
   356	
   357		mpd->i2c[0] = client;
   358		for (i = 1; i < MT6360_SLAVE_MAX; i++) {
   359			mpd->i2c[i] = devm_i2c_new_dummy_device(&client->dev,
   360								client->adapter,
   361								mt6360_slave_addr[i]);
   362			if (IS_ERR(mpd->i2c[i])) {
   363				dev_err(&client->dev,
   364					"Failed to get new dummy I2C device for address 0x%x",
   365					mt6360_slave_addr[i]);
   366				return PTR_ERR(mpd->i2c[i]);
   367			}
   368			i2c_set_clientdata(mpd->i2c[i], mpd);
   369		}
   370	
   371		ret = devm_mfd_add_devices(&client->dev, PLATFORM_DEVID_AUTO,
   372					   mt6360_devs, ARRAY_SIZE(mt6360_devs), NULL,
   373					   0, regmap_irq_get_domain(mpd->irq_data));
   374		if (ret) {
   375			dev_err(&client->dev,
   376				"Failed to register subordinate devices\n");
   377			return ret;
   378		}
   379	
   380		return 0;
   381	}
   382	
   383	static int __maybe_unused mt6360_pmu_suspend(struct device *dev)
   384	{
   385		struct i2c_client *i2c = to_i2c_client(dev);
   386	
   387		if (device_may_wakeup(dev))
 > 388			enable_irq_wake(i2c->irq);
   389	
   390		return 0;
   391	}
   392	
   393	static int __maybe_unused mt6360_pmu_resume(struct device *dev)
   394	{
   395	
   396		struct i2c_client *i2c = to_i2c_client(dev);
   397	
   398		if (device_may_wakeup(dev))
 > 399			disable_irq_wake(i2c->irq);
   400	
   401		return 0;
   402	}
   403	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50638 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v7] mfd: mt6360: add pmic mt6360 driver
  2020-01-07 15:33 [PATCH v7] mfd: mt6360: add pmic mt6360 driver Gene Chen
  2020-01-09 18:51 ` kbuild test robot
@ 2020-01-10 10:48 ` kbuild test robot
  2020-01-15  7:10 ` Gene Chen
  2 siblings, 0 replies; 5+ messages in thread
From: kbuild test robot @ 2020-01-10 10:48 UTC (permalink / raw)
  To: Gene Chen
  Cc: gene_chen, kbuild-all, Wilma.Wu, linux-kernel, cy_huang,
	linux-mediatek, matthias.bgg, lee.jones, linux-arm-kernel,
	shufan_lee

[-- Attachment #1: Type: text/plain, Size: 5067 bytes --]

Hi Gene,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on ljones-mfd/for-mfd-next]
[also build test ERROR on v5.5-rc5 next-20200109]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Gene-Chen/mfd-mt6360-add-pmic-mt6360-driver/20200108-190516
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: openrisc-randconfig-a001-20200110 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=openrisc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/mfd/mt6360-core.c: In function 'mt6360_pmu_probe':
   drivers/mfd/mt6360-core.c:350:12: error: 'IRQF_TRIGGER_FALLING' undeclared (first use in this function); did you mean 'IRQD_TRIGGER_MASK'?
     350 |            IRQF_TRIGGER_FALLING, 0,
         |            ^~~~~~~~~~~~~~~~~~~~
         |            IRQD_TRIGGER_MASK
   drivers/mfd/mt6360-core.c:350:12: note: each undeclared identifier is reported only once for each function it appears in
   drivers/mfd/mt6360-core.c: In function 'mt6360_pmu_suspend':
>> drivers/mfd/mt6360-core.c:388:3: error: implicit declaration of function 'enable_irq_wake' [-Werror=implicit-function-declaration]
     388 |   enable_irq_wake(i2c->irq);
         |   ^~~~~~~~~~~~~~~
   drivers/mfd/mt6360-core.c: In function 'mt6360_pmu_resume':
>> drivers/mfd/mt6360-core.c:399:3: error: implicit declaration of function 'disable_irq_wake' [-Werror=implicit-function-declaration]
     399 |   disable_irq_wake(i2c->irq);
         |   ^~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/enable_irq_wake +388 drivers/mfd/mt6360-core.c

   316	
   317	static int mt6360_pmu_probe(struct i2c_client *client)
   318	{
   319		struct mt6360_pmu_data *mpd;
   320		unsigned int reg_data;
   321		int i, ret;
   322	
   323		mpd = devm_kzalloc(&client->dev, sizeof(*mpd), GFP_KERNEL);
   324		if (!mpd)
   325			return -ENOMEM;
   326	
   327		mpd->dev = &client->dev;
   328		i2c_set_clientdata(client, mpd);
   329	
   330		mpd->regmap = devm_regmap_init_i2c(client, &mt6360_pmu_regmap_config);
   331		if (IS_ERR(mpd->regmap)) {
   332			dev_err(&client->dev, "Failed to register regmap\n");
   333			return PTR_ERR(mpd->regmap);
   334		}
   335	
   336		ret = regmap_read(mpd->regmap, MT6360_PMU_DEV_INFO, &reg_data);
   337		if (ret) {
   338			dev_err(&client->dev, "Device not found\n");
   339			return ret;
   340		}
   341	
   342		mpd->chip_rev = reg_data & CHIP_REV_MASK;
   343		if (mpd->chip_rev != CHIP_VEN_MT6360) {
   344			dev_err(&client->dev, "Device not supported\n");
   345			return -ENODEV;
   346		}
   347	
   348		mt6360_pmu_irq_chip.irq_drv_data = mpd;
   349		ret = devm_regmap_add_irq_chip(&client->dev, mpd->regmap, client->irq,
 > 350					       IRQF_TRIGGER_FALLING, 0,
   351					       &mt6360_pmu_irq_chip, &mpd->irq_data);
   352		if (ret) {
   353			dev_err(&client->dev, "Failed to add Regmap IRQ Chip\n");
   354			return ret;
   355		}
   356	
   357		mpd->i2c[0] = client;
   358		for (i = 1; i < MT6360_SLAVE_MAX; i++) {
   359			mpd->i2c[i] = devm_i2c_new_dummy_device(&client->dev,
   360								client->adapter,
   361								mt6360_slave_addr[i]);
   362			if (IS_ERR(mpd->i2c[i])) {
   363				dev_err(&client->dev,
   364					"Failed to get new dummy I2C device for address 0x%x",
   365					mt6360_slave_addr[i]);
   366				return PTR_ERR(mpd->i2c[i]);
   367			}
   368			i2c_set_clientdata(mpd->i2c[i], mpd);
   369		}
   370	
   371		ret = devm_mfd_add_devices(&client->dev, PLATFORM_DEVID_AUTO,
   372					   mt6360_devs, ARRAY_SIZE(mt6360_devs), NULL,
   373					   0, regmap_irq_get_domain(mpd->irq_data));
   374		if (ret) {
   375			dev_err(&client->dev,
   376				"Failed to register subordinate devices\n");
   377			return ret;
   378		}
   379	
   380		return 0;
   381	}
   382	
   383	static int __maybe_unused mt6360_pmu_suspend(struct device *dev)
   384	{
   385		struct i2c_client *i2c = to_i2c_client(dev);
   386	
   387		if (device_may_wakeup(dev))
 > 388			enable_irq_wake(i2c->irq);
   389	
   390		return 0;
   391	}
   392	
   393	static int __maybe_unused mt6360_pmu_resume(struct device *dev)
   394	{
   395	
   396		struct i2c_client *i2c = to_i2c_client(dev);
   397	
   398		if (device_may_wakeup(dev))
 > 399			disable_irq_wake(i2c->irq);
   400	
   401		return 0;
   402	}
   403	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25766 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v7] mfd: mt6360: add pmic mt6360 driver
  2020-01-07 15:33 [PATCH v7] mfd: mt6360: add pmic mt6360 driver Gene Chen
  2020-01-09 18:51 ` kbuild test robot
  2020-01-10 10:48 ` kbuild test robot
@ 2020-01-15  7:10 ` Gene Chen
  2020-01-15  7:55   ` Lee Jones
  2 siblings, 1 reply; 5+ messages in thread
From: Gene Chen @ 2020-01-15  7:10 UTC (permalink / raw)
  To: Lee Jones, matthias.bgg
  Cc: gene_chen, linux-kernel, cy_huang, linux-mediatek, Wilma.Wu,
	linux-arm-kernel, shufan_lee

Hi Lee/Matthias,

    Could you please help to review new fix change, thanks

Gene Chen <gene.chen.richtek@gmail.com> 於 2020年1月7日 週二 下午11:33寫道:
>
> From: Gene Chen <gene_chen@richtek.com>
>
> Add mfd driver for mt6360 pmic chip include
> Battery Charger/USB_PD/Flash LED/RGB LED/LDO/Buck
>
> Signed-off-by: Gene Chen <gene_chen@richtek.com
> ---
>  drivers/mfd/Kconfig        |  12 ++
>  drivers/mfd/Makefile       |   1 +
>  drivers/mfd/mt6360-core.c  | 424 +++++++++++++++++++++++++++++++++++++
>  include/linux/mfd/mt6360.h | 240 +++++++++++++++++++++
>  4 files changed, 677 insertions(+)
>  create mode 100644 drivers/mfd/mt6360-core.c
>  create mode 100644 include/linux/mfd/mt6360.h
>
> changelogs between v1 & v2
> - include missing header file
>
> changelogs between v2 & v3
> - add changelogs
>
> changelogs between v3 & v4
> - fix Kconfig description
> - replace mt6360_pmu_info with mt6360_pmu_data
> - replace probe with probe_new
> - remove unnecessary irq_chip variable
> - remove annotation
> - replace MT6360_MFD_CELL with OF_MFD_CELL
>
> changelogs between v4 & v5
> - remove unnecessary parse dt function
> - use devm_i2c_new_dummy_device
> - add base-commit message
>
> changelogs between v5 & v6
> - review return value
> - remove i2c id_table
> - use GPL license v2
>
> changelogs between v6 & v7
> - add author description
> - replace MT6360_REGMAP_IRQ_REG by REGMAP_IRQ_REG_LINE
> - remove mt6360-private.h
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 420900852166..e6df91d55405 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -856,6 +856,18 @@ config MFD_MAX8998
>           additional drivers must be enabled in order to use the functionality
>           of the device.
>
> +config MFD_MT6360
> +       tristate "Mediatek MT6360 SubPMIC"
> +       select MFD_CORE
> +       select REGMAP_I2C
> +       select REGMAP_IRQ
> +       depends on I2C
> +       help
> +         Say Y here to enable MT6360 PMU/PMIC/LDO functional support.
> +         PMU part includes Charger, Flashlight, RGB LED
> +         PMIC part includes 2-channel BUCKs and 2-channel LDOs
> +         LDO part includes 4-channel LDOs
> +
>  config MFD_MT6397
>         tristate "MediaTek MT6397 PMIC Support"
>         select MFD_CORE
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index aed99f08739f..f5f80d75ee53 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -237,6 +237,7 @@ obj-$(CONFIG_INTEL_SOC_PMIC)        += intel-soc-pmic.o
>  obj-$(CONFIG_INTEL_SOC_PMIC_BXTWC)     += intel_soc_pmic_bxtwc.o
>  obj-$(CONFIG_INTEL_SOC_PMIC_CHTWC)     += intel_soc_pmic_chtwc.o
>  obj-$(CONFIG_INTEL_SOC_PMIC_CHTDC_TI)  += intel_soc_pmic_chtdc_ti.o
> +obj-$(CONFIG_MFD_MT6360)       += mt6360-core.o
>  mt6397-objs    := mt6397-core.o mt6397-irq.o
>  obj-$(CONFIG_MFD_MT6397)       += mt6397.o
>  obj-$(CONFIG_INTEL_SOC_PMIC_MRFLD)     += intel_soc_pmic_mrfld.o
> diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c
> new file mode 100644
> index 000000000000..9a0a0584d3ba
> --- /dev/null
> +++ b/drivers/mfd/mt6360-core.c
> @@ -0,0 +1,424 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2019 MediaTek Inc.
> + *
> + * Author: Gene Chen <gene_chen@richtek.com>
> + */
> +
> +#include <linux/i2c.h>
> +#include <linux/init.h>
> +#include <linux/kernel.h>
> +#include <linux/mfd/core.h>
> +#include <linux/module.h>
> +#include <linux/of_irq.h>
> +#include <linux/of_platform.h>
> +#include <linux/version.h>
> +
> +#include <linux/mfd/mt6360.h>
> +
> +/* reg 0 -> 0 ~ 7 */
> +#define MT6360_CHG_TREG_EVT            (4)
> +#define MT6360_CHG_AICR_EVT            (5)
> +#define MT6360_CHG_MIVR_EVT            (6)
> +#define MT6360_PWR_RDY_EVT             (7)
> +/* REG 1 -> 8 ~ 15 */
> +#define MT6360_CHG_BATSYSUV_EVT                (9)
> +#define MT6360_FLED_CHG_VINOVP_EVT     (11)
> +#define MT6360_CHG_VSYSUV_EVT          (12)
> +#define MT6360_CHG_VSYSOV_EVT          (13)
> +#define MT6360_CHG_VBATOV_EVT          (14)
> +#define MT6360_CHG_VBUSOV_EVT          (15)
> +/* REG 2 -> 16 ~ 23 */
> +/* REG 3 -> 24 ~ 31 */
> +#define MT6360_WD_PMU_DET              (25)
> +#define MT6360_WD_PMU_DONE             (26)
> +#define MT6360_CHG_TMRI                        (27)
> +#define MT6360_CHG_ADPBADI             (29)
> +#define MT6360_CHG_RVPI                        (30)
> +#define MT6360_OTPI                    (31)
> +/* REG 4 -> 32 ~ 39 */
> +#define MT6360_CHG_AICCMEASL           (32)
> +#define MT6360_CHGDET_DONEI            (34)
> +#define MT6360_WDTMRI                  (35)
> +#define MT6360_SSFINISHI               (36)
> +#define MT6360_CHG_RECHGI              (37)
> +#define MT6360_CHG_TERMI               (38)
> +#define MT6360_CHG_IEOCI               (39)
> +/* REG 5 -> 40 ~ 47 */
> +#define MT6360_PUMPX_DONEI             (40)
> +#define MT6360_BAT_OVP_ADC_EVT         (41)
> +#define MT6360_TYPEC_OTP_EVT           (42)
> +#define MT6360_ADC_WAKEUP_EVT          (43)
> +#define MT6360_ADC_DONEI               (44)
> +#define MT6360_BST_BATUVI              (45)
> +#define MT6360_BST_VBUSOVI             (46)
> +#define MT6360_BST_OLPI                        (47)
> +/* REG 6 -> 48 ~ 55 */
> +#define MT6360_ATTACH_I                        (48)
> +#define MT6360_DETACH_I                        (49)
> +#define MT6360_QC30_STPDONE            (51)
> +#define MT6360_QC_VBUSDET_DONE         (52)
> +#define MT6360_HVDCP_DET               (53)
> +#define MT6360_CHGDETI                 (54)
> +#define MT6360_DCDTI                   (55)
> +/* REG 7 -> 56 ~ 63 */
> +#define MT6360_FOD_DONE_EVT            (56)
> +#define MT6360_FOD_OV_EVT              (57)
> +#define MT6360_CHRDET_UVP_EVT          (58)
> +#define MT6360_CHRDET_OVP_EVT          (59)
> +#define MT6360_CHRDET_EXT_EVT          (60)
> +#define MT6360_FOD_LR_EVT              (61)
> +#define MT6360_FOD_HR_EVT              (62)
> +#define MT6360_FOD_DISCHG_FAIL_EVT     (63)
> +/* REG 8 -> 64 ~ 71 */
> +#define MT6360_USBID_EVT               (64)
> +#define MT6360_APWDTRST_EVT            (65)
> +#define MT6360_EN_EVT                  (66)
> +#define MT6360_QONB_RST_EVT            (67)
> +#define MT6360_MRSTB_EVT               (68)
> +#define MT6360_OTP_EVT                 (69)
> +#define MT6360_VDDAOV_EVT              (70)
> +#define MT6360_SYSUV_EVT               (71)
> +/* REG 9 -> 72 ~ 79 */
> +#define MT6360_FLED_STRBPIN_EVT                (72)
> +#define MT6360_FLED_TORPIN_EVT         (73)
> +#define MT6360_FLED_TX_EVT             (74)
> +#define MT6360_FLED_LVF_EVT            (75)
> +#define MT6360_FLED2_SHORT_EVT         (78)
> +#define MT6360_FLED1_SHORT_EVT         (79)
> +/* REG 10 -> 80 ~ 87 */
> +#define MT6360_FLED2_STRB_EVT          (80)
> +#define MT6360_FLED1_STRB_EVT          (81)
> +#define MT6360_FLED2_STRB_TO_EVT       (82)
> +#define MT6360_FLED1_STRB_TO_EVT       (83)
> +#define MT6360_FLED2_TOR_EVT           (84)
> +#define MT6360_FLED1_TOR_EVT           (85)
> +/* REG 11 -> 88 ~ 95 */
> +/* REG 12 -> 96 ~ 103 */
> +#define MT6360_BUCK1_PGB_EVT           (96)
> +#define MT6360_BUCK1_OC_EVT            (100)
> +#define MT6360_BUCK1_OV_EVT            (101)
> +#define MT6360_BUCK1_UV_EVT            (102)
> +/* REG 13 -> 104 ~ 111 */
> +#define MT6360_BUCK2_PGB_EVT           (104)
> +#define MT6360_BUCK2_OC_EVT            (108)
> +#define MT6360_BUCK2_OV_EVT            (109)
> +#define MT6360_BUCK2_UV_EVT            (110)
> +/* REG 14 -> 112 ~ 119 */
> +#define MT6360_LDO1_OC_EVT             (113)
> +#define MT6360_LDO2_OC_EVT             (114)
> +#define MT6360_LDO3_OC_EVT             (115)
> +#define MT6360_LDO5_OC_EVT             (117)
> +#define MT6360_LDO6_OC_EVT             (118)
> +#define MT6360_LDO7_OC_EVT             (119)
> +/* REG 15 -> 120 ~ 127 */
> +#define MT6360_LDO1_PGB_EVT            (121)
> +#define MT6360_LDO2_PGB_EVT            (122)
> +#define MT6360_LDO3_PGB_EVT            (123)
> +#define MT6360_LDO5_PGB_EVT            (125)
> +#define MT6360_LDO6_PGB_EVT            (126)
> +#define MT6360_LDO7_PGB_EVT            (127)
> +
> +static const struct regmap_irq mt6360_pmu_irqs[] =  {
> +       REGMAP_IRQ_REG_LINE(MT6360_CHG_TREG_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHG_AICR_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHG_MIVR_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_PWR_RDY_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHG_BATSYSUV_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_FLED_CHG_VINOVP_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHG_VSYSUV_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHG_VSYSOV_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHG_VBATOV_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHG_VBUSOV_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_WD_PMU_DET, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_WD_PMU_DONE, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHG_TMRI, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHG_ADPBADI, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHG_RVPI, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_OTPI, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHG_AICCMEASL, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHGDET_DONEI, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_WDTMRI, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_SSFINISHI, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHG_RECHGI, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHG_TERMI, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHG_IEOCI, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_PUMPX_DONEI, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHG_TREG_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_BAT_OVP_ADC_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_TYPEC_OTP_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_ADC_WAKEUP_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_ADC_DONEI, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_BST_BATUVI, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_BST_VBUSOVI, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_BST_OLPI, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_ATTACH_I, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_DETACH_I, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_QC30_STPDONE, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_QC_VBUSDET_DONE, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_HVDCP_DET, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHGDETI, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_DCDTI, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_FOD_DONE_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_FOD_OV_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHRDET_UVP_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHRDET_OVP_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_CHRDET_EXT_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_FOD_LR_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_FOD_HR_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_FOD_DISCHG_FAIL_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_USBID_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_APWDTRST_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_EN_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_QONB_RST_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_MRSTB_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_OTP_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_VDDAOV_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_SYSUV_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_FLED_STRBPIN_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_FLED_TORPIN_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_FLED_TX_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_FLED_LVF_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_FLED2_SHORT_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_FLED1_SHORT_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_FLED2_STRB_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_FLED1_STRB_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_FLED2_STRB_TO_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_FLED1_STRB_TO_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_FLED2_TOR_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_FLED1_TOR_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_BUCK1_PGB_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_BUCK1_OC_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_BUCK1_OV_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_BUCK1_UV_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_BUCK2_PGB_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_BUCK2_OC_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_BUCK2_OV_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_BUCK2_UV_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_LDO1_OC_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_LDO2_OC_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_LDO3_OC_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_LDO5_OC_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_LDO6_OC_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_LDO7_OC_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_LDO1_PGB_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_LDO2_PGB_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_LDO3_PGB_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_LDO5_PGB_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_LDO6_PGB_EVT, 8),
> +       REGMAP_IRQ_REG_LINE(MT6360_LDO7_PGB_EVT, 8),
> +};
> +
> +static int mt6360_pmu_handle_post_irq(void *irq_drv_data)
> +{
> +       struct mt6360_pmu_data *mpd = irq_drv_data;
> +
> +       return regmap_update_bits(mpd->regmap,
> +               MT6360_PMU_IRQ_SET, MT6360_IRQ_RETRIG, MT6360_IRQ_RETRIG);
> +}
> +
> +static struct regmap_irq_chip mt6360_pmu_irq_chip = {
> +       .irqs = mt6360_pmu_irqs,
> +       .num_irqs = ARRAY_SIZE(mt6360_pmu_irqs),
> +       .num_regs = MT6360_PMU_IRQ_REGNUM,
> +       .mask_base = MT6360_PMU_CHG_MASK1,
> +       .status_base = MT6360_PMU_CHG_IRQ1,
> +       .ack_base = MT6360_PMU_CHG_IRQ1,
> +       .init_ack_masked = true,
> +       .use_ack = true,
> +       .handle_post_irq = mt6360_pmu_handle_post_irq,
> +};
> +
> +static const struct regmap_config mt6360_pmu_regmap_config = {
> +       .reg_bits = 8,
> +       .val_bits = 8,
> +       .max_register = MT6360_PMU_MAXREG,
> +};
> +
> +static const struct resource mt6360_adc_resources[] = {
> +       DEFINE_RES_IRQ_NAMED(MT6360_ADC_DONEI, "adc_donei"),
> +};
> +
> +static const struct resource mt6360_chg_resources[] = {
> +       DEFINE_RES_IRQ_NAMED(MT6360_CHG_TREG_EVT, "chg_treg_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_PWR_RDY_EVT, "pwr_rdy_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_CHG_BATSYSUV_EVT, "chg_batsysuv_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_CHG_VSYSUV_EVT, "chg_vsysuv_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_CHG_VSYSOV_EVT, "chg_vsysov_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_CHG_VBATOV_EVT, "chg_vbatov_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_CHG_VBUSOV_EVT, "chg_vbusov_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_CHG_AICCMEASL, "chg_aiccmeasl"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_WDTMRI, "wdtmri"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_CHG_RECHGI, "chg_rechgi"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_CHG_TERMI, "chg_termi"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_CHG_IEOCI, "chg_ieoci"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_PUMPX_DONEI, "pumpx_donei"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_ATTACH_I, "attach_i"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_CHRDET_EXT_EVT, "chrdet_ext_evt"),
> +};
> +
> +static const struct resource mt6360_led_resources[] = {
> +       DEFINE_RES_IRQ_NAMED(MT6360_FLED_CHG_VINOVP_EVT, "fled_chg_vinovp_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_FLED_LVF_EVT, "fled_lvf_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_FLED2_SHORT_EVT, "fled2_short_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_FLED1_SHORT_EVT, "fled1_short_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_FLED2_STRB_TO_EVT, "fled2_strb_to_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_FLED1_STRB_TO_EVT, "fled1_strb_to_evt"),
> +};
> +
> +static const struct resource mt6360_pmic_resources[] = {
> +       DEFINE_RES_IRQ_NAMED(MT6360_BUCK1_PGB_EVT, "buck1_pgb_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_BUCK1_OC_EVT, "buck1_oc_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_BUCK1_OV_EVT, "buck1_ov_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_BUCK1_UV_EVT, "buck1_uv_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_BUCK2_PGB_EVT, "buck2_pgb_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_BUCK2_OC_EVT, "buck2_oc_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_BUCK2_OV_EVT, "buck2_ov_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_BUCK2_UV_EVT, "buck2_uv_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_LDO6_OC_EVT, "ldo6_oc_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_LDO7_OC_EVT, "ldo7_oc_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_LDO6_PGB_EVT, "ldo6_pgb_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_LDO7_PGB_EVT, "ldo7_pgb_evt"),
> +};
> +
> +static const struct resource mt6360_ldo_resources[] = {
> +       DEFINE_RES_IRQ_NAMED(MT6360_LDO1_OC_EVT, "ldo1_oc_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_LDO2_OC_EVT, "ldo2_oc_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_LDO3_OC_EVT, "ldo3_oc_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_LDO5_OC_EVT, "ldo5_oc_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_LDO1_PGB_EVT, "ldo1_pgb_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_LDO2_PGB_EVT, "ldo2_pgb_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_LDO3_PGB_EVT, "ldo3_pgb_evt"),
> +       DEFINE_RES_IRQ_NAMED(MT6360_LDO5_PGB_EVT, "ldo5_pgb_evt"),
> +};
> +
> +static const struct mfd_cell mt6360_devs[] = {
> +       OF_MFD_CELL("mt6360_adc", mt6360_adc_resources,
> +                   NULL, 0, 0, "mediatek,mt6360_adc"),
> +       OF_MFD_CELL("mt6360_chg", mt6360_chg_resources,
> +                   NULL, 0, 0, "mediatek,mt6360_chg"),
> +       OF_MFD_CELL("mt6360_led", mt6360_led_resources,
> +                   NULL, 0, 0, "mediatek,mt6360_led"),
> +       OF_MFD_CELL("mt6360_pmic", mt6360_pmic_resources,
> +                   NULL, 0, 0, "mediatek,mt6360_pmic"),
> +       OF_MFD_CELL("mt6360_ldo", mt6360_ldo_resources,
> +                   NULL, 0, 0, "mediatek,mt6360_ldo"),
> +       OF_MFD_CELL("mt6360_tcpc", NULL,
> +                   NULL, 0, 0, "mediatek,mt6360_tcpc"),
> +};
> +
> +static const unsigned short mt6360_slave_addr[MT6360_SLAVE_MAX] = {
> +       MT6360_PMU_SLAVEID,
> +       MT6360_PMIC_SLAVEID,
> +       MT6360_LDO_SLAVEID,
> +       MT6360_TCPC_SLAVEID,
> +};
> +
> +static int mt6360_pmu_probe(struct i2c_client *client)
> +{
> +       struct mt6360_pmu_data *mpd;
> +       unsigned int reg_data;
> +       int i, ret;
> +
> +       mpd = devm_kzalloc(&client->dev, sizeof(*mpd), GFP_KERNEL);
> +       if (!mpd)
> +               return -ENOMEM;
> +
> +       mpd->dev = &client->dev;
> +       i2c_set_clientdata(client, mpd);
> +
> +       mpd->regmap = devm_regmap_init_i2c(client, &mt6360_pmu_regmap_config);
> +       if (IS_ERR(mpd->regmap)) {
> +               dev_err(&client->dev, "Failed to register regmap\n");
> +               return PTR_ERR(mpd->regmap);
> +       }
> +
> +       ret = regmap_read(mpd->regmap, MT6360_PMU_DEV_INFO, &reg_data);
> +       if (ret) {
> +               dev_err(&client->dev, "Device not found\n");
> +               return ret;
> +       }
> +
> +       mpd->chip_rev = reg_data & CHIP_REV_MASK;
> +       if (mpd->chip_rev != CHIP_VEN_MT6360) {
> +               dev_err(&client->dev, "Device not supported\n");
> +               return -ENODEV;
> +       }
> +
> +       mt6360_pmu_irq_chip.irq_drv_data = mpd;
> +       ret = devm_regmap_add_irq_chip(&client->dev, mpd->regmap, client->irq,
> +                                      IRQF_TRIGGER_FALLING, 0,
> +                                      &mt6360_pmu_irq_chip, &mpd->irq_data);
> +       if (ret) {
> +               dev_err(&client->dev, "Failed to add Regmap IRQ Chip\n");
> +               return ret;
> +       }
> +
> +       mpd->i2c[0] = client;
> +       for (i = 1; i < MT6360_SLAVE_MAX; i++) {
> +               mpd->i2c[i] = devm_i2c_new_dummy_device(&client->dev,
> +                                                       client->adapter,
> +                                                       mt6360_slave_addr[i]);
> +               if (IS_ERR(mpd->i2c[i])) {
> +                       dev_err(&client->dev,
> +                               "Failed to get new dummy I2C device for address 0x%x",
> +                               mt6360_slave_addr[i]);
> +                       return PTR_ERR(mpd->i2c[i]);
> +               }
> +               i2c_set_clientdata(mpd->i2c[i], mpd);
> +       }
> +
> +       ret = devm_mfd_add_devices(&client->dev, PLATFORM_DEVID_AUTO,
> +                                  mt6360_devs, ARRAY_SIZE(mt6360_devs), NULL,
> +                                  0, regmap_irq_get_domain(mpd->irq_data));
> +       if (ret) {
> +               dev_err(&client->dev,
> +                       "Failed to register subordinate devices\n");
> +               return ret;
> +       }
> +
> +       return 0;
> +}
> +
> +static int __maybe_unused mt6360_pmu_suspend(struct device *dev)
> +{
> +       struct i2c_client *i2c = to_i2c_client(dev);
> +
> +       if (device_may_wakeup(dev))
> +               enable_irq_wake(i2c->irq);
> +
> +       return 0;
> +}
> +
> +static int __maybe_unused mt6360_pmu_resume(struct device *dev)
> +{
> +
> +       struct i2c_client *i2c = to_i2c_client(dev);
> +
> +       if (device_may_wakeup(dev))
> +               disable_irq_wake(i2c->irq);
> +
> +       return 0;
> +}
> +
> +static SIMPLE_DEV_PM_OPS(mt6360_pmu_pm_ops,
> +                        mt6360_pmu_suspend, mt6360_pmu_resume);
> +
> +static const struct of_device_id __maybe_unused mt6360_pmu_of_id[] = {
> +       { .compatible = "mediatek,mt6360_pmu", },
> +       {},
> +};
> +MODULE_DEVICE_TABLE(of, mt6360_pmu_of_id);
> +
> +static struct i2c_driver mt6360_pmu_driver = {
> +       .driver = {
> +               .pm = &mt6360_pmu_pm_ops,
> +               .of_match_table = of_match_ptr(mt6360_pmu_of_id),
> +       },
> +       .probe_new = mt6360_pmu_probe,
> +};
> +module_i2c_driver(mt6360_pmu_driver);
> +
> +MODULE_AUTHOR("Gene Chen <gene_chen@richtek.com>");
> +MODULE_DESCRIPTION("MT6360 PMU I2C Driver");
> +MODULE_LICENSE("GPL v2");
> diff --git a/include/linux/mfd/mt6360.h b/include/linux/mfd/mt6360.h
> new file mode 100644
> index 000000000000..c03e6d1d9a02
> --- /dev/null
> +++ b/include/linux/mfd/mt6360.h
> @@ -0,0 +1,240 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2019 MediaTek Inc.
> + */
> +
> +#ifndef __MT6360_H__
> +#define __MT6360_H__
> +
> +#include <linux/regmap.h>
> +
> +enum {
> +       MT6360_SLAVE_PMU = 0,
> +       MT6360_SLAVE_PMIC,
> +       MT6360_SLAVE_LDO,
> +       MT6360_SLAVE_TCPC,
> +       MT6360_SLAVE_MAX,
> +};
> +
> +#define MT6360_PMU_SLAVEID     (0x34)
> +#define MT6360_PMIC_SLAVEID    (0x1A)
> +#define MT6360_LDO_SLAVEID     (0x64)
> +#define MT6360_TCPC_SLAVEID    (0x4E)
> +
> +struct mt6360_pmu_data {
> +       struct i2c_client *i2c[MT6360_SLAVE_MAX];
> +       struct device *dev;
> +       struct regmap *regmap;
> +       struct regmap_irq_chip_data *irq_data;
> +       unsigned int chip_rev;
> +};
> +
> +/* PMU register defininition */
> +#define MT6360_PMU_DEV_INFO                    (0x00)
> +#define MT6360_PMU_CORE_CTRL1                  (0x01)
> +#define MT6360_PMU_RST1                                (0x02)
> +#define MT6360_PMU_CRCEN                       (0x03)
> +#define MT6360_PMU_RST_PAS_CODE1               (0x04)
> +#define MT6360_PMU_RST_PAS_CODE2               (0x05)
> +#define MT6360_PMU_CORE_CTRL2                  (0x06)
> +#define MT6360_PMU_TM_PAS_CODE1                        (0x07)
> +#define MT6360_PMU_TM_PAS_CODE2                        (0x08)
> +#define MT6360_PMU_TM_PAS_CODE3                        (0x09)
> +#define MT6360_PMU_TM_PAS_CODE4                        (0x0A)
> +#define MT6360_PMU_IRQ_IND                     (0x0B)
> +#define MT6360_PMU_IRQ_MASK                    (0x0C)
> +#define MT6360_PMU_IRQ_SET                     (0x0D)
> +#define MT6360_PMU_SHDN_CTRL                   (0x0E)
> +#define MT6360_PMU_TM_INF                      (0x0F)
> +#define MT6360_PMU_I2C_CTRL                    (0x10)
> +#define MT6360_PMU_CHG_CTRL1                   (0x11)
> +#define MT6360_PMU_CHG_CTRL2                   (0x12)
> +#define MT6360_PMU_CHG_CTRL3                   (0x13)
> +#define MT6360_PMU_CHG_CTRL4                   (0x14)
> +#define MT6360_PMU_CHG_CTRL5                   (0x15)
> +#define MT6360_PMU_CHG_CTRL6                   (0x16)
> +#define MT6360_PMU_CHG_CTRL7                   (0x17)
> +#define MT6360_PMU_CHG_CTRL8                   (0x18)
> +#define MT6360_PMU_CHG_CTRL9                   (0x19)
> +#define MT6360_PMU_CHG_CTRL10                  (0x1A)
> +#define MT6360_PMU_CHG_CTRL11                  (0x1B)
> +#define MT6360_PMU_CHG_CTRL12                  (0x1C)
> +#define MT6360_PMU_CHG_CTRL13                  (0x1D)
> +#define MT6360_PMU_CHG_CTRL14                  (0x1E)
> +#define MT6360_PMU_CHG_CTRL15                  (0x1F)
> +#define MT6360_PMU_CHG_CTRL16                  (0x20)
> +#define MT6360_PMU_CHG_AICC_RESULT             (0x21)
> +#define MT6360_PMU_DEVICE_TYPE                 (0x22)
> +#define MT6360_PMU_QC_CONTROL1                 (0x23)
> +#define MT6360_PMU_QC_CONTROL2                 (0x24)
> +#define MT6360_PMU_QC30_CONTROL1               (0x25)
> +#define MT6360_PMU_QC30_CONTROL2               (0x26)
> +#define MT6360_PMU_USB_STATUS1                 (0x27)
> +#define MT6360_PMU_QC_STATUS1                  (0x28)
> +#define MT6360_PMU_QC_STATUS2                  (0x29)
> +#define MT6360_PMU_CHG_PUMP                    (0x2A)
> +#define MT6360_PMU_CHG_CTRL17                  (0x2B)
> +#define MT6360_PMU_CHG_CTRL18                  (0x2C)
> +#define MT6360_PMU_CHRDET_CTRL1                        (0x2D)
> +#define MT6360_PMU_CHRDET_CTRL2                        (0x2E)
> +#define MT6360_PMU_DPDN_CTRL                   (0x2F)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL1            (0x30)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL2            (0x31)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL3            (0x32)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL4            (0x33)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL5            (0x34)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL6            (0x35)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL7            (0x36)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL8            (0x37)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL9            (0x38)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL10           (0x39)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL11           (0x3A)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL12           (0x3B)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL13           (0x3C)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL14           (0x3D)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL15           (0x3E)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL16           (0x3F)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL17           (0x40)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL18           (0x41)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL19           (0x42)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL20           (0x43)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL21           (0x44)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL22           (0x45)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL23           (0x46)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL24           (0x47)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL25           (0x48)
> +#define MT6360_PMU_BC12_CTRL                   (0x49)
> +#define MT6360_PMU_CHG_STAT                    (0x4A)
> +#define MT6360_PMU_RESV1                       (0x4B)
> +#define MT6360_PMU_TYPEC_OTP_TH_SEL_CODEH      (0x4E)
> +#define MT6360_PMU_TYPEC_OTP_TH_SEL_CODEL      (0x4F)
> +#define MT6360_PMU_TYPEC_OTP_HYST_TH           (0x50)
> +#define MT6360_PMU_TYPEC_OTP_CTRL              (0x51)
> +#define MT6360_PMU_ADC_BAT_DATA_H              (0x52)
> +#define MT6360_PMU_ADC_BAT_DATA_L              (0x53)
> +#define MT6360_PMU_IMID_BACKBST_ON             (0x54)
> +#define MT6360_PMU_IMID_BACKBST_OFF            (0x55)
> +#define MT6360_PMU_ADC_CONFIG                  (0x56)
> +#define MT6360_PMU_ADC_EN2                     (0x57)
> +#define MT6360_PMU_ADC_IDLE_T                  (0x58)
> +#define MT6360_PMU_ADC_RPT_1                   (0x5A)
> +#define MT6360_PMU_ADC_RPT_2                   (0x5B)
> +#define MT6360_PMU_ADC_RPT_3                   (0x5C)
> +#define MT6360_PMU_ADC_RPT_ORG1                        (0x5D)
> +#define MT6360_PMU_ADC_RPT_ORG2                        (0x5E)
> +#define MT6360_PMU_BAT_OVP_TH_SEL_CODEH                (0x5F)
> +#define MT6360_PMU_BAT_OVP_TH_SEL_CODEL                (0x60)
> +#define MT6360_PMU_CHG_CTRL19                  (0x61)
> +#define MT6360_PMU_VDDASUPPLY                  (0x62)
> +#define MT6360_PMU_BC12_MANUAL                 (0x63)
> +#define MT6360_PMU_CHGDET_FUNC                 (0x64)
> +#define MT6360_PMU_FOD_CTRL                    (0x65)
> +#define MT6360_PMU_CHG_CTRL20                  (0x66)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL26           (0x67)
> +#define MT6360_PMU_CHG_HIDDEN_CTRL27           (0x68)
> +#define MT6360_PMU_RESV2                       (0x69)
> +#define MT6360_PMU_USBID_CTRL1                 (0x6D)
> +#define MT6360_PMU_USBID_CTRL2                 (0x6E)
> +#define MT6360_PMU_USBID_CTRL3                 (0x6F)
> +#define MT6360_PMU_FLED_CFG                    (0x70)
> +#define MT6360_PMU_RESV3                       (0x71)
> +#define MT6360_PMU_FLED1_CTRL                  (0x72)
> +#define MT6360_PMU_FLED_STRB_CTRL              (0x73)
> +#define MT6360_PMU_FLED1_STRB_CTRL2            (0x74)
> +#define MT6360_PMU_FLED1_TOR_CTRL              (0x75)
> +#define MT6360_PMU_FLED2_CTRL                  (0x76)
> +#define MT6360_PMU_RESV4                       (0x77)
> +#define MT6360_PMU_FLED2_STRB_CTRL2            (0x78)
> +#define MT6360_PMU_FLED2_TOR_CTRL              (0x79)
> +#define MT6360_PMU_FLED_VMIDTRK_CTRL1          (0x7A)
> +#define MT6360_PMU_FLED_VMID_RTM               (0x7B)
> +#define MT6360_PMU_FLED_VMIDTRK_CTRL2          (0x7C)
> +#define MT6360_PMU_FLED_PWSEL                  (0x7D)
> +#define MT6360_PMU_FLED_EN                     (0x7E)
> +#define MT6360_PMU_FLED_Hidden1                        (0x7F)
> +#define MT6360_PMU_RGB_EN                      (0x80)
> +#define MT6360_PMU_RGB1_ISNK                   (0x81)
> +#define MT6360_PMU_RGB2_ISNK                   (0x82)
> +#define MT6360_PMU_RGB3_ISNK                   (0x83)
> +#define MT6360_PMU_RGB_ML_ISNK                 (0x84)
> +#define MT6360_PMU_RGB1_DIM                    (0x85)
> +#define MT6360_PMU_RGB2_DIM                    (0x86)
> +#define MT6360_PMU_RGB3_DIM                    (0x87)
> +#define MT6360_PMU_RESV5                       (0x88)
> +#define MT6360_PMU_RGB12_Freq                  (0x89)
> +#define MT6360_PMU_RGB34_Freq                  (0x8A)
> +#define MT6360_PMU_RGB1_Tr                     (0x8B)
> +#define MT6360_PMU_RGB1_Tf                     (0x8C)
> +#define MT6360_PMU_RGB1_TON_TOFF               (0x8D)
> +#define MT6360_PMU_RGB2_Tr                     (0x8E)
> +#define MT6360_PMU_RGB2_Tf                     (0x8F)
> +#define MT6360_PMU_RGB2_TON_TOFF               (0x90)
> +#define MT6360_PMU_RGB3_Tr                     (0x91)
> +#define MT6360_PMU_RGB3_Tf                     (0x92)
> +#define MT6360_PMU_RGB3_TON_TOFF               (0x93)
> +#define MT6360_PMU_RGB_Hidden_CTRL1            (0x94)
> +#define MT6360_PMU_RGB_Hidden_CTRL2            (0x95)
> +#define MT6360_PMU_RESV6                       (0x97)
> +#define MT6360_PMU_SPARE1                      (0x9A)
> +#define MT6360_PMU_SPARE2                      (0xA0)
> +#define MT6360_PMU_SPARE3                      (0xB0)
> +#define MT6360_PMU_SPARE4                      (0xC0)
> +#define MT6360_PMU_CHG_IRQ1                    (0xD0)
> +#define MT6360_PMU_CHG_IRQ2                    (0xD1)
> +#define MT6360_PMU_CHG_IRQ3                    (0xD2)
> +#define MT6360_PMU_CHG_IRQ4                    (0xD3)
> +#define MT6360_PMU_CHG_IRQ5                    (0xD4)
> +#define MT6360_PMU_CHG_IRQ6                    (0xD5)
> +#define MT6360_PMU_QC_IRQ                      (0xD6)
> +#define MT6360_PMU_FOD_IRQ                     (0xD7)
> +#define MT6360_PMU_BASE_IRQ                    (0xD8)
> +#define MT6360_PMU_FLED_IRQ1                   (0xD9)
> +#define MT6360_PMU_FLED_IRQ2                   (0xDA)
> +#define MT6360_PMU_RGB_IRQ                     (0xDB)
> +#define MT6360_PMU_BUCK1_IRQ                   (0xDC)
> +#define MT6360_PMU_BUCK2_IRQ                   (0xDD)
> +#define MT6360_PMU_LDO_IRQ1                    (0xDE)
> +#define MT6360_PMU_LDO_IRQ2                    (0xDF)
> +#define MT6360_PMU_CHG_STAT1                   (0xE0)
> +#define MT6360_PMU_CHG_STAT2                   (0xE1)
> +#define MT6360_PMU_CHG_STAT3                   (0xE2)
> +#define MT6360_PMU_CHG_STAT4                   (0xE3)
> +#define MT6360_PMU_CHG_STAT5                   (0xE4)
> +#define MT6360_PMU_CHG_STAT6                   (0xE5)
> +#define MT6360_PMU_QC_STAT                     (0xE6)
> +#define MT6360_PMU_FOD_STAT                    (0xE7)
> +#define MT6360_PMU_BASE_STAT                   (0xE8)
> +#define MT6360_PMU_FLED_STAT1                  (0xE9)
> +#define MT6360_PMU_FLED_STAT2                  (0xEA)
> +#define MT6360_PMU_RGB_STAT                    (0xEB)
> +#define MT6360_PMU_BUCK1_STAT                  (0xEC)
> +#define MT6360_PMU_BUCK2_STAT                  (0xED)
> +#define MT6360_PMU_LDO_STAT1                   (0xEE)
> +#define MT6360_PMU_LDO_STAT2                   (0xEF)
> +#define MT6360_PMU_CHG_MASK1                   (0xF0)
> +#define MT6360_PMU_CHG_MASK2                   (0xF1)
> +#define MT6360_PMU_CHG_MASK3                   (0xF2)
> +#define MT6360_PMU_CHG_MASK4                   (0xF3)
> +#define MT6360_PMU_CHG_MASK5                   (0xF4)
> +#define MT6360_PMU_CHG_MASK6                   (0xF5)
> +#define MT6360_PMU_QC_MASK                     (0xF6)
> +#define MT6360_PMU_FOD_MASK                    (0xF7)
> +#define MT6360_PMU_BASE_MASK                   (0xF8)
> +#define MT6360_PMU_FLED_MASK1                  (0xF9)
> +#define MT6360_PMU_FLED_MASK2                  (0xFA)
> +#define MT6360_PMU_FAULTB_MASK                 (0xFB)
> +#define MT6360_PMU_BUCK1_MASK                  (0xFC)
> +#define MT6360_PMU_BUCK2_MASK                  (0xFD)
> +#define MT6360_PMU_LDO_MASK1                   (0xFE)
> +#define MT6360_PMU_LDO_MASK2                   (0xFF)
> +#define MT6360_PMU_MAXREG                      (MT6360_PMU_LDO_MASK2)
> +
> +/* MT6360_PMU_IRQ_SET */
> +#define MT6360_PMU_IRQ_REGNUM  (MT6360_PMU_LDO_IRQ2 - MT6360_PMU_CHG_IRQ1 + 1)
> +#define MT6360_IRQ_RETRIG      BIT(2)
> +
> +#define CHIP_VEN_MASK                          (0xF0)
> +#define CHIP_VEN_MT6360                                (0x50)
> +#define CHIP_REV_MASK                          (0x0F)
> +
> +#endif /* __MT6360_H__ */
> --
> 2.23.0
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v7] mfd: mt6360: add pmic mt6360 driver
  2020-01-15  7:10 ` Gene Chen
@ 2020-01-15  7:55   ` Lee Jones
  0 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2020-01-15  7:55 UTC (permalink / raw)
  To: Gene Chen
  Cc: gene_chen, linux-kernel, cy_huang, linux-mediatek, matthias.bgg,
	Wilma.Wu, linux-arm-kernel, shufan_lee

On Wed, 15 Jan 2020, Gene Chen wrote:

> Hi Lee/Matthias,
> 
>     Could you please help to review new fix change, thanks

a) If you think a submission has been accidentally dropped, you should
   resubmit it as a "RESEND".  Please do not send contentless pings.

b) It looks like you have complains from the 'build test robot'.  You
   need to address them first, before review.  Or at least justify
   them.

> Gene Chen <gene.chen.richtek@gmail.com> 於 2020年1月7日 週二 下午11:33寫道:
> >
> > From: Gene Chen <gene_chen@richtek.com>
> >
> > Add mfd driver for mt6360 pmic chip include
> > Battery Charger/USB_PD/Flash LED/RGB LED/LDO/Buck
> >
> > Signed-off-by: Gene Chen <gene_chen@richtek.com
> > ---
> >  drivers/mfd/Kconfig        |  12 ++
> >  drivers/mfd/Makefile       |   1 +
> >  drivers/mfd/mt6360-core.c  | 424 +++++++++++++++++++++++++++++++++++++
> >  include/linux/mfd/mt6360.h | 240 +++++++++++++++++++++
> >  4 files changed, 677 insertions(+)
> >  create mode 100644 drivers/mfd/mt6360-core.c
> >  create mode 100644 include/linux/mfd/mt6360.h

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-07 15:33 [PATCH v7] mfd: mt6360: add pmic mt6360 driver Gene Chen
2020-01-09 18:51 ` kbuild test robot
2020-01-10 10:48 ` kbuild test robot
2020-01-15  7:10 ` Gene Chen
2020-01-15  7:55   ` Lee Jones

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git