* [PATCH v2] drivers/firmware/psci: Fix memory leakage in alloc_init_cpu_groups()
@ 2020-01-30 21:51 Gavin Shan
2020-01-31 15:30 ` Sudeep Holla
0 siblings, 1 reply; 2+ messages in thread
From: Gavin Shan @ 2020-01-30 21:51 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: mark.rutland, lorenzo.pieralisi, sudeep.holla
The CPU mask (@tmp) should be free'd on failing to allocate @cpu_groups
or any of its elements. Otherwise, it leads to memory leakage because the
CPU mask variable is dynamically allocated with CONFIG_CPUMASK_OFFSTACK.
Signed-off-by: Gavin Shan <gshan@redhat.com>
---
v2: Free @tmp on failing to allocate @cpu_groups
---
drivers/firmware/psci/psci_checker.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/psci/psci_checker.c b/drivers/firmware/psci/psci_checker.c
index 6a445397771c..03eb798ad3ed 100644
--- a/drivers/firmware/psci/psci_checker.c
+++ b/drivers/firmware/psci/psci_checker.c
@@ -157,8 +157,10 @@ static int alloc_init_cpu_groups(cpumask_var_t **pcpu_groups)
cpu_groups = kcalloc(nb_available_cpus, sizeof(cpu_groups),
GFP_KERNEL);
- if (!cpu_groups)
+ if (!cpu_groups) {
+ free_cpumask_var(tmp);
return -ENOMEM;
+ }
cpumask_copy(tmp, cpu_online_mask);
@@ -167,6 +169,7 @@ static int alloc_init_cpu_groups(cpumask_var_t **pcpu_groups)
topology_core_cpumask(cpumask_any(tmp));
if (!alloc_cpumask_var(&cpu_groups[num_groups], GFP_KERNEL)) {
+ free_cpumask_var(tmp);
free_cpu_groups(num_groups, &cpu_groups);
return -ENOMEM;
}
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] drivers/firmware/psci: Fix memory leakage in alloc_init_cpu_groups()
2020-01-30 21:51 [PATCH v2] drivers/firmware/psci: Fix memory leakage in alloc_init_cpu_groups() Gavin Shan
@ 2020-01-31 15:30 ` Sudeep Holla
0 siblings, 0 replies; 2+ messages in thread
From: Sudeep Holla @ 2020-01-31 15:30 UTC (permalink / raw)
To: Gavin Shan
Cc: mark.rutland, lorenzo.pieralisi, linux-arm-kernel, Sudeep Holla
On Fri, Jan 31, 2020 at 08:51:48AM +1100, Gavin Shan wrote:
> The CPU mask (@tmp) should be free'd on failing to allocate @cpu_groups
> or any of its elements. Otherwise, it leads to memory leakage because the
> CPU mask variable is dynamically allocated with CONFIG_CPUMASK_OFFSTACK.
>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-31 15:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-30 21:51 [PATCH v2] drivers/firmware/psci: Fix memory leakage in alloc_init_cpu_groups() Gavin Shan
2020-01-31 15:30 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).