From: Will Deacon <will@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
James Morse <james.morse@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: entry: unmask IRQ in el0_sp()
Date: Thu, 5 Mar 2020 20:30:21 +0000 [thread overview]
Message-ID: <20200305203021.GA29446@willie-the-truck> (raw)
In-Reply-To: <20200228160809.GK36089@lakrids.cambridge.arm.com>
On Fri, Feb 28, 2020 at 04:08:09PM +0000, Mark Rutland wrote:
> On Fri, Feb 28, 2020 at 03:37:46PM +0000, James Morse wrote:
> > On 28/02/2020 14:59, Mark Rutland wrote:
> > > Let's do so now, and make it interruptible as with most other
> > > synchronous exception handlers.
> >
> > I think you want:
> > Fixes: bfe298745afc9548 ("arm64: entry-common: don't touch daif before bp-hardening")
> >
> > on this as, bfe298745afc9548 changed the behaviour: local_daif_restore(DAIF_PROCCTX) was
> > called before arm64_notify_die(), now its not.
> >
> > With that,
> > Reviewed-by: James Morse <james.morse@arm.com>
>
> Ah; I missed that subtlety.
>
> I assume that Catalin can fold those in when applying. Otherwise I'll
> add them for a v2.
If you want v2 to go in as a fix, please can you explain why this is a
problem (beyond disabling interrupts for longer than necessary) in the
commit message?
Cheers,
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-05 20:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 14:59 [PATCH] arm64: entry: unmask IRQ in el0_sp() Mark Rutland
2020-02-28 15:37 ` James Morse
2020-02-28 16:08 ` Mark Rutland
2020-03-05 20:30 ` Will Deacon [this message]
2020-03-09 16:04 ` James Morse
2020-03-10 10:51 ` Mark Rutland
2020-03-11 14:35 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305203021.GA29446@willie-the-truck \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).