From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Alexandre Torgue <alexandre.torgue@st.com>,
Michael Williams <michael.williams@arm.com>,
"Dmitry V. Levin" <ldv@altlinux.org>,
Eugene Syromiatnikov <esyr@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Chunyan Zhang <zhang.chunyan@linaro.org>,
Pratik Patel <pratikp@codeaurora.org>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] coresight: do not use the BIT() macro in the UAPI header
Date: Thu, 26 Mar 2020 15:10:11 +0100 [thread overview]
Message-ID: <20200326141011.GA1313869@kroah.com> (raw)
In-Reply-To: <CANLsYkwVybRG9L6gDJTzZ=eXut66vJYfuEtOfLzaYaVpdybT1A@mail.gmail.com>
On Tue, Mar 24, 2020 at 09:31:15AM -0600, Mathieu Poirier wrote:
> On Mon, 23 Mar 2020 at 22:22, Eugene Syromiatnikov <esyr@redhat.com> wrote:
> >
> > The BIT() macro definition is not available for the UAPI headers
> > (moreover, it can be defined differently in the user space); replace
> > its usage with the _BITUL() macro that is defined in <linux/const.h>.
> >
> > Fixes: 237483aa5cf4 ("coresight: stm: adding driver for CoreSight STM component")
> > Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
> > ---
> > include/uapi/linux/coresight-stm.h | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/uapi/linux/coresight-stm.h b/include/uapi/linux/coresight-stm.h
> > index aac550a..8847dbf 100644
> > --- a/include/uapi/linux/coresight-stm.h
> > +++ b/include/uapi/linux/coresight-stm.h
> > @@ -2,8 +2,10 @@
> > #ifndef __UAPI_CORESIGHT_STM_H_
> > #define __UAPI_CORESIGHT_STM_H_
> >
> > -#define STM_FLAG_TIMESTAMPED BIT(3)
> > -#define STM_FLAG_GUARANTEED BIT(7)
> > +#include <linux/const.h>
> > +
> > +#define STM_FLAG_TIMESTAMPED _BITUL(3)
> > +#define STM_FLAG_GUARANTEED _BITUL(7)
>
> Greg, if you want to pick this up right away:
>
> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>
> Otherwise let me know and I'll add it to my next tree.
I'll take it now, thanks.
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-03-26 14:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 4:22 [PATCH] coresight: do not use the BIT() macro in the UAPI header Eugene Syromiatnikov
2020-03-24 6:28 ` Greg Kroah-Hartman
2020-03-24 9:53 ` Eugene Syromiatnikov
2020-03-24 10:19 ` Greg Kroah-Hartman
2020-03-24 12:13 ` Eugene Syromiatnikov
2020-03-24 15:31 ` Mathieu Poirier
2020-03-26 14:10 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326141011.GA1313869@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexandre.torgue@st.com \
--cc=esyr@redhat.com \
--cc=ldv@altlinux.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mathieu.poirier@linaro.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael.williams@arm.com \
--cc=pratikp@codeaurora.org \
--cc=zhang.chunyan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).