From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Eugene Syromiatnikov <esyr@redhat.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Alexandre Torgue <alexandre.torgue@st.com>,
Michael Williams <michael.williams@arm.com>,
linux-kernel@vger.kernel.org,
Chunyan Zhang <zhang.chunyan@linaro.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"Dmitry V. Levin" <ldv@altlinux.org>,
Pratik Patel <pratikp@codeaurora.org>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] coresight: do not use the BIT() macro in the UAPI header
Date: Tue, 24 Mar 2020 11:19:38 +0100 [thread overview]
Message-ID: <20200324101938.GA2220478@kroah.com> (raw)
In-Reply-To: <20200324095304.GA2444@asgard.redhat.com>
On Tue, Mar 24, 2020 at 10:53:04AM +0100, Eugene Syromiatnikov wrote:
> On Tue, Mar 24, 2020 at 07:28:53AM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Mar 24, 2020 at 05:22:13AM +0100, Eugene Syromiatnikov wrote:
> > > The BIT() macro definition is not available for the UAPI headers
> > > (moreover, it can be defined differently in the user space); replace
> > > its usage with the _BITUL() macro that is defined in <linux/const.h>.
> >
> > Why is somehow _BITUL() ok to use here instead?
>
> It is provided in an UAPI header (include/uapi/linux/const.h)
> and is appropriately prefixed with an underscore to avoid conflicts.
Because no one uses _ in their own macros? :)
Anyway, this is fine, but if it's really the way forward, I think a lot
of files will end up being changed...
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-24 10:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 4:22 [PATCH] coresight: do not use the BIT() macro in the UAPI header Eugene Syromiatnikov
2020-03-24 6:28 ` Greg Kroah-Hartman
2020-03-24 9:53 ` Eugene Syromiatnikov
2020-03-24 10:19 ` Greg Kroah-Hartman [this message]
2020-03-24 12:13 ` Eugene Syromiatnikov
2020-03-24 15:31 ` Mathieu Poirier
2020-03-26 14:10 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324101938.GA2220478@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexandre.torgue@st.com \
--cc=esyr@redhat.com \
--cc=ldv@altlinux.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mathieu.poirier@linaro.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael.williams@arm.com \
--cc=pratikp@codeaurora.org \
--cc=zhang.chunyan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).