Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/1] ARM: convert to use new I2C API
@ 2020-03-26 21:10 Wolfram Sang
  2020-03-26 21:10 ` [PATCH 1/1] ARM: mach-s3c64xx: convert to use i2c_new_client_device() Wolfram Sang
  0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2020-03-26 21:10 UTC (permalink / raw)
  To: linux-i2c
  Cc: Wolfram Sang, linux-samsung-soc, linux-kernel, linux-arm-kernel, patches

We are deprecating calls which return NULL in favor of new variants which
return an ERR_PTR. Only build tested.


Wolfram Sang (1):
  ARM: mach-s3c64xx: convert to use i2c_new_client_device()

 arch/arm/mach-s3c64xx/mach-crag6410-module.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] ARM: mach-s3c64xx: convert to use i2c_new_client_device()
  2020-03-26 21:10 [PATCH 0/1] ARM: convert to use new I2C API Wolfram Sang
@ 2020-03-26 21:10 ` Wolfram Sang
  2020-03-27 11:50   ` Charles Keepax
  0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2020-03-26 21:10 UTC (permalink / raw)
  To: linux-i2c
  Cc: linux-samsung-soc, patches, Russell King, Krzysztof Kozlowski,
	linux-kernel, Wolfram Sang, Kukjin Kim, linux-arm-kernel

Move away from the deprecated API and remove printing a stale 'ret'
value.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm/mach-s3c64xx/mach-crag6410-module.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c b/arch/arm/mach-s3c64xx/mach-crag6410-module.c
index 937d0a83f8fd..34f1baa10c54 100644
--- a/arch/arm/mach-s3c64xx/mach-crag6410-module.c
+++ b/arch/arm/mach-s3c64xx/mach-crag6410-module.c
@@ -405,10 +405,9 @@ static int wlf_gf_module_probe(struct i2c_client *i2c,
 			 gf_mods[i].name, rev + 1);
 
 		for (j = 0; j < gf_mods[i].num_i2c_devs; j++) {
-			if (!i2c_new_device(i2c->adapter,
-					    &(gf_mods[i].i2c_devs[j])))
-				dev_err(&i2c->dev,
-					"Failed to register dev: %d\n", ret);
+			if (IS_ERR(i2c_new_client_device(i2c->adapter,
+							 &(gf_mods[i].i2c_devs[j]))))
+				dev_err(&i2c->dev, "Failed to register\n");
 		}
 
 		spi_register_board_info(gf_mods[i].spi_devs,
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] ARM: mach-s3c64xx: convert to use i2c_new_client_device()
  2020-03-26 21:10 ` [PATCH 1/1] ARM: mach-s3c64xx: convert to use i2c_new_client_device() Wolfram Sang
@ 2020-03-27 11:50   ` Charles Keepax
  0 siblings, 0 replies; 3+ messages in thread
From: Charles Keepax @ 2020-03-27 11:50 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: linux-samsung-soc, patches, Russell King, Krzysztof Kozlowski,
	linux-kernel, Kukjin Kim, linux-i2c, linux-arm-kernel

On Thu, Mar 26, 2020 at 10:10:14PM +0100, Wolfram Sang wrote:
> Move away from the deprecated API and remove printing a stale 'ret'
> value.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-26 21:10 [PATCH 0/1] ARM: convert to use new I2C API Wolfram Sang
2020-03-26 21:10 ` [PATCH 1/1] ARM: mach-s3c64xx: convert to use i2c_new_client_device() Wolfram Sang
2020-03-27 11:50   ` Charles Keepax

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git