* [PATCH] perf:arm_spe:Avoid duplicate printouts
@ 2020-04-02 12:03 Tang Bin
2020-04-30 21:12 ` Will Deacon
0 siblings, 1 reply; 2+ messages in thread
From: Tang Bin @ 2020-04-02 12:03 UTC (permalink / raw)
To: will, mark.rutland; +Cc: linux-kernel, linux-arm-kernel, Tang Bin
Because platform_get_irq() has dev_err(),so this place
should be removed.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/perf/arm_spe_pmu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c
index 4e4984a55..dd561880d 100644
--- a/drivers/perf/arm_spe_pmu.c
+++ b/drivers/perf/arm_spe_pmu.c
@@ -1133,10 +1133,8 @@ static int arm_spe_pmu_irq_probe(struct arm_spe_pmu *spe_pmu)
struct platform_device *pdev = spe_pmu->pdev;
int irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(&pdev->dev, "failed to get IRQ (%d)\n", irq);
+ if (irq < 0)
return -ENXIO;
- }
if (!irq_is_percpu(irq)) {
dev_err(&pdev->dev, "expected PPI but got SPI (%d)\n", irq);
--
2.20.1.windows.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf:arm_spe:Avoid duplicate printouts
2020-04-02 12:03 [PATCH] perf:arm_spe:Avoid duplicate printouts Tang Bin
@ 2020-04-30 21:12 ` Will Deacon
0 siblings, 0 replies; 2+ messages in thread
From: Will Deacon @ 2020-04-30 21:12 UTC (permalink / raw)
To: Tang Bin, mark.rutland
Cc: catalin.marinas, Will Deacon, linux-kernel, linux-arm-kernel
On Thu, 2 Apr 2020 20:03:30 +0800, Tang Bin wrote:
> Because platform_get_irq() has dev_err(),so this place
> should be removed.
Applied to arm64 (for-next/perf), thanks!
[1/1] drivers/perf: arm_spe_pmu: Avoid duplicate printouts
https://git.kernel.org/arm64/c/1f0d97bb7082
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-30 21:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-02 12:03 [PATCH] perf:arm_spe:Avoid duplicate printouts Tang Bin
2020-04-30 21:12 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).