[bug report] armada-8040-mcbin: 5.6-rc5 boot failure

[bug report] armada-8040-mcbin: 5.6-rc5 boot failure

[Sergey Matyukevich]

Hi Russel, Miquel, and all,

MacchiatoBin Double-shot board fails to boot v5.6-rc5 kernel properly:
USB, PCIe, and ethernet interfaces are not enabled. Before that I have
been running v5.3 kernel w/o any noticeable issues.

In brief, USB and PCIe devices are not detected, ethernet PHY fails
to initialize with the following warnings:
[    2.444150] mvebu-comphy f4120000.phy: unsupported SMC call, try updating your firmware
[    2.452191] mvebu-comphy f4120000.phy: Firmware could not configure PHY 0 with mode 15 (ret: -1), trying legacy method
[    2.474615] mvpp2 f4000000.ethernet eth2: Using firmware node mac address ...
[    2.484420] mvebu-comphy f4120000.phy: unsupported SMC call, try updating your firmware

After quick bisection of the board dts files, I came to the following results:

- USB works again after reverting the following two commits:
  -- 96018a6fafb1 ("arm64: dts: marvell: Convert 7k/8k usb-phy properties to phy-supply")
  -- 01d0deba28f6 ("arm64: dts: marvell: Add 7k/8k PHYs in USB3 nodes")

- PCIe works again after reverting armada-8040-mcbin.dtsi parts of the
  following two commits:
  -- 1399672e48b5 ("arm64: dts: marvell: Drop PCIe I/O ranges from CP11x file")
  -- ce55522c035e ("arm64: dts: marvell: Add 7k/8k PHYs in PCIe nodes")

- ethernet: not yet...

However looking at firmware version complaints, I guess that the actual
reason of all those issues could be in ATF version rather than in the
latest DTS changes. Probably I am using ATF version which is too old
to work with up-to-date kernel: armada-17.10.3 from atf-marvell
repository on github. If this is indeed the actual root cause of all
the issues, then could you please recommend a preferable ATF version
to test with ?

Regards,
Sergey

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [bug report] armada-8040-mcbin: 5.6-rc5 boot failure

[Russell King - ARM Linux admin]

On Tue, Apr 14, 2020 at 01:05:20AM +0300, Sergey Matyukevich wrote:
> Hi Russel, Miquel, and all,
> 
> MacchiatoBin Double-shot board fails to boot v5.6-rc5 kernel properly:
> USB, PCIe, and ethernet interfaces are not enabled. Before that I have
> been running v5.3 kernel w/o any noticeable issues.
> 
> In brief, USB and PCIe devices are not detected, ethernet PHY fails
> to initialize with the following warnings:
> [    2.444150] mvebu-comphy f4120000.phy: unsupported SMC call, try updating your firmware
> [    2.452191] mvebu-comphy f4120000.phy: Firmware could not configure PHY 0 with mode 15 (ret: -1), trying legacy method
> [    2.474615] mvpp2 f4000000.ethernet eth2: Using firmware node mac address ...
> [    2.484420] mvebu-comphy f4120000.phy: unsupported SMC call, try updating your firmware
> 
> After quick bisection of the board dts files, I came to the following results:
> 
> - USB works again after reverting the following two commits:
>   -- 96018a6fafb1 ("arm64: dts: marvell: Convert 7k/8k usb-phy properties to phy-supply")
>   -- 01d0deba28f6 ("arm64: dts: marvell: Add 7k/8k PHYs in USB3 nodes")
> 
> - PCIe works again after reverting armada-8040-mcbin.dtsi parts of the
>   following two commits:
>   -- 1399672e48b5 ("arm64: dts: marvell: Drop PCIe I/O ranges from CP11x file")
>   -- ce55522c035e ("arm64: dts: marvell: Add 7k/8k PHYs in PCIe nodes")
> 
> - ethernet: not yet...
> 
> However looking at firmware version complaints, I guess that the actual
> reason of all those issues could be in ATF version rather than in the
> latest DTS changes. Probably I am using ATF version which is too old
> to work with up-to-date kernel: armada-17.10.3 from atf-marvell
> repository on github. If this is indeed the actual root cause of all
> the issues, then could you please recommend a preferable ATF version
> to test with ?

I would strongly recommend upgrading the firmware in any case, because
of work I did (and submitted back through Jon @ SolidRun) to improve
the eye mask on the 10G Ethernet interfaces.  I'm using the 18.12
version.  Firmware build instructions can be found at:

https://developer.solid-run.com/knowledge-base/armada-8040-machiatobin-u-boot-and-atf/

I've booted 5.6 recently on a number of Armada 8040 based boards
without issue, likely all running the later firmware.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [bug report] armada-8040-mcbin: 5.6-rc5 boot failure

[Sergey Matyukevich]

> > Hi Russel, Miquel, and all,
> > 
> > MacchiatoBin Double-shot board fails to boot v5.6-rc5 kernel properly:
> > USB, PCIe, and ethernet interfaces are not enabled. Before that I have
> > been running v5.3 kernel w/o any noticeable issues.

...
 
> > However looking at firmware version complaints, I guess that the actual
> > reason of all those issues could be in ATF version rather than in the
> > latest DTS changes. Probably I am using ATF version which is too old
> > to work with up-to-date kernel: armada-17.10.3 from atf-marvell
> > repository on github. If this is indeed the actual root cause of all
> > the issues, then could you please recommend a preferable ATF version
> > to test with ?
> 
> I would strongly recommend upgrading the firmware in any case, because
> of work I did (and submitted back through Jon @ SolidRun) to improve
> the eye mask on the 10G Ethernet interfaces.  I'm using the 18.12
> version.  Firmware build instructions can be found at:
> 
> https://developer.solid-run.com/knowledge-base/armada-8040-machiatobin-u-boot-and-atf/
> 
> I've booted 5.6 recently on a number of Armada 8040 based boards
> without issue, likely all running the later firmware.

Thanks ! After ATF update to 18.12 both USB and PCIe are working fine
without any changes to DTS. But network interfaces including 1G copper
interface still do not work as expected:

$ ip link set eth0 up                                                                                                                                                                             
[  626.774003] mvpp2 f2000000.ethernet eth0: could not attach PHY (-19) RTNETLINK answers: No such device
$ ip link set eth2 up
[  504.054084] mvpp2 f4000000.ethernet eth2: could not attach PHY (-19) RTNETLINK answers: No such device

I have not changed configuration since 5.3, so all the marvell phy
drivers are in place. Is there anything in configuration that could
be missed after moving from 5.3 to 5.6 kernel ?

Regards,
Sergey

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [bug report] armada-8040-mcbin: 5.6-rc5 boot failure

[Willy Tarreau]

Hi,

On Tue, Apr 14, 2020 at 07:03:54PM +0300, Sergey Matyukevich wrote:
> I have not changed configuration since 5.3, so all the marvell phy
> drivers are in place. Is there anything in configuration that could
> be missed after moving from 5.3 to 5.6 kernel ?

FWIW mine works perfectly fine with 5.4 at 1G/2.5G/10G. From what I can
quickly check here are the relevant parts in my config for ethernet (not
sure all are needed though):

CONFIG_NET_VENDOR_MARVELL=y
CONFIG_MVMDIO=y
CONFIG_MVPP2=y
CONFIG_MDIO_DEVICE=y
CONFIG_MDIO_BUS=y
CONFIG_MDIO_BITBANG=y
CONFIG_MDIO_BUS_MUX=y
CONFIG_MDIO_BUS_MUX_MMIOREG=y
CONFIG_MDIO_BUS_MUX_MULTIPLEXER=y
CONFIG_MDIO_I2C=y
CONFIG_PHYLINK=y
CONFIG_PHYLIB=y
CONFIG_SWPHY=y
CONFIG_SFP=y
CONFIG_FIXED_PHY=y
CONFIG_MARVELL_PHY=y
CONFIG_MARVELL_10G_PHY=y

Not tested 5.6 yet.

Hoping this helps,
Willy

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [bug report] armada-8040-mcbin: 5.6-rc5 boot failure

[Russell King - ARM Linux admin]

On Tue, Apr 14, 2020 at 06:08:38PM +0200, Willy Tarreau wrote:
> Hi,
> 
> On Tue, Apr 14, 2020 at 07:03:54PM +0300, Sergey Matyukevich wrote:
> > I have not changed configuration since 5.3, so all the marvell phy
> > drivers are in place. Is there anything in configuration that could
> > be missed after moving from 5.3 to 5.6 kernel ?
> 
> FWIW mine works perfectly fine with 5.4 at 1G/2.5G/10G. From what I can
> quickly check here are the relevant parts in my config for ethernet (not
> sure all are needed though):
> 
> CONFIG_NET_VENDOR_MARVELL=y
> CONFIG_MVMDIO=y
> CONFIG_MVPP2=y
> CONFIG_MDIO_DEVICE=y
> CONFIG_MDIO_BUS=y
> CONFIG_MDIO_BITBANG=y

Macchiatobin doesn't bitbang the MDIO bus.

> CONFIG_MDIO_BUS_MUX=y
> CONFIG_MDIO_BUS_MUX_MMIOREG=y
> CONFIG_MDIO_BUS_MUX_MULTIPLEXER=y

There's no MDIO bus muxing on Macchiatobin.

> CONFIG_MDIO_I2C=y
> CONFIG_PHYLINK=y
> CONFIG_PHYLIB=y
> CONFIG_SWPHY=y
> CONFIG_SFP=y
> CONFIG_FIXED_PHY=y

CONFIG_FIXED_PHY should no longer be required.

> CONFIG_MARVELL_PHY=y
> CONFIG_MARVELL_10G_PHY=y
> 
> Not tested 5.6 yet.
> 
> Hoping this helps,
> Willy
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [bug report] armada-8040-mcbin: 5.6-rc5 boot failure

[Willy Tarreau]

Hi Russell,

On Tue, Apr 14, 2020 at 05:55:33PM +0100, Russell King - ARM Linux admin wrote:
> > CONFIG_MDIO_BITBANG=y
> 
> Macchiatobin doesn't bitbang the MDIO bus.
> 
> > CONFIG_MDIO_BUS_MUX=y
> 
> There's no MDIO bus muxing on Macchiatobin.
> 
> > CONFIG_FIXED_PHY=y
> 
> CONFIG_FIXED_PHY should no longer be required.
(...)

Thanks for clearing these ones out, I'll drop them on next build!
Willy

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [bug report] armada-8040-mcbin: 5.6-rc5 boot failure

[Sergey Matyukevich]

> > > I have not changed configuration since 5.3, so all the marvell phy
> > > drivers are in place. Is there anything in configuration that could
> > > be missed after moving from 5.3 to 5.6 kernel ?
> > 
> > FWIW mine works perfectly fine with 5.4 at 1G/2.5G/10G. From what I can
> > quickly check here are the relevant parts in my config for ethernet (not
> > sure all are needed though):
> > 
> > CONFIG_NET_VENDOR_MARVELL=y
> > CONFIG_MVMDIO=y
> > CONFIG_MVPP2=y
> > CONFIG_MDIO_DEVICE=y
> > CONFIG_MDIO_BUS=y
> > CONFIG_MDIO_BITBANG=y
> 
> Macchiatobin doesn't bitbang the MDIO bus.
> 
> > CONFIG_MDIO_BUS_MUX=y
> > CONFIG_MDIO_BUS_MUX_MMIOREG=y
> > CONFIG_MDIO_BUS_MUX_MULTIPLEXER=y
> 
> There's no MDIO bus muxing on Macchiatobin.
> 
> > CONFIG_MDIO_I2C=y
> > CONFIG_PHYLINK=y
> > CONFIG_PHYLIB=y
> > CONFIG_SWPHY=y
> > CONFIG_SFP=y
> > CONFIG_FIXED_PHY=y
> 
> CONFIG_FIXED_PHY should no longer be required.
> 
> > CONFIG_MARVELL_PHY=y
> > CONFIG_MARVELL_10G_PHY=y
> > 
> > Not tested 5.6 yet.

Thanks ! I tested mainline kernels 5.6-rc5, 5.6, 5.7-rc1: all of them
worked just fine on MacchiatoBin. After that I finally figured out what
was wrong with my setup even after updating ATF to 18.12.

Initally I used wireless-drivers-next kernel tree v5.6-rc1. It turned
out that this tree at that point included commit e1f550dc44a ("net:
mvmdio: avoid error message for optional IRQ") but did not included its
subsequent revert...

Regards,
Sergey

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel