linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: sun8i-h2-plus-bananapi-m2-zero: Fix led polarity
@ 2020-04-11 17:48 Vincent Stehlé
  2020-04-14  7:30 ` Maxime Ripard
  0 siblings, 1 reply; 2+ messages in thread
From: Vincent Stehlé @ 2020-04-11 17:48 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, linux-kernel
  Cc: Chen-Yu Tsai, Rob Herring, Icenowy Zheng, Maxime Ripard,
	Vincent Stehlé

The PWR-LED on the bananapi m2 zero board is on when gpio PL10 is low.
This has been verified on a board and in the schematics [1].

[1]: http://wiki.banana-pi.org/Banana_Pi_BPI-M2_ZERO#Documents

Fixes: 8b8061fcbfae ("ARM: dts: sun8i: h2+: add support for Banana Pi M2 Zero board")
Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
Cc: Icenowy Zheng <icenowy@aosc.io>
Cc: Maxime Ripard <mripard@kernel.org>
---
 arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
index d277d043031b2..4c6704e4c57ec 100644
--- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
+++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
@@ -31,7 +31,7 @@ leds {
 
 		pwr_led {
 			label = "bananapi-m2-zero:red:pwr";
-			gpios = <&r_pio 0 10 GPIO_ACTIVE_HIGH>; /* PL10 */
+			gpios = <&r_pio 0 10 GPIO_ACTIVE_LOW>; /* PL10 */
 			default-state = "on";
 		};
 	};
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: sun8i-h2-plus-bananapi-m2-zero: Fix led polarity
  2020-04-11 17:48 [PATCH] ARM: dts: sun8i-h2-plus-bananapi-m2-zero: Fix led polarity Vincent Stehlé
@ 2020-04-14  7:30 ` Maxime Ripard
  0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2020-04-14  7:30 UTC (permalink / raw)
  To: Vincent Stehlé
  Cc: devicetree, linux-kernel, Chen-Yu Tsai, Rob Herring,
	linux-arm-kernel, Icenowy Zheng


[-- Attachment #1.1: Type: text/plain, Size: 536 bytes --]

On Sat, Apr 11, 2020 at 07:48:43PM +0200, Vincent Stehlé wrote:
> The PWR-LED on the bananapi m2 zero board is on when gpio PL10 is low.
> This has been verified on a board and in the schematics [1].
>
> [1]: http://wiki.banana-pi.org/Banana_Pi_BPI-M2_ZERO#Documents
>
> Fixes: 8b8061fcbfae ("ARM: dts: sun8i: h2+: add support for Banana Pi M2 Zero board")
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> Cc: Icenowy Zheng <icenowy@aosc.io>
> Cc: Maxime Ripard <mripard@kernel.org>

Applied, thanks

Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-14  7:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-11 17:48 [PATCH] ARM: dts: sun8i-h2-plus-bananapi-m2-zero: Fix led polarity Vincent Stehlé
2020-04-14  7:30 ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).