* [PATCH net-next] net: lpc-enet: fix error return code in lpc_mii_init()
@ 2020-04-27 12:15 Wei Yongjun
2020-04-27 13:24 ` Vladimir Zapolskiy
2020-05-01 3:29 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2020-04-27 12:15 UTC (permalink / raw)
To: Vladimir Zapolskiy, Sylvain Lemieux, Sumit Semwal, stigge @ antcom . de
Cc: netdev, kernel-janitors, dri-devel, linaro-mm-sig, Wei Yongjun,
linux-arm-kernel, linux-media
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: b7370112f519 ("lpc32xx: Added ethernet driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/nxp/lpc_eth.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
index d20cf03a3ea0..311454d9b0bc 100644
--- a/drivers/net/ethernet/nxp/lpc_eth.c
+++ b/drivers/net/ethernet/nxp/lpc_eth.c
@@ -823,7 +823,8 @@ static int lpc_mii_init(struct netdata_local *pldat)
if (err)
goto err_out_unregister_bus;
- if (lpc_mii_probe(pldat->ndev) != 0)
+ err = lpc_mii_probe(pldat->ndev);
+ if (err)
goto err_out_unregister_bus;
return 0;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: lpc-enet: fix error return code in lpc_mii_init()
2020-04-27 12:15 [PATCH net-next] net: lpc-enet: fix error return code in lpc_mii_init() Wei Yongjun
@ 2020-04-27 13:24 ` Vladimir Zapolskiy
2020-05-01 3:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Vladimir Zapolskiy @ 2020-04-27 13:24 UTC (permalink / raw)
To: Wei Yongjun, Sylvain Lemieux, Sumit Semwal, stigge @ antcom . de
Cc: netdev, kernel-janitors, dri-devel, linaro-mm-sig,
linux-arm-kernel, linux-media
On 4/27/20 3:15 PM, Wei Yongjun wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: b7370112f519 ("lpc32xx: Added ethernet driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
--
Best wishes,
Vladimir
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: lpc-enet: fix error return code in lpc_mii_init()
2020-04-27 12:15 [PATCH net-next] net: lpc-enet: fix error return code in lpc_mii_init() Wei Yongjun
2020-04-27 13:24 ` Vladimir Zapolskiy
@ 2020-05-01 3:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-05-01 3:29 UTC (permalink / raw)
To: weiyongjun1
Cc: stigge, netdev, kernel-janitors, dri-devel, vz, linaro-mm-sig,
slemieux.tyco, sumit.semwal, linux-arm-kernel, linux-media
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Mon, 27 Apr 2020 12:15:07 +0000
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: b7370112f519 ("lpc32xx: Added ethernet driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-01 3:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-27 12:15 [PATCH net-next] net: lpc-enet: fix error return code in lpc_mii_init() Wei Yongjun
2020-04-27 13:24 ` Vladimir Zapolskiy
2020-05-01 3:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).