* [PATCH] via-rhine: Add platform dependencies
@ 2020-05-07 11:42 Geert Uytterhoeven
2020-05-07 13:19 ` Arnd Bergmann
2020-05-07 20:17 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2020-05-07 11:42 UTC (permalink / raw)
To: David S . Miller, Tony Prisk
Cc: netdev, Geert Uytterhoeven, linux-arm-kernel, Arnd Bergmann
The VIA Rhine Ethernet interface is only present on PCI devices or
VIA/WonderMedia VT8500/WM85xx SoCs. Add platform dependencies to the
VIA_RHINE config symbol, to avoid asking the user about it when
configuring a kernel without PCI or VT8500/WM85xx support.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/net/ethernet/via/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/via/Kconfig b/drivers/net/ethernet/via/Kconfig
index a962097b58c66935..6cff5f7d57c47ba7 100644
--- a/drivers/net/ethernet/via/Kconfig
+++ b/drivers/net/ethernet/via/Kconfig
@@ -19,6 +19,7 @@ if NET_VENDOR_VIA
config VIA_RHINE
tristate "VIA Rhine support"
depends on PCI || (OF_IRQ && GENERIC_PCI_IOMAP)
+ depends on PCI || ARCH_VT8500 || COMPILE_TEST
depends on HAS_DMA
select CRC32
select MII
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] via-rhine: Add platform dependencies
2020-05-07 11:42 [PATCH] via-rhine: Add platform dependencies Geert Uytterhoeven
@ 2020-05-07 13:19 ` Arnd Bergmann
2020-05-07 20:17 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2020-05-07 13:19 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Tony Prisk, Networking, David S . Miller, Linux ARM
On Thu, May 7, 2020 at 1:42 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> The VIA Rhine Ethernet interface is only present on PCI devices or
> VIA/WonderMedia VT8500/WM85xx SoCs. Add platform dependencies to the
> VIA_RHINE config symbol, to avoid asking the user about it when
> configuring a kernel without PCI or VT8500/WM85xx support.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Arnd Bergmann <arnd@arndb.de>
I suppose it might be used on VIA/Zhaoxin SoCs, but presumably those
would always show it as a PCI device.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] via-rhine: Add platform dependencies
2020-05-07 11:42 [PATCH] via-rhine: Add platform dependencies Geert Uytterhoeven
2020-05-07 13:19 ` Arnd Bergmann
@ 2020-05-07 20:17 ` David Miller
2020-05-08 7:10 ` Geert Uytterhoeven
1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2020-05-07 20:17 UTC (permalink / raw)
To: geert+renesas; +Cc: linux, netdev, linux-arm-kernel, arnd
From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: Thu, 7 May 2020 13:42:05 +0200
> The VIA Rhine Ethernet interface is only present on PCI devices or
> VIA/WonderMedia VT8500/WM85xx SoCs. Add platform dependencies to the
> VIA_RHINE config symbol, to avoid asking the user about it when
> configuring a kernel without PCI or VT8500/WM85xx support.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Applied to net-next.
Although I hope that the COMPILE_TEST guard is not too loose and
now we'll have randconfig build failures for some reason.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] via-rhine: Add platform dependencies
2020-05-07 20:17 ` David Miller
@ 2020-05-08 7:10 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2020-05-08 7:10 UTC (permalink / raw)
To: David Miller
Cc: Tony Prisk, netdev, Arnd Bergmann, Geert Uytterhoeven, Linux ARM
Hi David,
On Thu, May 7, 2020 at 10:17 PM David Miller <davem@davemloft.net> wrote:
> From: Geert Uytterhoeven <geert+renesas@glider.be>
> Date: Thu, 7 May 2020 13:42:05 +0200
>
> > The VIA Rhine Ethernet interface is only present on PCI devices or
> > VIA/WonderMedia VT8500/WM85xx SoCs. Add platform dependencies to the
> > VIA_RHINE config symbol, to avoid asking the user about it when
> > configuring a kernel without PCI or VT8500/WM85xx support.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Applied to net-next.
Thank you!
> Although I hope that the COMPILE_TEST guard is not too loose and
> now we'll have randconfig build failures for some reason.
I only added a dependency line, and didn't replace the old one.
The "depends on PCI || (OF_IRQ && GENERIC_PCI_IOMAP)" is still there.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-08 7:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-07 11:42 [PATCH] via-rhine: Add platform dependencies Geert Uytterhoeven
2020-05-07 13:19 ` Arnd Bergmann
2020-05-07 20:17 ` David Miller
2020-05-08 7:10 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).