linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: at91: Configure SCL gpio of i2c2 node as open drain
@ 2020-05-15 15:32 Codrin Ciubotariu
  2020-05-15 15:39 ` Alexandre Belloni
  0 siblings, 1 reply; 2+ messages in thread
From: Codrin Ciubotariu @ 2020-05-15 15:32 UTC (permalink / raw)
  To: linux-clk, linux-arm-kernel, linux-kernel
  Cc: alexandre.belloni, sboyd, mturquette, ludovic.desroches,
	eugen.hristev, Codrin Ciubotariu

The SCL gpio pin of i2c2 node used for recovery needs to be configured as
open drain.

Fixes: 455fec938bbb ("ARM: dts: at91: sama5d2: add i2c gpio pinctrl")
Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
---
 arch/arm/boot/dts/at91-sama5d2_xplained.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
index 5846720fc9dc..851b8587068b 100644
--- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
@@ -344,7 +344,7 @@ i2c2: i2c@600 {
 					pinctrl-0 = <&pinctrl_flx0_default>;
 					pinctrl-1 = <&pinctrl_i2c2_gpio>;
 					sda-gpios = <&pioA PIN_PB28 GPIO_ACTIVE_HIGH>;
-					scl-gpios = <&pioA PIN_PB29 GPIO_ACTIVE_HIGH>;
+					scl-gpios = <&pioA PIN_PB29 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
 					i2c-sda-hold-time-ns = <350>;
 					i2c-analog-filter;
 					i2c-digital-filter;
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: at91: Configure SCL gpio of i2c2 node as open drain
  2020-05-15 15:32 [PATCH] ARM: dts: at91: Configure SCL gpio of i2c2 node as open drain Codrin Ciubotariu
@ 2020-05-15 15:39 ` Alexandre Belloni
  0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2020-05-15 15:39 UTC (permalink / raw)
  To: Codrin Ciubotariu
  Cc: sboyd, mturquette, linux-kernel, ludovic.desroches,
	eugen.hristev, linux-clk, linux-arm-kernel

On 15/05/2020 18:32:39+0300, Codrin Ciubotariu wrote:
> The SCL gpio pin of i2c2 node used for recovery needs to be configured as
> open drain.
> 
> Fixes: 455fec938bbb ("ARM: dts: at91: sama5d2: add i2c gpio pinctrl")
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> ---
>  arch/arm/boot/dts/at91-sama5d2_xplained.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Squashed in the previous one, thanks.

> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> index 5846720fc9dc..851b8587068b 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> @@ -344,7 +344,7 @@ i2c2: i2c@600 {
>  					pinctrl-0 = <&pinctrl_flx0_default>;
>  					pinctrl-1 = <&pinctrl_i2c2_gpio>;
>  					sda-gpios = <&pioA PIN_PB28 GPIO_ACTIVE_HIGH>;
> -					scl-gpios = <&pioA PIN_PB29 GPIO_ACTIVE_HIGH>;
> +					scl-gpios = <&pioA PIN_PB29 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  					i2c-sda-hold-time-ns = <350>;
>  					i2c-analog-filter;
>  					i2c-digital-filter;
> -- 
> 2.25.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-15 15:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-15 15:32 [PATCH] ARM: dts: at91: Configure SCL gpio of i2c2 node as open drain Codrin Ciubotariu
2020-05-15 15:39 ` Alexandre Belloni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).