* [PATCH] arm64: dts: rockchip: fix rk3368-lion gmac reset gpio
@ 2020-06-07 21:29 Heiko Stuebner
2020-06-17 8:37 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Heiko Stuebner @ 2020-06-07 21:29 UTC (permalink / raw)
To: linux-rockchip
Cc: Heiko Stuebner, klaus.goger, linux-arm-kernel, christoph.muellner
From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
The lion gmac node currently uses opposite active-values for the
gmac phy reset pin. The gpio-declaration uses active-high while the
separate snps,reset-active-low property marks the pin as active low.
While on the kernel side this works ok, other DT users may get
confused - as seen with uboot right now.
So bring this in line and make both properties match, similar to the
other Rockchip board.
Fixes: d99a02bcfa81 ("arm64: dts: rockchip: add RK3368-uQ7 (Lion) SoM")
Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
---
arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi b/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi
index a53de05b5c80..0a137df1ed40 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi
@@ -157,7 +157,7 @@ &gmac {
pinctrl-0 = <&rgmii_pins>;
snps,reset-active-low;
snps,reset-delays-us = <0 10000 50000>;
- snps,reset-gpio = <&gpio3 RK_PB3 GPIO_ACTIVE_HIGH>;
+ snps,reset-gpio = <&gpio3 RK_PB3 GPIO_ACTIVE_LOW>;
tx_delay = <0x10>;
rx_delay = <0x10>;
status = "okay";
--
2.26.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: fix rk3368-lion gmac reset gpio
2020-06-07 21:29 [PATCH] arm64: dts: rockchip: fix rk3368-lion gmac reset gpio Heiko Stuebner
@ 2020-06-17 8:37 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2020-06-17 8:37 UTC (permalink / raw)
To: linux-rockchip, Heiko Stuebner
Cc: Heiko Stuebner, klaus.goger, linux-arm-kernel, christoph.muellner
On Sun, 7 Jun 2020 23:29:09 +0200, Heiko Stuebner wrote:
> The lion gmac node currently uses opposite active-values for the
> gmac phy reset pin. The gpio-declaration uses active-high while the
> separate snps,reset-active-low property marks the pin as active low.
>
> While on the kernel side this works ok, other DT users may get
> confused - as seen with uboot right now.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: fix rk3368-lion gmac reset gpio
commit: 2300e6dab473e93181cf76e4fe6671aa3d24c57b
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-17 8:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-07 21:29 [PATCH] arm64: dts: rockchip: fix rk3368-lion gmac reset gpio Heiko Stuebner
2020-06-17 8:37 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).