* [PATCH] gpio: mpc8xxx: change the gpio interrupt flags.
@ 2020-06-11 10:28 Hui Song
2020-06-15 8:14 ` Bartosz Golaszewski
0 siblings, 1 reply; 4+ messages in thread
From: Hui Song @ 2020-06-11 10:28 UTC (permalink / raw)
To: Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Linus Walleij,
Bartosz Golaszewski
Cc: devicetree, Song Hui, linux-kernel, linux-arm-kernel, linux-gpio
From: Song Hui <hui.song_1@nxp.com>
Delete the interrupt IRQF_NO_THREAD flags in order to gpio interrupts
can be threaded to allow high-priority processes to preempt.
Signed-off-by: Song Hui <hui.song_1@nxp.com>
---
drivers/gpio/gpio-mpc8xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
index 604dfec..1e86652 100644
--- a/drivers/gpio/gpio-mpc8xxx.c
+++ b/drivers/gpio/gpio-mpc8xxx.c
@@ -417,7 +417,7 @@ static int mpc8xxx_probe(struct platform_device *pdev)
ret = devm_request_irq(&pdev->dev, mpc8xxx_gc->irqn,
mpc8xxx_gpio_irq_cascade,
- IRQF_NO_THREAD | IRQF_SHARED, "gpio-cascade",
+ IRQF_SHARED, "gpio-cascade",
mpc8xxx_gc);
if (ret) {
dev_err(&pdev->dev, "%s: failed to devm_request_irq(%d), ret = %d\n",
--
2.9.5
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio: mpc8xxx: change the gpio interrupt flags.
2020-06-11 10:28 [PATCH] gpio: mpc8xxx: change the gpio interrupt flags Hui Song
@ 2020-06-15 8:14 ` Bartosz Golaszewski
0 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2020-06-15 8:14 UTC (permalink / raw)
To: Hui Song
Cc: Mark Rutland, linux-devicetree, Linus Walleij, LKML, Li Yang,
linux-gpio, Rob Herring, Shawn Guo, arm-soc
czw., 11 cze 2020 o 12:43 Hui Song <hui.song_1@nxp.com> napisał(a):
>
> From: Song Hui <hui.song_1@nxp.com>
>
> Delete the interrupt IRQF_NO_THREAD flags in order to gpio interrupts
> can be threaded to allow high-priority processes to preempt.
>
> Signed-off-by: Song Hui <hui.song_1@nxp.com>
> ---
> drivers/gpio/gpio-mpc8xxx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
> index 604dfec..1e86652 100644
> --- a/drivers/gpio/gpio-mpc8xxx.c
> +++ b/drivers/gpio/gpio-mpc8xxx.c
> @@ -417,7 +417,7 @@ static int mpc8xxx_probe(struct platform_device *pdev)
>
> ret = devm_request_irq(&pdev->dev, mpc8xxx_gc->irqn,
> mpc8xxx_gpio_irq_cascade,
> - IRQF_NO_THREAD | IRQF_SHARED, "gpio-cascade",
> + IRQF_SHARED, "gpio-cascade",
> mpc8xxx_gc);
> if (ret) {
> dev_err(&pdev->dev, "%s: failed to devm_request_irq(%d), ret = %d\n",
> --
> 2.9.5
>
Patch applied, thanks!
Bartosz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] gpio: mpc8xxx: change the gpio interrupt flags.
2020-06-09 9:37 Hui Song
@ 2020-06-09 19:51 ` Leo Li
0 siblings, 0 replies; 4+ messages in thread
From: Leo Li @ 2020-06-09 19:51 UTC (permalink / raw)
To: Hui Song, linux-devel, Shawn Guo, Rob Herring, Mark Rutland,
Linus Walleij, Bartosz Golaszewski
Cc: devicetree, Hui Song, linux-kernel, linux-arm-kernel, linux-gpio
> -----Original Message-----
> From: Hui Song <hui.song_1@nxp.com>
> Sent: Tuesday, June 9, 2020 4:38 AM
> To: linux-devel@linux.nxdi.nxp.com; Shawn Guo <shawnguo@kernel.org>;
> Leo Li <leoyang.li@nxp.com>; Rob Herring <robh+dt@kernel.org>; Mark
> Rutland <mark.rutland@arm.com>; Linus Walleij <linus.walleij@linaro.org>;
> Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-gpio@vger.kernel.org; Hui Song
> <hui.song_1@nxp.com>
> Subject: [PATCH] gpio: mpc8xxx: change the gpio interrupt flags.
>
> From: Song Hui <hui.song_1@nxp.com>
>
> delete the interrupt IRQF_NO_THREAD flags.
I think this is the correct direction but would be better to describe a little bit on what motived this change. Any issue encountered or latency optimization?
>
> Signed-off-by: Song Hui <hui.song_1@nxp.com>
> ---
> drivers/gpio/gpio-mpc8xxx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c index
> 604dfec..1e86652 100644
> --- a/drivers/gpio/gpio-mpc8xxx.c
> +++ b/drivers/gpio/gpio-mpc8xxx.c
> @@ -417,7 +417,7 @@ static int mpc8xxx_probe(struct platform_device
> *pdev)
>
> ret = devm_request_irq(&pdev->dev, mpc8xxx_gc->irqn,
> mpc8xxx_gpio_irq_cascade,
> - IRQF_NO_THREAD | IRQF_SHARED, "gpio-
> cascade",
> + IRQF_SHARED, "gpio-cascade",
> mpc8xxx_gc);
> if (ret) {
> dev_err(&pdev->dev, "%s: failed to devm_request_irq(%d),
> ret = %d\n",
> --
> 2.9.5
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] gpio: mpc8xxx: change the gpio interrupt flags.
@ 2020-06-09 9:37 Hui Song
2020-06-09 19:51 ` Leo Li
0 siblings, 1 reply; 4+ messages in thread
From: Hui Song @ 2020-06-09 9:37 UTC (permalink / raw)
To: linux-devel, Shawn Guo, Li Yang, Rob Herring, Mark Rutland,
Linus Walleij, Bartosz Golaszewski
Cc: devicetree, Song Hui, linux-kernel, linux-arm-kernel, linux-gpio
From: Song Hui <hui.song_1@nxp.com>
delete the interrupt IRQF_NO_THREAD flags.
Signed-off-by: Song Hui <hui.song_1@nxp.com>
---
drivers/gpio/gpio-mpc8xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
index 604dfec..1e86652 100644
--- a/drivers/gpio/gpio-mpc8xxx.c
+++ b/drivers/gpio/gpio-mpc8xxx.c
@@ -417,7 +417,7 @@ static int mpc8xxx_probe(struct platform_device *pdev)
ret = devm_request_irq(&pdev->dev, mpc8xxx_gc->irqn,
mpc8xxx_gpio_irq_cascade,
- IRQF_NO_THREAD | IRQF_SHARED, "gpio-cascade",
+ IRQF_SHARED, "gpio-cascade",
mpc8xxx_gc);
if (ret) {
dev_err(&pdev->dev, "%s: failed to devm_request_irq(%d), ret = %d\n",
--
2.9.5
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-15 8:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-11 10:28 [PATCH] gpio: mpc8xxx: change the gpio interrupt flags Hui Song
2020-06-15 8:14 ` Bartosz Golaszewski
-- strict thread matches above, loose matches on Subject: below --
2020-06-09 9:37 Hui Song
2020-06-09 19:51 ` Leo Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).