* [PATCH] media: exynos4-is: Fix a reference count leak due to pm_runtime_get_sync
@ 2020-06-14 3:10 wu000273
0 siblings, 0 replies; only message in thread
From: wu000273 @ 2020-06-14 3:10 UTC (permalink / raw)
To: kjlu
Cc: linux-samsung-soc, wu000273, linux-kernel, Krzysztof Kozlowski,
Kyungmin Park, Kukjin Kim, Sylwester Nawrocki,
Mauro Carvalho Chehab, linux-arm-kernel, linux-media
From: Qiushi Wu <wu000273@umn.edu>
On calling pm_runtime_get_sync() the reference count of the device
is incremented. In case of failure, decrement the
reference count before returning the error.
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
---
drivers/media/platform/exynos4-is/media-dev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c
index 9aaf3b8060d5..cfb6891180b0 100644
--- a/drivers/media/platform/exynos4-is/media-dev.c
+++ b/drivers/media/platform/exynos4-is/media-dev.c
@@ -484,8 +484,10 @@ static int fimc_md_register_sensor_entities(struct fimc_md *fmd)
return -ENXIO;
ret = pm_runtime_get_sync(fmd->pmf);
- if (ret < 0)
+ if (ret < 0) {
+ pm_runtime_put(fmd->pmf);
return ret;
+ }
fmd->num_sensors = 0;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-06-14 3:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-14 3:10 [PATCH] media: exynos4-is: Fix a reference count leak due to pm_runtime_get_sync wu000273
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).