From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Sumit Gupta <sumitg@nvidia.com>
Cc: devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
viresh.kumar@linaro.org, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
jonathanh@nvidia.com, talho@nvidia.com, thierry.reding@gmail.com,
bbasu@nvidia.com, catalin.marinas@arm.com,
linux-tegra@vger.kernel.org, mperttunen@nvidia.com,
will@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [TEGRA194_CPUFREQ PATCH v4 1/4] dt-bindings: arm: Add t194 ccplex compatible and bpmp property
Date: Fri, 26 Jun 2020 18:04:19 +0200 [thread overview]
Message-ID: <20200626160419.GA9302@qmqm.qmqm.pl> (raw)
In-Reply-To: <1593186236-12760-2-git-send-email-sumitg@nvidia.com>
On Fri, Jun 26, 2020 at 09:13:53PM +0530, Sumit Gupta wrote:
> To do frequency scaling on all CPUs within T194 CPU Complex, we need
> to query BPMP for data on valid operating points. Document a compatible
> string under 'cpus' node to represent the CPU Complex for binding drivers
> like cpufreq which don't have their node or CPU Complex node to bind to.
> Also, document a property to point to the BPMP device that can be queried
> for all CPUs.
>
> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> ---
> Documentation/devicetree/bindings/arm/cpus.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
> index a018147..737b55e 100644
> --- a/Documentation/devicetree/bindings/arm/cpus.yaml
> +++ b/Documentation/devicetree/bindings/arm/cpus.yaml
> @@ -162,6 +162,7 @@ properties:
> - nvidia,tegra132-denver
> - nvidia,tegra186-denver
> - nvidia,tegra194-carmel
> + - nvidia,tegra194-ccplex
> - qcom,krait
> - qcom,kryo
> - qcom,kryo260
> @@ -255,6 +256,14 @@ properties:
>
> where voltage is in V, frequency is in MHz.
>
> + nvidia,bpmp:
> + $ref: '/schemas/types.yaml#/definitions/phandle'
> + descrption: |
> + Specifies the bpmp node that needs to be queried to get
> + operating point data for all CPUs.
> +
> + Optional for NVIDIA Tegra194 Carmel CPUs
Hi,
The code (next patches) suggests, that the property is relevant for Tegra194
only. If it is required for compatible=tegra194-ccplex, then maybe you can
mark it so (there is already similar constraint described in the file, just
before the example section).
Best Regards,
Michał Mirosław
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-26 16:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 15:43 [TEGRA194_CPUFREQ PATCH v4 0/4] Add cpufreq driver for Tegra194 Sumit Gupta
2020-06-26 15:43 ` [TEGRA194_CPUFREQ PATCH v4 1/4] dt-bindings: arm: Add t194 ccplex compatible and bpmp property Sumit Gupta
2020-06-26 16:04 ` Michał Mirosław [this message]
2020-06-29 22:06 ` Rob Herring
2020-06-26 15:43 ` [TEGRA194_CPUFREQ PATCH v4 2/4] arm64: tegra: " Sumit Gupta
2020-06-26 15:43 ` [TEGRA194_CPUFREQ PATCH v4 3/4] cpufreq: Add Tegra194 cpufreq driver Sumit Gupta
2020-06-29 6:16 ` Viresh Kumar
2020-07-13 14:29 ` Sumit Gupta
2020-06-26 15:43 ` [TEGRA194_CPUFREQ PATCH v4 4/4] arm64: defconfig: Enable CONFIG_ARM_TEGRA194_CPUFREQ Sumit Gupta
2020-06-29 6:17 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200626160419.GA9302@qmqm.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=bbasu@nvidia.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sumitg@nvidia.com \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).