From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Cc: devicetree@vger.kernel.org,
Masami Hiramatsu <masami.hiramatsu@linaro.org>,
Jassi Brar <jaswinder.singh@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Rob Herring <robh+dt@kernel.org>, Marc Zyngier <maz@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 6/6] PCI: uniphier: Use devm_platform_ioremap_resource_byname()
Date: Fri, 10 Jul 2020 14:29:50 +0100 [thread overview]
Message-ID: <20200710132950.GA5540@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <f7138d4c-be56-5519-fbb2-3c655945f5ff@socionext.com>
On Fri, Jul 10, 2020 at 09:54:12AM +0900, Kunihiko Hayashi wrote:
> Hi Lorenzo,
>
> This 6/6 patch has just been covered with the following patch:
> https://patchwork.ozlabs.org/project/linux-pci/patch/20200708164013.5076-1-zhengdejin5@gmail.com/
>
> As a result, my other patches conflict with this patch.
> I'd like your comments in the patch 2/6, though,
> should I rebase to pci/dwc and resend this series without 6/6?
No, don't worry about patch (6). I will review patch (2) shortly.
Thanks,
Lorenzo
> Thank you,
>
> On 2020/06/18 17:38, Kunihiko Hayashi wrote:
> > Use devm_platform_ioremap_resource_byname() to simplify the code a bit.
> >
> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>f
> > ---
> > drivers/pci/controller/dwc/pcie-uniphier.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-uniphier.c b/drivers/pci/controller/dwc/pcie-uniphier.c
> > index 8356dd3..233d624 100644
> > --- a/drivers/pci/controller/dwc/pcie-uniphier.c
> > +++ b/drivers/pci/controller/dwc/pcie-uniphier.c
> > @@ -456,8 +456,7 @@ static int uniphier_pcie_probe(struct platform_device *pdev)
> > if (IS_ERR(priv->pci.atu_base))
> > priv->pci.atu_base = NULL;
> > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "link");
> > - priv->base = devm_ioremap_resource(dev, res);
> > + priv->base = devm_platform_ioremap_resource_byname(pdev, "link");
> > if (IS_ERR(priv->base))
> > return PTR_ERR(priv->base);
> >
>
> ---
> Best Regards
> Kunihiko Hayashi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-07-10 13:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 8:38 [PATCH v5 0/6] PCI: uniphier: Add features for UniPhier PCIe host controller Kunihiko Hayashi
2020-06-18 8:38 ` [PATCH v5 1/6] PCI: dwc: Add msi_host_isr() callback Kunihiko Hayashi
2020-06-18 8:38 ` [PATCH v5 2/6] PCI: uniphier: Add misc interrupt handler to invoke PME and AER Kunihiko Hayashi
2020-06-27 9:48 ` Marc Zyngier
2020-06-29 9:49 ` Kunihiko Hayashi
2020-06-30 13:23 ` Marc Zyngier
2020-07-01 2:18 ` Kunihiko Hayashi
2020-07-10 16:14 ` Lorenzo Pieralisi
2020-07-14 9:27 ` Kunihiko Hayashi
2020-07-14 13:27 ` Lorenzo Pieralisi
2020-07-15 10:04 ` Kunihiko Hayashi
2020-08-07 10:12 ` Kunihiko Hayashi
2020-06-18 8:38 ` [PATCH v5 3/6] dt-bindings: PCI: uniphier: Add iATU register description Kunihiko Hayashi
2020-06-18 8:38 ` [PATCH v5 4/6] PCI: uniphier: Add iATU register support Kunihiko Hayashi
2020-06-18 8:38 ` [PATCH v5 5/6] PCI: uniphier: Add error message when failed to get phy Kunihiko Hayashi
2020-06-18 8:38 ` [PATCH v5 6/6] PCI: uniphier: Use devm_platform_ioremap_resource_byname() Kunihiko Hayashi
2020-07-10 0:54 ` Kunihiko Hayashi
2020-07-10 13:29 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710132950.GA5540@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=jaswinder.singh@linaro.org \
--cc=jingoohan1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=masami.hiramatsu@linaro.org \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).