From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Andrew-sh.Cheng" <andrew-sh.cheng@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Nishanth Menon <nm@ti.com>,
srv_heupstream@mediatek.com, linux-pm@vger.kernel.org,
Stephen Boyd <sboyd@kernel.org>, Mark Brown <broonie@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org,
Chanwoo Choi <cw00.choi@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v7 2/8] cpufreq: mediatek: Enable clock and regulator
Date: Mon, 13 Jul 2020 15:09:09 +0530 [thread overview]
Message-ID: <20200713093909.676v7wxjzsz4vbxv@vireshk-i7> (raw)
In-Reply-To: <1594348284-14199-3-git-send-email-andrew-sh.cheng@mediatek.com>
On 10-07-20, 10:31, Andrew-sh.Cheng wrote:
> From: "Andrew-sh.Cheng" <andrew-sh.cheng@mediatek.com>
>
> Need to enable regulator,
> so that the max/min requested value will be recorded
> even it is not applied right away.
>
> Intermediate clock is not always enabled by ccf in different projects,
> so cpufreq should enable it by itself.
>
> Change-Id: I9f4c8b1ea793794f5f9cdc65427daad1393f5df8
You are on V7 right now, these should have been gone long back.
> Signed-off-by: Andrew-sh.Cheng <andrew-sh.cheng@mediatek.com>
> ---
> drivers/cpufreq/mediatek-cpufreq.c | 33 +++++++++++++++++++++++++++++----
> 1 file changed, 29 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
> index 0c98dd08273d..4b479c110cc9 100644
> --- a/drivers/cpufreq/mediatek-cpufreq.c
> +++ b/drivers/cpufreq/mediatek-cpufreq.c
> @@ -350,6 +350,11 @@ static int mtk_cpu_dvfs_info_init(struct mtk_cpu_dvfs_info *info, int cpu)
> ret = PTR_ERR(proc_reg);
> goto out_free_resources;
> }
> + ret = regulator_enable(proc_reg);
> + if (ret) {
> + pr_warn("enable vproc for cpu%d fail\n", cpu);
> + goto out_free_resources;
> + }
This is already done by the OPP core now.
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-13 9:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 2:31 [PATCH v7 0/8] Add cpufreq and cci devfreq for mt8183, and SVS support Andrew-sh.Cheng
2020-07-10 2:31 ` [PATCH v7 1/8] PM / devfreq: Add cpu based scaling support to passive_governor Andrew-sh.Cheng
2020-07-10 2:31 ` [PATCH v7 2/8] cpufreq: mediatek: Enable clock and regulator Andrew-sh.Cheng
2020-07-13 9:39 ` Viresh Kumar [this message]
2020-07-14 13:18 ` andrew-sh.cheng
2020-07-15 3:38 ` Viresh Kumar
2020-07-10 2:31 ` [PATCH v7 3/8] dt-bindings: devfreq: add compatible for mt8183 cci devfreq Andrew-sh.Cheng
2020-07-10 2:31 ` [PATCH v7 4/8] devfreq: add mediatek " Andrew-sh.Cheng
2020-07-10 6:43 ` andrew-sh.cheng
2020-07-10 2:31 ` [PATCH v7 5/8] opp: Modify opp API, dev_pm_opp_get_freq(), find freq in opp, even it is disabled Andrew-sh.Cheng
2020-07-13 9:42 ` Viresh Kumar
2020-07-16 11:28 ` andrew-sh.cheng
2020-07-10 2:31 ` [PATCH v7 6/8] cpufreq: mediatek: add opp notification for SVS support Andrew-sh.Cheng
2020-07-10 2:31 ` [PATCH v7 7/8] devfreq: mediatek: cci devfreq register " Andrew-sh.Cheng
2020-07-10 2:31 ` [PATCH v7 8/8] arm64: dts: mediatek: add cpufreq and cci devfreq nodes for mt8183 Andrew-sh.Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713093909.676v7wxjzsz4vbxv@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=andrew-sh.cheng@mediatek.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).