* RE: [PATCH v2 02/29] soc: Add Realtek DHC chip info driver for RTD1195 and RTD1295
[not found] ` <20200623025106.31273-3-afaerber@suse.de>
@ 2020-07-10 7:55 ` Stanley Chang[昌育德]
0 siblings, 0 replies; 19+ messages in thread
From: Stanley Chang[昌育德] @ 2020-07-10 7:55 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc
Cc: James Tai [戴志峰],
linux-kernel, linux-arm-kernel,
Edgar Lee [李承諭]
Hi Andreas,
I have reviewed this patch and tested in my local platforms (RTD1319/RTD1619/RTD1395).
And this patch is fine and it can work.
> -----Original Message-----
> From: Andreas Färber [mailto:afaerber@suse.de]
> Sent: Tuesday, June 23, 2020 10:51 AM
> To: linux-realtek-soc@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; James
> Tai [戴志峰]; Stanley Chang[昌育德]; Edgar Lee [李承諭]; Andreas Färber
> Subject: [PATCH v2 02/29] soc: Add Realtek DHC chip info driver for RTD1195
> and RTD1295
>
> Add a soc bus driver to print chip model and revision details.
>
> Revisions from downstream drivers/soc/realtek/rtd{119x,129x}/rtk_chip.c.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> v1 -> v2:
> * Added entry to MAINTAINERS
> * Changed chip_id and chip_rev from u32 to u16, based on reg field
> definitions
> * Added error return path for get_name for deferred probing, reordered
> code
>
> MAINTAINERS | 1 +
> drivers/soc/Kconfig | 1 +
> drivers/soc/Makefile | 1 +
> drivers/soc/realtek/Kconfig | 13 +++
> drivers/soc/realtek/Makefile | 2 +
> drivers/soc/realtek/chip.c | 181
> +++++++++++++++++++++++++++++++++++
> 6 files changed, 199 insertions(+)
Tested-by: Stanley Chang <stanley_chang@realtek.com>
Reviewed-by: Stanley Chang <stanley_chang@realtek.com>
Thanks,
Stanley
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v2 03/29] arm64: dts: realtek: rtd129x: Add chip info node
[not found] ` <20200623025106.31273-4-afaerber@suse.de>
@ 2020-07-10 7:56 ` Stanley Chang[昌育德]
0 siblings, 0 replies; 19+ messages in thread
From: Stanley Chang[昌育德] @ 2020-07-10 7:56 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc
Cc: devicetree, James Tai [戴志峰],
Edgar Lee [李承諭],
linux-kernel, Rob Herring, linux-arm-kernel
Hi Andreas,
> -----Original Message-----
> From: Andreas Färber [mailto:afaerber@suse.de]
> Sent: Tuesday, June 23, 2020 10:51 AM
> To: linux-realtek-soc@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; James
> Tai [戴志峰]; Stanley Chang[昌育德]; Edgar Lee [李承諭]; Andreas Färber;
> Rob Herring; devicetree@vger.kernel.org
> Subject: [PATCH v2 03/29] arm64: dts: realtek: rtd129x: Add chip info node
>
> Add a DT node for chip identification.
>
> Acked-by: James Tai <james.tai@realtek.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
Reviewed-by: Stanley Chang <stanley_chang@realtek.com>
Thanks,
Stanley
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v2 04/29] ARM: dts: rtd1195: Add chip info node
[not found] ` <20200623025106.31273-5-afaerber@suse.de>
@ 2020-07-10 7:57 ` Stanley Chang[昌育德]
0 siblings, 0 replies; 19+ messages in thread
From: Stanley Chang[昌育德] @ 2020-07-10 7:57 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc
Cc: devicetree, James Tai [戴志峰],
Edgar Lee [李承諭],
linux-kernel, Rob Herring, linux-arm-kernel
Hi Andreas,
> -----Original Message-----
> From: Andreas Färber [mailto:afaerber@suse.de]
> Sent: Tuesday, June 23, 2020 10:51 AM
> To: linux-realtek-soc@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; James
> Tai [戴志峰]; Stanley Chang[昌育德]; Edgar Lee [李承諭]; Andreas Färber;
> Rob Herring; devicetree@vger.kernel.org
> Subject: [PATCH v2 04/29] ARM: dts: rtd1195: Add chip info node
>
> Add a DT node for chip identification.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Reviewed-by: Stanley Chang <stanley_chang@realtek.com>
Thanks,
Stanley
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v2 06/29] soc: realtek: chip: Detect RTD1296
[not found] ` <20200623025106.31273-7-afaerber@suse.de>
@ 2020-07-10 7:58 ` Stanley Chang[昌育德]
0 siblings, 0 replies; 19+ messages in thread
From: Stanley Chang[昌育德] @ 2020-07-10 7:58 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc
Cc: James Tai [戴志峰],
linux-kernel, linux-arm-kernel,
Edgar Lee [李承諭]
Hi Andreas,
I have reviewed this patch and it is ok.
> -----Original Message-----
> From: Andreas Färber [mailto:afaerber@suse.de]
> Sent: Tuesday, June 23, 2020 10:51 AM
> To: linux-realtek-soc@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; James
> Tai [戴志峰]; Stanley Chang[昌育德]; Edgar Lee [李承諭]; Andreas Färber
> Subject: [PATCH v2 06/29] soc: realtek: chip: Detect RTD1296
>
> Detection logic from downstream drivers/soc/realtek/rtd129x/rtk_chip.c.
>
> Acked-by: James Tai <james.tai@realtek.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Reviewed-by: Stanley Chang <stanley_chang@realtek.com>
Thanks,
Stanley
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v2 07/29] arm64: dts: realtek: rtd129x: Extend chip-info reg with CHIP_INFO1
[not found] ` <20200623025106.31273-8-afaerber@suse.de>
@ 2020-07-10 7:59 ` Stanley Chang[昌育德]
0 siblings, 0 replies; 19+ messages in thread
From: Stanley Chang[昌育德] @ 2020-07-10 7:59 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc
Cc: devicetree, James Tai [戴志峰],
Edgar Lee [李承諭],
linux-kernel, Rob Herring, linux-arm-kernel
Hi Andreas,
> -----Original Message-----
> From: Andreas Färber [mailto:afaerber@suse.de]
> Sent: Tuesday, June 23, 2020 10:51 AM
> To: linux-realtek-soc@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; James
> Tai [戴志峰]; Stanley Chang[昌育德]; Edgar Lee [李承諭]; Andreas Färber;
> Rob Herring; devicetree@vger.kernel.org
> Subject: [PATCH v2 07/29] arm64: dts: realtek: rtd129x: Extend chip-info reg
> with CHIP_INFO1
>
> This additional register is needed to distinguish RTD1296 from RTD1295.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Reviewed-by: Stanley Chang <stanley_chang@realtek.com>
Thanks,
Stanley
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v2 09/29] soc: realtek: chip: Add RTD1395 info
[not found] ` <20200623025106.31273-10-afaerber@suse.de>
@ 2020-07-10 8:01 ` Stanley Chang[昌育德]
0 siblings, 0 replies; 19+ messages in thread
From: Stanley Chang[昌育德] @ 2020-07-10 8:01 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc
Cc: James Tai [戴志峰],
linux-kernel, linux-arm-kernel,
Edgar Lee [李承諭]
Hi Andreas,
This patch is ok in my platform.
> -----Original Message-----
> From: Andreas Färber [mailto:afaerber@suse.de]
> Sent: Tuesday, June 23, 2020 10:51 AM
> To: linux-realtek-soc@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; James
> Tai [戴志峰]; Stanley Chang[昌育德]; Edgar Lee [李承諭]; Andreas Färber
> Subject: [PATCH v2 09/29] soc: realtek: chip: Add RTD1395 info
>
> Chip ID from BPi-M4.
> Revisions based on downstream drivers/soc/realtek/rtd139x/rtk_chip.c.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Tested-by: Stanley Chang <stanley_chang@realtek.com>
Reviewed-by: Stanley Chang <stanley_chang@realtek.com>
Thanks,
Stanley
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v2 11/29] soc: realtek: chip: Add RTD1619 info
[not found] ` <20200623025106.31273-12-afaerber@suse.de>
@ 2020-07-10 8:02 ` Stanley Chang[昌育德]
0 siblings, 0 replies; 19+ messages in thread
From: Stanley Chang[昌育德] @ 2020-07-10 8:02 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc
Cc: James Tai [戴志峰],
linux-kernel, linux-arm-kernel,
Edgar Lee [李承諭]
> -----Original Message-----
> From: Andreas Färber [mailto:afaerber@suse.de]
> Sent: Tuesday, June 23, 2020 10:51 AM
> To: linux-realtek-soc@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; James
> Tai [戴志峰]; Stanley Chang[昌育德]; Edgar Lee [李承諭]; Andreas Färber
> Subject: [PATCH v2 11/29] soc: realtek: chip: Add RTD1619 info
>
> Revisions based on downstream drivers/soc/realtek/rtd16xx/rtk_chip.c.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Tested-by: Stanley Chang <stanley_chang@realtek.com>
Reviewed-by: Stanley Chang <stanley_chang@realtek.com>
Thanks,
Stanley
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v2 12/29] arm64: dts: realtek: rtd16xx: Add chip info node
[not found] ` <20200623025106.31273-13-afaerber@suse.de>
@ 2020-07-10 8:02 ` Stanley Chang[昌育德]
0 siblings, 0 replies; 19+ messages in thread
From: Stanley Chang[昌育德] @ 2020-07-10 8:02 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc
Cc: devicetree, James Tai [戴志峰],
Edgar Lee [李承諭],
linux-kernel, Rob Herring, linux-arm-kernel
Hi Andreas,
> -----Original Message-----
> From: Andreas Färber [mailto:afaerber@suse.de]
> Sent: Tuesday, June 23, 2020 10:51 AM
> To: linux-realtek-soc@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; James
> Tai [戴志峰]; Stanley Chang[昌育德]; Edgar Lee [李承諭]; Andreas Färber;
> Rob Herring; devicetree@vger.kernel.org
> Subject: [PATCH v2 12/29] arm64: dts: realtek: rtd16xx: Add chip info node
>
> Add a DT node for chip identification.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Tested-by: Stanley Chang <stanley_chang@realtek.com>
Reviewed-by: Stanley Chang <stanley_chang@realtek.com>
Thanks,
Stanley
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v2 10/29] arm64: dts: realtek: rtd139x: Add chip info node
[not found] ` <20200623025106.31273-11-afaerber@suse.de>
@ 2020-07-10 8:03 ` Stanley Chang[昌育德]
0 siblings, 0 replies; 19+ messages in thread
From: Stanley Chang[昌育德] @ 2020-07-10 8:03 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc
Cc: devicetree, James Tai [戴志峰],
Edgar Lee [李承諭],
linux-kernel, Rob Herring, linux-arm-kernel
Hi Andreas,
> -----Original Message-----
> From: Andreas Färber [mailto:afaerber@suse.de]
> Sent: Tuesday, June 23, 2020 10:51 AM
> To: linux-realtek-soc@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; James
> Tai [戴志峰]; Stanley Chang[昌育德]; Edgar Lee [李承諭]; Andreas Färber;
> Rob Herring; devicetree@vger.kernel.org
> Subject: [PATCH v2 10/29] arm64: dts: realtek: rtd139x: Add chip info node
>
> Add a DT node for chip identification.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Tested-by: Stanley Chang <stanley_chang@realtek.com>
Reviewed-by: Stanley Chang <stanley_chang@realtek.com>
Thanks,
Stanley
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v2 13/29] soc: realtek: chip: Add RTD1319 info
[not found] ` <20200623025106.31273-14-afaerber@suse.de>
@ 2020-07-10 8:04 ` Stanley Chang[昌育德]
0 siblings, 0 replies; 19+ messages in thread
From: Stanley Chang[昌育德] @ 2020-07-10 8:04 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc
Cc: James Tai [戴志峰],
linux-kernel, linux-arm-kernel,
Edgar Lee [李承諭]
Hi Andreas,
I have tested this patch, it is okay
> -----Original Message-----
> From: Andreas Färber [mailto:afaerber@suse.de]
> Sent: Tuesday, June 23, 2020 10:51 AM
> To: linux-realtek-soc@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; James
> Tai [戴志峰]; Stanley Chang[昌育德]; Edgar Lee [李承諭]; Andreas Färber
> Subject: [PATCH v2 13/29] soc: realtek: chip: Add RTD1319 info
>
> Revision based on downstream drivers/soc/realtek/rtd13xx/rtk_chip.c.
>
> Signed-off-by: Stanley Chang <stanley_chang@realtek.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Tested-by: Stanley Chang <stanley_chang@realtek.com>
Reviewed-by: Stanley Chang <stanley_chang@realtek.com>
Thanks,
Stanley
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v2 14/29] soc: realtek: chip: Add RTD1319 revisions
[not found] ` <20200623025106.31273-15-afaerber@suse.de>
@ 2020-07-10 8:04 ` Stanley Chang[昌育德]
0 siblings, 0 replies; 19+ messages in thread
From: Stanley Chang[昌育德] @ 2020-07-10 8:04 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc
Cc: James Tai [戴志峰],
linux-kernel, linux-arm-kernel,
Edgar Lee [李承諭]
Hi Andreas,
> -----Original Message-----
> From: Andreas Färber [mailto:afaerber@suse.de]
> Sent: Tuesday, June 23, 2020 10:51 AM
> To: linux-realtek-soc@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; James
> Tai [戴志峰]; Stanley Chang[昌育德]; Edgar Lee [李承諭]; Andreas Färber
> Subject: [PATCH v2 14/29] soc: realtek: chip: Add RTD1319 revisions
>
> From: Stanley Chang <stanley_chang@realtek.com>
>
> Identify RTD1319 SoC revisions B00 to B02.
>
> Signed-off-by: Stanley Chang <stanley_chang@realtek.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Tested-by: Stanley Chang <stanley_chang@realtek.com>
Reviewed-by: Stanley Chang <stanley_chang@realtek.com>
Thanks,
Stanley
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v2 16/29] soc: realtek: chip: Detect RTD1392
[not found] ` <20200623025106.31273-17-afaerber@suse.de>
@ 2020-07-10 8:05 ` Stanley Chang[昌育德]
0 siblings, 0 replies; 19+ messages in thread
From: Stanley Chang[昌育德] @ 2020-07-10 8:05 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc
Cc: James Tai [戴志峰],
linux-kernel, linux-arm-kernel,
Edgar Lee [李承諭]
Hi Andreas,
> -----Original Message-----
> From: Andreas Färber [mailto:afaerber@suse.de]
> Sent: Tuesday, June 23, 2020 10:51 AM
> To: linux-realtek-soc@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; James
> Tai [戴志峰]; Stanley Chang[昌育德]; Edgar Lee [李承諭]; Andreas Färber
> Subject: [PATCH v2 16/29] soc: realtek: chip: Detect RTD1392
>
> From: Stanley Chang <stanley_chang@realtek.com>
>
> Distinguish RTD1392 from RTD1395 via ISO_CHIP_INFO1 register.
>
> Signed-off-by: Stanley Chang <stanley_chang@realtek.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Reviewed-by: Stanley Chang <stanley_chang@realtek.com>
Thanks,
Stanley
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v2 15/29] arm64: dts: realtek: rtd13xx: Add chip info node
[not found] ` <20200623025106.31273-16-afaerber@suse.de>
@ 2020-07-10 8:06 ` Stanley Chang[昌育德]
0 siblings, 0 replies; 19+ messages in thread
From: Stanley Chang[昌育德] @ 2020-07-10 8:06 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc
Cc: devicetree, James Tai [戴志峰],
Edgar Lee [李承諭],
linux-kernel, Rob Herring, linux-arm-kernel
Tested-by: Stanley Chang <stanley_chang@realtek.com>
Reviewed-by: Stanley Chang <stanley_chang@realtek.com>
Thanks,
Stanley
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v2 26/29] soc: realtek: chip: Detect RTD1294
[not found] ` <20200623025106.31273-27-afaerber@suse.de>
@ 2020-07-10 8:07 ` Stanley Chang[昌育德]
0 siblings, 0 replies; 19+ messages in thread
From: Stanley Chang[昌育德] @ 2020-07-10 8:07 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc
Cc: James Tai [戴志峰],
linux-kernel, linux-arm-kernel,
Edgar Lee [李承諭]
Reviewed-by: Stanley Chang <stanley_chang@realtek.com>
Thanks,
Stanley
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 01/29] dt-bindings: soc: Add Realtek RTD1195 chip info binding
[not found] ` <20200623025106.31273-2-afaerber@suse.de>
@ 2020-07-14 2:13 ` Rob Herring
0 siblings, 0 replies; 19+ messages in thread
From: Rob Herring @ 2020-07-14 2:13 UTC (permalink / raw)
To: Andreas Färber
Cc: devicetree, James Tai [戴志峰],
Edgar Lee, linux-realtek-soc, linux-kernel, Rob Herring,
Stanley Chang [昌育德],
linux-arm-kernel
On Tue, 23 Jun 2020 04:50:38 +0200, Andreas Färber wrote:
> Define a binding for RTD1195 and later DHC SoCs' chip info registers.
> Add the new directory to MAINTAINERS.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> Note: The binding gets extended compatibly twice with additional properties.
> Could be squashed later if approved.
>
> v1 -> v2:
> * Dropped quotes for compatible (Rob)
> * Added additionalProperties: false (Rob)
>
> .../soc/realtek/realtek,rtd1195-chip.yaml | 34 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 05/29] dt-bindings: soc: realtek: rtd1195-chip: Add iso-syscon property
[not found] ` <20200623025106.31273-6-afaerber@suse.de>
@ 2020-07-14 2:13 ` Rob Herring
0 siblings, 0 replies; 19+ messages in thread
From: Rob Herring @ 2020-07-14 2:13 UTC (permalink / raw)
To: Andreas Färber
Cc: devicetree, James Tai [戴志峰],
Edgar Lee, linux-realtek-soc, linux-kernel,
Stanley Chang [昌育德],
linux-arm-kernel
On Tue, Jun 23, 2020 at 04:50:42AM +0200, Andreas Färber wrote:
> Allow to optionally specify a phandle to iso syscon to identify the chip.
> RTD1295 family will want to check the ISO_CHIP_INFO1 register.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> A SoC specific binding would defeat the purpose of the generic Linux driver
> detecting the SoC based on registers.
> Simply allowing it all for SoC families seems the most flexible.
>
> v1 -> v2:
> * Instead of extending reg, allow optional iso-syscon property for RTD129x.
> Iso syscon currently does not have a compatible, and it may need to differ
> across SoC families.
>
> .../bindings/soc/realtek/realtek,rtd1195-chip.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml b/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
> index 86a1de214782..dfe33c95f68d 100644
> --- a/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
> +++ b/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
> @@ -11,6 +11,7 @@ maintainers:
>
> description: |
> The Realtek DHC SoCs have some registers to identify the chip and revision.
> + To identify the exact model within a family, further registers are needed.
>
> properties:
> compatible:
> @@ -19,6 +20,8 @@ properties:
> reg:
> maxItems: 1
>
> + iso-syscon: true
Needs a type $ref (phandle).
> +
> required:
> - compatible
> - reg
> @@ -31,4 +34,10 @@ examples:
> compatible = "realtek,rtd1195-chip";
> reg = <0x1801a200 0x8>;
> };
> + - |
> + chip-info@9801a200 {
> + compatible = "realtek,rtd1195-chip";
> + reg = <0x9801a200 0x8>;
> + iso-syscon = <&iso>;
> + };
> ...
> --
> 2.26.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 17/29] dt-bindings: nvmem: Add Realtek RTD1195 eFuse
[not found] ` <20200623025106.31273-18-afaerber@suse.de>
@ 2020-07-14 2:15 ` Rob Herring
0 siblings, 0 replies; 19+ messages in thread
From: Rob Herring @ 2020-07-14 2:15 UTC (permalink / raw)
To: Andreas Färber
Cc: devicetree, James Tai [戴志峰],
Edgar Lee, linux-realtek-soc, linux-kernel, Rob Herring,
Srinivas Kandagatla, Stanley Chang [昌育德],
linux-arm-kernel
On Tue, 23 Jun 2020 04:50:54 +0200, Andreas Färber wrote:
> Add a DT binding for eFuse on Realtek Digital Home Center SoCs.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> v2: New
>
> .../bindings/nvmem/realtek,rtd1195-efuse.yaml | 53 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 54 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/nvmem/realtek,rtd1195-efuse.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 24/29] dt-bindings: soc: realtek: rtd1195-chip: Allow nvmem-cells property
[not found] ` <20200623025106.31273-25-afaerber@suse.de>
@ 2020-07-14 2:15 ` Rob Herring
0 siblings, 0 replies; 19+ messages in thread
From: Rob Herring @ 2020-07-14 2:15 UTC (permalink / raw)
To: Andreas Färber
Cc: devicetree, James Tai [戴志峰],
Edgar Lee, linux-realtek-soc, linux-kernel, Rob Herring,
Stanley Chang [昌育德],
linux-arm-kernel
On Tue, 23 Jun 2020 04:51:01 +0200, Andreas Färber wrote:
> Allow to optionally specify nvmem cells to identify the chip.
> RTD1295 family will want the eFuse package_id cell.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> v1 -> v2:
> * Instead of extending reg, allow nvmem-cells reference for eFuse
>
> .../bindings/soc/realtek/realtek,rtd1195-chip.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 18/29] nvmem: Add Realtek DHC eFuse driver
[not found] ` <20200623025106.31273-19-afaerber@suse.de>
@ 2020-07-20 9:31 ` Srinivas Kandagatla
0 siblings, 0 replies; 19+ messages in thread
From: Srinivas Kandagatla @ 2020-07-20 9:31 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc
Cc: Stanley Chang [昌育德],
James Tai [戴志峰],
linux-kernel, linux-arm-kernel, Edgar Lee
On 23/06/2020 03:50, Andreas Färber wrote:
> Implement enough of a read-only nvmem driver to easily read efuse cells.
>
> Cc: Cheng-Yu Lee <cylee12@realtek.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
If you are expecting this to be applied, then please resend this patch
splitting the MAINTAINER File changes separately!
--srini
> ---
> v2: New
>
> MAINTAINERS | 1 +
> drivers/nvmem/Kconfig | 9 ++++
> drivers/nvmem/Makefile | 2 +
> drivers/nvmem/rtk-dhc-efuse.c | 86 +++++++++++++++++++++++++++++++++++
> 4 files changed, 98 insertions(+)
> create mode 100644 drivers/nvmem/rtk-dhc-efuse.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1d0d6ab20451..02117fbf0e57 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2312,6 +2312,7 @@ F: Documentation/devicetree/bindings/soc/realtek/
> F: arch/arm/boot/dts/rtd*
> F: arch/arm/mach-realtek/
> F: arch/arm64/boot/dts/realtek/
> +F: drivers/nvmem/rtk-dhc-efuse.c
> F: drivers/soc/realtek/
>
> ARM/RENESAS ARM64 ARCHITECTURE
> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
> index d7b7f6d688e7..75cf43b16cf9 100644
> --- a/drivers/nvmem/Kconfig
> +++ b/drivers/nvmem/Kconfig
> @@ -129,6 +129,15 @@ config NVMEM_SPMI_SDAM
> Qualcomm Technologies, Inc. PMICs. It provides the clients
> an interface to read/write to the SDAM module's shared memory.
>
> +config REALTEK_DHC_EFUSE
> + tristate "Realtek DHC eFuse Support"
> + depends on ARCH_REALTEK || COMPILE_TEST
> + depends on HAS_IOMEM
> + help
> + Say y here to enable read-only access to the Realtek Digital Home
> + This driver can also be built as a module. If so, the module
> + will be called nvmem-rtk-dhc-efuse.
> +
> config ROCKCHIP_EFUSE
> tristate "Rockchip eFuse Support"
> depends on ARCH_ROCKCHIP || COMPILE_TEST
> diff --git a/drivers/nvmem/Makefile b/drivers/nvmem/Makefile
> index a7c377218341..67cefdfa44e6 100644
> --- a/drivers/nvmem/Makefile
> +++ b/drivers/nvmem/Makefile
> @@ -33,6 +33,8 @@ obj-$(CONFIG_ROCKCHIP_EFUSE) += nvmem_rockchip_efuse.o
> nvmem_rockchip_efuse-y := rockchip-efuse.o
> obj-$(CONFIG_ROCKCHIP_OTP) += nvmem-rockchip-otp.o
> nvmem-rockchip-otp-y := rockchip-otp.o
> +obj-$(CONFIG_REALTEK_DHC_EFUSE) += nvmem-rtk-dhc-efuse.o
> +nvmem-rtk-dhc-efuse-y := rtk-dhc-efuse.o
> obj-$(CONFIG_NVMEM_SUNXI_SID) += nvmem_sunxi_sid.o
> nvmem_stm32_romem-y := stm32-romem.o
> obj-$(CONFIG_NVMEM_STM32_ROMEM) += nvmem_stm32_romem.o
> diff --git a/drivers/nvmem/rtk-dhc-efuse.c b/drivers/nvmem/rtk-dhc-efuse.c
> new file mode 100644
> index 000000000000..4672db2c2619
> --- /dev/null
> +++ b/drivers/nvmem/rtk-dhc-efuse.c
> @@ -0,0 +1,86 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Realtek Digital Home Center eFuse
> + *
> + * Copyright (c) 2020 Andreas Färber
> + */
> +
> +#include <linux/io.h>
> +#include <linux/module.h>
> +#include <linux/nvmem-provider.h>
> +#include <linux/of.h>
> +#include <linux/of_address.h>
> +#include <linux/platform_device.h>
> +#include <linux/slab.h>
> +
> +struct dhc_efuse {
> + struct device *dev;
> + void __iomem *base;
> + struct nvmem_device *nvmem;
> +};
> +
> +static int dhc_efuse_reg_read(void *priv, unsigned int offset, void *val,
> + size_t bytes)
> +{
> + struct dhc_efuse *efuse = priv;
> + u8 *buf = val;
> +
> + while (bytes--)
> + *buf++ = readb_relaxed(efuse->base + offset++);
> +
> + return 0;
> +}
> +
> +static int dhc_efuse_probe(struct platform_device *pdev)
> +{
> + struct dhc_efuse *efuse;
> + struct nvmem_config config = {};
> + struct resource *res;
> +
> + efuse = devm_kzalloc(&pdev->dev, sizeof(*efuse), GFP_KERNEL);
> + if (!efuse)
> + return -ENOMEM;
> +
> + efuse->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> + if (IS_ERR(efuse->base))
> + return PTR_ERR(efuse->base);
> +
> + efuse->dev = &pdev->dev;
> +
> + config.dev = &pdev->dev;
> + config.name = "dhc-efuse";
> + config.owner = THIS_MODULE;
> + config.type = NVMEM_TYPE_OTP;
> + config.read_only = true,
> + config.word_size = 4;
> + config.stride = 1;
> + config.size = resource_size(res);
> + config.reg_read = dhc_efuse_reg_read;
> + config.priv = efuse;
> +
> + efuse->nvmem = devm_nvmem_register(&pdev->dev, &config);
> + if (IS_ERR(efuse->nvmem)) {
> + dev_err(&pdev->dev, "failed to register nvmem (%ld)\n",
> + PTR_ERR(efuse->nvmem));
> + return PTR_ERR(efuse->nvmem);
> + }
> +
> + return 0;
> +}
> +
> +static const struct of_device_id dhc_efuse_dt_ids[] = {
> + { .compatible = "realtek,rtd1195-efuse" },
> + { }
> +};
> +
> +static struct platform_driver dhc_efuse_driver = {
> + .probe = dhc_efuse_probe,
> + .driver = {
> + .name = "rtk-dhc-efuse",
> + .of_match_table = dhc_efuse_dt_ids,
> + },
> +};
> +module_platform_driver(dhc_efuse_driver);
> +
> +MODULE_DESCRIPTION("Realtek DHC eFuse driver");
> +MODULE_LICENSE("GPL");
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2020-07-20 9:32 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200623025106.31273-1-afaerber@suse.de>
[not found] ` <20200623025106.31273-3-afaerber@suse.de>
2020-07-10 7:55 ` [PATCH v2 02/29] soc: Add Realtek DHC chip info driver for RTD1195 and RTD1295 Stanley Chang[昌育德]
[not found] ` <20200623025106.31273-4-afaerber@suse.de>
2020-07-10 7:56 ` [PATCH v2 03/29] arm64: dts: realtek: rtd129x: Add chip info node Stanley Chang[昌育德]
[not found] ` <20200623025106.31273-5-afaerber@suse.de>
2020-07-10 7:57 ` [PATCH v2 04/29] ARM: dts: rtd1195: " Stanley Chang[昌育德]
[not found] ` <20200623025106.31273-7-afaerber@suse.de>
2020-07-10 7:58 ` [PATCH v2 06/29] soc: realtek: chip: Detect RTD1296 Stanley Chang[昌育德]
[not found] ` <20200623025106.31273-8-afaerber@suse.de>
2020-07-10 7:59 ` [PATCH v2 07/29] arm64: dts: realtek: rtd129x: Extend chip-info reg with CHIP_INFO1 Stanley Chang[昌育德]
[not found] ` <20200623025106.31273-10-afaerber@suse.de>
2020-07-10 8:01 ` [PATCH v2 09/29] soc: realtek: chip: Add RTD1395 info Stanley Chang[昌育德]
[not found] ` <20200623025106.31273-12-afaerber@suse.de>
2020-07-10 8:02 ` [PATCH v2 11/29] soc: realtek: chip: Add RTD1619 info Stanley Chang[昌育德]
[not found] ` <20200623025106.31273-13-afaerber@suse.de>
2020-07-10 8:02 ` [PATCH v2 12/29] arm64: dts: realtek: rtd16xx: Add chip info node Stanley Chang[昌育德]
[not found] ` <20200623025106.31273-11-afaerber@suse.de>
2020-07-10 8:03 ` [PATCH v2 10/29] arm64: dts: realtek: rtd139x: " Stanley Chang[昌育德]
[not found] ` <20200623025106.31273-14-afaerber@suse.de>
2020-07-10 8:04 ` [PATCH v2 13/29] soc: realtek: chip: Add RTD1319 info Stanley Chang[昌育德]
[not found] ` <20200623025106.31273-15-afaerber@suse.de>
2020-07-10 8:04 ` [PATCH v2 14/29] soc: realtek: chip: Add RTD1319 revisions Stanley Chang[昌育德]
[not found] ` <20200623025106.31273-17-afaerber@suse.de>
2020-07-10 8:05 ` [PATCH v2 16/29] soc: realtek: chip: Detect RTD1392 Stanley Chang[昌育德]
[not found] ` <20200623025106.31273-16-afaerber@suse.de>
2020-07-10 8:06 ` [PATCH v2 15/29] arm64: dts: realtek: rtd13xx: Add chip info node Stanley Chang[昌育德]
[not found] ` <20200623025106.31273-27-afaerber@suse.de>
2020-07-10 8:07 ` [PATCH v2 26/29] soc: realtek: chip: Detect RTD1294 Stanley Chang[昌育德]
[not found] ` <20200623025106.31273-2-afaerber@suse.de>
2020-07-14 2:13 ` [PATCH v2 01/29] dt-bindings: soc: Add Realtek RTD1195 chip info binding Rob Herring
[not found] ` <20200623025106.31273-6-afaerber@suse.de>
2020-07-14 2:13 ` [PATCH v2 05/29] dt-bindings: soc: realtek: rtd1195-chip: Add iso-syscon property Rob Herring
[not found] ` <20200623025106.31273-18-afaerber@suse.de>
2020-07-14 2:15 ` [PATCH v2 17/29] dt-bindings: nvmem: Add Realtek RTD1195 eFuse Rob Herring
[not found] ` <20200623025106.31273-25-afaerber@suse.de>
2020-07-14 2:15 ` [PATCH v2 24/29] dt-bindings: soc: realtek: rtd1195-chip: Allow nvmem-cells property Rob Herring
[not found] ` <20200623025106.31273-19-afaerber@suse.de>
2020-07-20 9:31 ` [PATCH v2 18/29] nvmem: Add Realtek DHC eFuse driver Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).