* [PATCH v3] net: ethernet: mtk_eth_soc: fix mtu warning
@ 2020-07-28 12:27 Frank Wunderlich
2020-07-28 14:14 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Frank Wunderlich @ 2020-07-28 12:27 UTC (permalink / raw)
To: linux-mediatek
Cc: Landen Chao, Frank Wunderlich, netdev, Sean Wang, linux-kernel,
Mark Lee, René van Dorst, John Crispin, Matthias Brugger,
Jakub Kicinski, David S. Miller, linux-arm-kernel, Felix Fietkau
From: Landen Chao <landen.chao@mediatek.com>
in recent Kernel-Versions there are warnings about incorrect MTU-Size
like these:
eth0: mtu greater than device maximum
mtk_soc_eth 1b100000.ethernet eth0: error -22 setting MTU to include DSA overhead
Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports")
Fixes: 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set the MTU")
Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack")
Signed-off-by: René van Dorst <opensource@vdorst.com>
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 85735d32ecb0..a1c45b39a230 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -2891,6 +2891,8 @@ static int mtk_add_mac(struct mtk_eth *eth, struct device_node *np)
eth->netdev[id]->irq = eth->irq[0];
eth->netdev[id]->dev.of_node = np;
+ eth->netdev[id]->max_mtu = MTK_MAX_RX_LENGTH - MTK_RX_ETH_HLEN;
+
return 0;
free_netdev:
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] net: ethernet: mtk_eth_soc: fix mtu warning
2020-07-28 12:27 [PATCH v3] net: ethernet: mtk_eth_soc: fix mtu warning Frank Wunderlich
@ 2020-07-28 14:14 ` Andrew Lunn
2020-07-28 15:53 ` Jakub Kicinski
2020-07-28 15:59 ` Russell King - ARM Linux admin
2 siblings, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2020-07-28 14:14 UTC (permalink / raw)
To: Frank Wunderlich
Cc: Landen Chao, netdev, Sean Wang, linux-kernel, David S. Miller,
René van Dorst, linux-mediatek, John Crispin,
Matthias Brugger, Jakub Kicinski, Mark Lee, linux-arm-kernel,
Felix Fietkau
On Tue, Jul 28, 2020 at 02:27:43PM +0200, Frank Wunderlich wrote:
> From: Landen Chao <landen.chao@mediatek.com>
>
> in recent Kernel-Versions there are warnings about incorrect MTU-Size
> like these:
>
> eth0: mtu greater than device maximum
> mtk_soc_eth 1b100000.ethernet eth0: error -22 setting MTU to include DSA overhead
>
> Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports")
> Fixes: 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set the MTU")
> Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack")
> Signed-off-by: René van Dorst <opensource@vdorst.com>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] net: ethernet: mtk_eth_soc: fix mtu warning
2020-07-28 12:27 [PATCH v3] net: ethernet: mtk_eth_soc: fix mtu warning Frank Wunderlich
2020-07-28 14:14 ` Andrew Lunn
@ 2020-07-28 15:53 ` Jakub Kicinski
2020-07-29 7:49 ` Landen Chao
2020-07-28 15:59 ` Russell King - ARM Linux admin
2 siblings, 1 reply; 5+ messages in thread
From: Jakub Kicinski @ 2020-07-28 15:53 UTC (permalink / raw)
To: Frank Wunderlich
Cc: Landen Chao, netdev, Sean Wang, linux-kernel, David S. Miller,
René van Dorst, linux-mediatek, John Crispin,
Matthias Brugger, Mark Lee, linux-arm-kernel, Felix Fietkau
On Tue, 28 Jul 2020 14:27:43 +0200 Frank Wunderlich wrote:
> From: Landen Chao <landen.chao@mediatek.com>
Hi gents,
if the patch is from Landen we need his sign-off on it.
> in recent Kernel-Versions there are warnings about incorrect MTU-Size
> like these:
>
> eth0: mtu greater than device maximum
> mtk_soc_eth 1b100000.ethernet eth0: error -22 setting MTU to include DSA overhead
>
> Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports")
> Fixes: 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set the MTU")
> Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack")
> Signed-off-by: René van Dorst <opensource@vdorst.com>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] net: ethernet: mtk_eth_soc: fix mtu warning
2020-07-28 12:27 [PATCH v3] net: ethernet: mtk_eth_soc: fix mtu warning Frank Wunderlich
2020-07-28 14:14 ` Andrew Lunn
2020-07-28 15:53 ` Jakub Kicinski
@ 2020-07-28 15:59 ` Russell King - ARM Linux admin
2 siblings, 0 replies; 5+ messages in thread
From: Russell King - ARM Linux admin @ 2020-07-28 15:59 UTC (permalink / raw)
To: Frank Wunderlich
Cc: Landen Chao, netdev, Sean Wang, linux-kernel, David S. Miller,
René van Dorst, linux-mediatek, John Crispin,
Matthias Brugger, Jakub Kicinski, Mark Lee, linux-arm-kernel,
Felix Fietkau
On Tue, Jul 28, 2020 at 02:27:43PM +0200, Frank Wunderlich wrote:
> From: Landen Chao <landen.chao@mediatek.com>
>
> in recent Kernel-Versions there are warnings about incorrect MTU-Size
> like these:
Can the above also be fixed for incorrect capitalisation and improper
hyphernation please?
Thanks.
>
> eth0: mtu greater than device maximum
> mtk_soc_eth 1b100000.ethernet eth0: error -22 setting MTU to include DSA overhead
>
> Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports")
> Fixes: 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set the MTU")
> Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack")
> Signed-off-by: René van Dorst <opensource@vdorst.com>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index 85735d32ecb0..a1c45b39a230 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -2891,6 +2891,8 @@ static int mtk_add_mac(struct mtk_eth *eth, struct device_node *np)
> eth->netdev[id]->irq = eth->irq[0];
> eth->netdev[id]->dev.of_node = np;
>
> + eth->netdev[id]->max_mtu = MTK_MAX_RX_LENGTH - MTK_RX_ETH_HLEN;
> +
> return 0;
>
> free_netdev:
> --
> 2.25.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] net: ethernet: mtk_eth_soc: fix mtu warning
2020-07-28 15:53 ` Jakub Kicinski
@ 2020-07-29 7:49 ` Landen Chao
0 siblings, 0 replies; 5+ messages in thread
From: Landen Chao @ 2020-07-29 7:49 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Frank Wunderlich, netdev, Sean Wang, linux-kernel,
David S. Miller, René van Dorst, linux-mediatek,
John Crispin, Matthias Brugger,
Mark-MC Lee (李明昌),
linux-arm-kernel, Felix Fietkau
Hi Frank,
If you send next version of patch, you can help to add the Signed-off
line. Thanks.
Signed-off-by: Landen Chao <landen.chao@mediatek.com>
On Tue, 2020-07-28 at 23:53 +0800, Jakub Kicinski wrote:
> On Tue, 28 Jul 2020 14:27:43 +0200 Frank Wunderlich wrote:
> > From: Landen Chao <landen.chao@mediatek.com>
>
> Hi gents,
>
> if the patch is from Landen we need his sign-off on it.
>
> > in recent Kernel-Versions there are warnings about incorrect MTU-Size
> > like these:
> >
> > eth0: mtu greater than device maximum
> > mtk_soc_eth 1b100000.ethernet eth0: error -22 setting MTU to include DSA overhead
> >
> > Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports")
> > Fixes: 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set the MTU")
> > Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack")
> > Signed-off-by: René van Dorst <opensource@vdorst.com>
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-29 7:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28 12:27 [PATCH v3] net: ethernet: mtk_eth_soc: fix mtu warning Frank Wunderlich
2020-07-28 14:14 ` Andrew Lunn
2020-07-28 15:53 ` Jakub Kicinski
2020-07-29 7:49 ` Landen Chao
2020-07-28 15:59 ` Russell King - ARM Linux admin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).