linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: at91: pm: remove unnecessary at91sam9x60_idle
@ 2020-08-04 11:56 Alexandre Belloni
  2020-08-05  8:52 ` Claudiu.Beznea
  0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Belloni @ 2020-08-04 11:56 UTC (permalink / raw)
  To: Nicolas Ferre
  Cc: Alexandre Belloni, Claudiu Beznea, linux-arm-kernel, linux-kernel

cpu_do_idle() is already the default action for arm_pm_idle, there is no
need to open code it.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
 arch/arm/mach-at91/pm.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
index 074bde64064e..19cc0d5b149b 100644
--- a/arch/arm/mach-at91/pm.c
+++ b/arch/arm/mach-at91/pm.c
@@ -557,11 +557,6 @@ static void at91rm9200_idle(void)
 	writel(AT91_PMC_PCK, soc_pm.data.pmc + AT91_PMC_SCDR);
 }
 
-static void at91sam9x60_idle(void)
-{
-	cpu_do_idle();
-}
-
 static void at91sam9_idle(void)
 {
 	writel(AT91_PMC_PCK, soc_pm.data.pmc + AT91_PMC_SCDR);
@@ -842,7 +837,7 @@ void __init sam9x60_pm_init(void)
 
 	at91_pm_modes_init();
 	at91_dt_ramc();
-	at91_pm_init(at91sam9x60_idle);
+	at91_pm_init(NULL);
 
 	soc_pm.ws_ids = sam9x60_ws_ids;
 	soc_pm.config_pmc_ws = at91_sam9x60_config_pmc_ws;
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: at91: pm: remove unnecessary at91sam9x60_idle
  2020-08-04 11:56 [PATCH] ARM: at91: pm: remove unnecessary at91sam9x60_idle Alexandre Belloni
@ 2020-08-05  8:52 ` Claudiu.Beznea
  0 siblings, 0 replies; 2+ messages in thread
From: Claudiu.Beznea @ 2020-08-05  8:52 UTC (permalink / raw)
  To: alexandre.belloni, Nicolas.Ferre; +Cc: linux-kernel, linux-arm-kernel



On 04.08.2020 14:56, Alexandre Belloni wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> cpu_do_idle() is already the default action for arm_pm_idle, there is no
> need to open code it.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>

> ---
>  arch/arm/mach-at91/pm.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> index 074bde64064e..19cc0d5b149b 100644
> --- a/arch/arm/mach-at91/pm.c
> +++ b/arch/arm/mach-at91/pm.c
> @@ -557,11 +557,6 @@ static void at91rm9200_idle(void)
>         writel(AT91_PMC_PCK, soc_pm.data.pmc + AT91_PMC_SCDR);
>  }
> 
> -static void at91sam9x60_idle(void)
> -{
> -       cpu_do_idle();
> -}
> -
>  static void at91sam9_idle(void)
>  {
>         writel(AT91_PMC_PCK, soc_pm.data.pmc + AT91_PMC_SCDR);
> @@ -842,7 +837,7 @@ void __init sam9x60_pm_init(void)
> 
>         at91_pm_modes_init();
>         at91_dt_ramc();
> -       at91_pm_init(at91sam9x60_idle);
> +       at91_pm_init(NULL);
> 
>         soc_pm.ws_ids = sam9x60_ws_ids;
>         soc_pm.config_pmc_ws = at91_sam9x60_config_pmc_ws;
> --
> 2.26.2
> 
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-05  8:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-04 11:56 [PATCH] ARM: at91: pm: remove unnecessary at91sam9x60_idle Alexandre Belloni
2020-08-05  8:52 ` Claudiu.Beznea

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).