linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] scsi: ufs-mediatek: Fix incorrect time to wait link status
@ 2020-08-09  5:57 Stanley Chu
  2020-08-10 20:58 ` Avri Altman
  2020-08-18  3:12 ` Martin K. Petersen
  0 siblings, 2 replies; 3+ messages in thread
From: Stanley Chu @ 2020-08-09  5:57 UTC (permalink / raw)
  To: linux-scsi, martin.petersen, avri.altman, alim.akhtar, jejb
  Cc: bvanassche, andy.teng, cc.chou, chun-hung.wu, kuohong.wang,
	linux-kernel, linux-mediatek, peter.wang, matthias.bgg,
	Stanley Chu, chaotian.jing, linux-arm-kernel

Fix incorrect calculation of "ms" based waiting time in
function ufs_mtk_setup_clocks().

Fixes: 9006e3986f66 ("scsi: ufs-mediatek: Do not gate clocks if auto-hibern8 is not entered yet")
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
---
 drivers/scsi/ufs/ufs-mediatek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 29cd017c1aa0..1755dd6b04ae 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -212,7 +212,7 @@ static int ufs_mtk_wait_link_state(struct ufs_hba *hba, u32 state,
 	ktime_t timeout, time_checked;
 	u32 val;
 
-	timeout = ktime_add_us(ktime_get(), ms_to_ktime(max_wait_ms));
+	timeout = ktime_add_ms(ktime_get(), max_wait_ms);
 	do {
 		time_checked = ktime_get();
 		ufshcd_writel(hba, 0x20, REG_UFS_DEBUG_SEL);
-- 
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH v1] scsi: ufs-mediatek: Fix incorrect time to wait link status
  2020-08-09  5:57 [PATCH v1] scsi: ufs-mediatek: Fix incorrect time to wait link status Stanley Chu
@ 2020-08-10 20:58 ` Avri Altman
  2020-08-18  3:12 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Avri Altman @ 2020-08-10 20:58 UTC (permalink / raw)
  To: Stanley Chu, linux-scsi, martin.petersen, alim.akhtar, jejb
  Cc: bvanassche, andy.teng, cc.chou, chun-hung.wu, kuohong.wang,
	linux-kernel, linux-mediatek, peter.wang, matthias.bgg,
	chaotian.jing, linux-arm-kernel

 
> 
> Fix incorrect calculation of "ms" based waiting time in
> function ufs_mtk_setup_clocks().
> 
> Fixes: 9006e3986f66 ("scsi: ufs-mediatek: Do not gate clocks if auto-hibern8 is
> not entered yet")
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] scsi: ufs-mediatek: Fix incorrect time to wait link status
  2020-08-09  5:57 [PATCH v1] scsi: ufs-mediatek: Fix incorrect time to wait link status Stanley Chu
  2020-08-10 20:58 ` Avri Altman
@ 2020-08-18  3:12 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-08-18  3:12 UTC (permalink / raw)
  To: linux-scsi, avri.altman, jejb, alim.akhtar, Stanley Chu
  Cc: linux-arm-kernel, bvanassche, Martin K . Petersen, andy.teng,
	cc.chou, chun-hung.wu, kuohong.wang, linux-kernel,
	linux-mediatek, peter.wang, matthias.bgg, chaotian.jing

On Sun, 9 Aug 2020 13:57:02 +0800, Stanley Chu wrote:

> Fix incorrect calculation of "ms" based waiting time in
> function ufs_mtk_setup_clocks().

Applied to 5.9/scsi-fixes, thanks!

[1/1] scsi: ufs-mediatek: Fix incorrect time to wait link status
      https://git.kernel.org/mkp/scsi/c/215d32670251

-- 
Martin K. Petersen	Oracle Linux Engineering

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-08-18  3:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-09  5:57 [PATCH v1] scsi: ufs-mediatek: Fix incorrect time to wait link status Stanley Chu
2020-08-10 20:58 ` Avri Altman
2020-08-18  3:12 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).