linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/4] dt-bindings: display: ti, am65x-dss: add missing properties to dt-schema
@ 2020-08-27  8:30 Tomi Valkeinen
  2020-08-27  8:30 ` [PATCH v2 2/4] dt-bindings: display: ti, j721e-dss: " Tomi Valkeinen
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Tomi Valkeinen @ 2020-08-27  8:30 UTC (permalink / raw)
  To: Tero Kristo, Nishanth Menon, linux-arm-kernel, devicetree
  Cc: Tomi Valkeinen, Rob Herring

Add assigned-clocks, assigned-clock-parents and dma-coherent optional
properties.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 .../devicetree/bindings/display/ti/ti,am65x-dss.yaml  | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
index 4f9185462ed3..4dc30738ee57 100644
--- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
+++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
@@ -55,6 +55,14 @@ properties:
       - const: vp1
       - const: vp2
 
+  assigned-clocks:
+    minItems: 1
+    maxItems: 3
+
+  assigned-clock-parents:
+    minItems: 1
+    maxItems: 3
+
   interrupts:
     maxItems: 1
 
@@ -62,6 +70,9 @@ properties:
     maxItems: 1
     description: phandle to the associated power domain
 
+  dma-coherent:
+    type: boolean
+
   ports:
     type: object
     description:
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v2 2/4] dt-bindings: display: ti, j721e-dss: add missing properties to dt-schema
  2020-08-27  8:30 [PATCH v2 1/4] dt-bindings: display: ti, am65x-dss: add missing properties to dt-schema Tomi Valkeinen
@ 2020-08-27  8:30 ` Tomi Valkeinen
  2020-09-09 20:24   ` Rob Herring
  2020-08-27  8:30 ` [PATCH v2 3/4] arm64: dts: ti: k3-am65: mark dss as dma-coherent Tomi Valkeinen
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 8+ messages in thread
From: Tomi Valkeinen @ 2020-08-27  8:30 UTC (permalink / raw)
  To: Tero Kristo, Nishanth Menon, linux-arm-kernel, devicetree
  Cc: Tomi Valkeinen, Rob Herring

Add assigned-clocks, assigned-clock-parents and dma-coherent optional
properties.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 .../devicetree/bindings/display/ti/ti,j721e-dss.yaml  | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml
index 173730d56334..c9a947d55fa4 100644
--- a/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml
+++ b/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml
@@ -77,6 +77,14 @@ properties:
       - const: vp3
       - const: vp4
 
+  assigned-clocks:
+    minItems: 1
+    maxItems: 5
+
+  assigned-clock-parents:
+    minItems: 1
+    maxItems: 5
+
   interrupts:
     items:
       - description: common_m DSS Master common
@@ -95,6 +103,9 @@ properties:
     maxItems: 1
     description: phandle to the associated power domain
 
+  dma-coherent:
+    type: boolean
+
   ports:
     type: object
     description:
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v2 3/4] arm64: dts: ti: k3-am65: mark dss as dma-coherent
  2020-08-27  8:30 [PATCH v2 1/4] dt-bindings: display: ti, am65x-dss: add missing properties to dt-schema Tomi Valkeinen
  2020-08-27  8:30 ` [PATCH v2 2/4] dt-bindings: display: ti, j721e-dss: " Tomi Valkeinen
@ 2020-08-27  8:30 ` Tomi Valkeinen
  2020-08-27  8:30 ` [PATCH v2 4/4] arm64: dts: ti: am654-base-board: fix clock node name Tomi Valkeinen
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: Tomi Valkeinen @ 2020-08-27  8:30 UTC (permalink / raw)
  To: Tero Kristo, Nishanth Menon, linux-arm-kernel, devicetree
  Cc: Tomi Valkeinen, Rob Herring

DSS is IO coherent on AM65, so we can mark it as such with
'dma-coherent' property in the DT file.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index 9edfae5944f7..efd3f18f4be3 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -847,6 +847,8 @@ dss: dss@04a00000 {
 
 		status = "disabled";
 
+		dma-coherent;
+
 		dss_ports: ports {
 			#address-cells = <1>;
 			#size-cells = <0>;
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v2 4/4] arm64: dts: ti: am654-base-board: fix clock node name
  2020-08-27  8:30 [PATCH v2 1/4] dt-bindings: display: ti, am65x-dss: add missing properties to dt-schema Tomi Valkeinen
  2020-08-27  8:30 ` [PATCH v2 2/4] dt-bindings: display: ti, j721e-dss: " Tomi Valkeinen
  2020-08-27  8:30 ` [PATCH v2 3/4] arm64: dts: ti: k3-am65: mark dss as dma-coherent Tomi Valkeinen
@ 2020-08-27  8:30 ` Tomi Valkeinen
  2020-09-08 13:11 ` [PATCH v2 1/4] dt-bindings: display: ti,am65x-dss: add missing properties to dt-schema Tomi Valkeinen
  2020-09-09 20:23 ` [PATCH v2 1/4] dt-bindings: display: ti, am65x-dss: " Rob Herring
  4 siblings, 0 replies; 8+ messages in thread
From: Tomi Valkeinen @ 2020-08-27  8:30 UTC (permalink / raw)
  To: Tero Kristo, Nishanth Menon, linux-arm-kernel, devicetree
  Cc: Tomi Valkeinen, Rob Herring

The fixed clock for OV5640 is named 'clock' which is a very generic name
and easily leads to conflicts. I encountered this with a similarly named
fixed-clock node in k3-am654-evm-tc358876.dtso, which then overrode the
OV5640 fixed clock, causing OV5640 not to work when tc358876 overlay had
been loaded.

Rename the node to 'fixed-clock-ov5640'.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
index 611e66207010..99b32038a453 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
@@ -55,7 +55,7 @@ sw6 {
 		};
 	};
 
-	clk_ov5640_fixed: clock {
+	clk_ov5640_fixed: fixed-clock-ov5640 {
 		compatible = "fixed-clock";
 		#clock-cells = <0>;
 		clock-frequency = <24000000>;
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 1/4] dt-bindings: display: ti,am65x-dss: add missing properties to dt-schema
  2020-08-27  8:30 [PATCH v2 1/4] dt-bindings: display: ti, am65x-dss: add missing properties to dt-schema Tomi Valkeinen
                   ` (2 preceding siblings ...)
  2020-08-27  8:30 ` [PATCH v2 4/4] arm64: dts: ti: am654-base-board: fix clock node name Tomi Valkeinen
@ 2020-09-08 13:11 ` Tomi Valkeinen
  2020-09-09 11:55   ` Nishanth Menon
  2020-09-09 20:23 ` [PATCH v2 1/4] dt-bindings: display: ti, am65x-dss: " Rob Herring
  4 siblings, 1 reply; 8+ messages in thread
From: Tomi Valkeinen @ 2020-09-08 13:11 UTC (permalink / raw)
  To: Tero Kristo, Nishanth Menon, linux-arm-kernel, devicetree; +Cc: Rob Herring

Hi Rob, Tero, Nishanth,

On 27/08/2020 11:30, Tomi Valkeinen wrote:
> Add assigned-clocks, assigned-clock-parents and dma-coherent optional
> properties.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
>  .../devicetree/bindings/display/ti/ti,am65x-dss.yaml  | 11 +++++++++++
>  1 file changed, 11 insertions(+)

Any comments to this and the rest of the series?

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 1/4] dt-bindings: display: ti,am65x-dss: add missing properties to dt-schema
  2020-09-08 13:11 ` [PATCH v2 1/4] dt-bindings: display: ti,am65x-dss: add missing properties to dt-schema Tomi Valkeinen
@ 2020-09-09 11:55   ` Nishanth Menon
  0 siblings, 0 replies; 8+ messages in thread
From: Nishanth Menon @ 2020-09-09 11:55 UTC (permalink / raw)
  To: Tomi Valkeinen; +Cc: Tero Kristo, devicetree, Rob Herring, linux-arm-kernel

On 16:11-20200908, Tomi Valkeinen wrote:
> Hi Rob, Tero, Nishanth,
> 
> On 27/08/2020 11:30, Tomi Valkeinen wrote:
> > Add assigned-clocks, assigned-clock-parents and dma-coherent optional
> > properties.
> > 
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > ---
> >  .../devicetree/bindings/display/ti/ti,am65x-dss.yaml  | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> 
> Any comments to this and the rest of the series?
> 


Looks fine to me. Once you get the bindings in to next, we can look to
get the dts in.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 1/4] dt-bindings: display: ti, am65x-dss: add missing properties to dt-schema
  2020-08-27  8:30 [PATCH v2 1/4] dt-bindings: display: ti, am65x-dss: add missing properties to dt-schema Tomi Valkeinen
                   ` (3 preceding siblings ...)
  2020-09-08 13:11 ` [PATCH v2 1/4] dt-bindings: display: ti,am65x-dss: add missing properties to dt-schema Tomi Valkeinen
@ 2020-09-09 20:23 ` Rob Herring
  4 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2020-09-09 20:23 UTC (permalink / raw)
  To: Tomi Valkeinen
  Cc: Nishanth Menon, devicetree, Rob Herring, Tero Kristo, linux-arm-kernel

On Thu, 27 Aug 2020 11:30:42 +0300, Tomi Valkeinen wrote:
> Add assigned-clocks, assigned-clock-parents and dma-coherent optional
> properties.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
>  .../devicetree/bindings/display/ti/ti,am65x-dss.yaml  | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 2/4] dt-bindings: display: ti, j721e-dss: add missing properties to dt-schema
  2020-08-27  8:30 ` [PATCH v2 2/4] dt-bindings: display: ti, j721e-dss: " Tomi Valkeinen
@ 2020-09-09 20:24   ` Rob Herring
  0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2020-09-09 20:24 UTC (permalink / raw)
  To: Tomi Valkeinen
  Cc: Nishanth Menon, devicetree, Rob Herring, Tero Kristo, linux-arm-kernel

On Thu, 27 Aug 2020 11:30:43 +0300, Tomi Valkeinen wrote:
> Add assigned-clocks, assigned-clock-parents and dma-coherent optional
> properties.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
>  .../devicetree/bindings/display/ti/ti,j721e-dss.yaml  | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-09-09 20:25 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-27  8:30 [PATCH v2 1/4] dt-bindings: display: ti, am65x-dss: add missing properties to dt-schema Tomi Valkeinen
2020-08-27  8:30 ` [PATCH v2 2/4] dt-bindings: display: ti, j721e-dss: " Tomi Valkeinen
2020-09-09 20:24   ` Rob Herring
2020-08-27  8:30 ` [PATCH v2 3/4] arm64: dts: ti: k3-am65: mark dss as dma-coherent Tomi Valkeinen
2020-08-27  8:30 ` [PATCH v2 4/4] arm64: dts: ti: am654-base-board: fix clock node name Tomi Valkeinen
2020-09-08 13:11 ` [PATCH v2 1/4] dt-bindings: display: ti,am65x-dss: add missing properties to dt-schema Tomi Valkeinen
2020-09-09 11:55   ` Nishanth Menon
2020-09-09 20:23 ` [PATCH v2 1/4] dt-bindings: display: ti, am65x-dss: " Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).