* [PATCH] cpufreq: armada-37xx: Add missing MODULE_DEVICE_TABLE
@ 2020-09-07 13:27 Pali Rohár
2020-09-07 14:38 ` Andrew Lunn
2020-09-08 5:00 ` Viresh Kumar
0 siblings, 2 replies; 3+ messages in thread
From: Pali Rohár @ 2020-09-07 13:27 UTC (permalink / raw)
To: Jason Cooper, Andrew Lunn, Gregory Clement,
Sebastian Hesselbarth, Rafael J. Wysocki, Viresh Kumar
Cc: linux-kernel, linux-arm-kernel, linux-pm
CONFIG_ARM_ARMADA_37XX_CPUFREQ is tristate option and therefore this
cpufreq driver can be compiled as a module. This patch adds missing
MODULE_DEVICE_TABLE which generates correct modalias for automatic
loading of this cpufreq driver when is compiled as an external module.
Signed-off-by: Pali Rohár <pali@kernel.org>
Fixes: 92ce45fb875d7 ("cpufreq: Add DVFS support for Armada 37xx")
---
drivers/cpufreq/armada-37xx-cpufreq.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/cpufreq/armada-37xx-cpufreq.c b/drivers/cpufreq/armada-37xx-cpufreq.c
index df1c941260d1..46f33c3a7316 100644
--- a/drivers/cpufreq/armada-37xx-cpufreq.c
+++ b/drivers/cpufreq/armada-37xx-cpufreq.c
@@ -484,6 +484,12 @@ static int __init armada37xx_cpufreq_driver_init(void)
/* late_initcall, to guarantee the driver is loaded after A37xx clock driver */
late_initcall(armada37xx_cpufreq_driver_init);
+static const struct of_device_id armada37xx_cpufreq_of_match[] = {
+ { .compatible = "marvell,armada-3700-nb-pm" },
+ { },
+};
+MODULE_DEVICE_TABLE(of, armada37xx_cpufreq_of_match);
+
MODULE_AUTHOR("Gregory CLEMENT <gregory.clement@free-electrons.com>");
MODULE_DESCRIPTION("Armada 37xx cpufreq driver");
MODULE_LICENSE("GPL");
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: armada-37xx: Add missing MODULE_DEVICE_TABLE
2020-09-07 13:27 [PATCH] cpufreq: armada-37xx: Add missing MODULE_DEVICE_TABLE Pali Rohár
@ 2020-09-07 14:38 ` Andrew Lunn
2020-09-08 5:00 ` Viresh Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2020-09-07 14:38 UTC (permalink / raw)
To: Pali Rohár
Cc: Jason Cooper, linux-pm, Viresh Kumar, Gregory Clement,
Rafael J. Wysocki, linux-kernel, linux-arm-kernel,
Sebastian Hesselbarth
On Mon, Sep 07, 2020 at 03:27:16PM +0200, Pali Rohár wrote:
> CONFIG_ARM_ARMADA_37XX_CPUFREQ is tristate option and therefore this
> cpufreq driver can be compiled as a module. This patch adds missing
> MODULE_DEVICE_TABLE which generates correct modalias for automatic
> loading of this cpufreq driver when is compiled as an external module.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Fixes: 92ce45fb875d7 ("cpufreq: Add DVFS support for Armada 37xx")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: armada-37xx: Add missing MODULE_DEVICE_TABLE
2020-09-07 13:27 [PATCH] cpufreq: armada-37xx: Add missing MODULE_DEVICE_TABLE Pali Rohár
2020-09-07 14:38 ` Andrew Lunn
@ 2020-09-08 5:00 ` Viresh Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2020-09-08 5:00 UTC (permalink / raw)
To: Pali Rohár
Cc: Andrew Lunn, Jason Cooper, linux-pm, Gregory Clement,
Rafael J. Wysocki, linux-kernel, linux-arm-kernel,
Sebastian Hesselbarth
On 07-09-20, 15:27, Pali Rohár wrote:
> CONFIG_ARM_ARMADA_37XX_CPUFREQ is tristate option and therefore this
> cpufreq driver can be compiled as a module. This patch adds missing
> MODULE_DEVICE_TABLE which generates correct modalias for automatic
> loading of this cpufreq driver when is compiled as an external module.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Fixes: 92ce45fb875d7 ("cpufreq: Add DVFS support for Armada 37xx")
> ---
> drivers/cpufreq/armada-37xx-cpufreq.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/cpufreq/armada-37xx-cpufreq.c b/drivers/cpufreq/armada-37xx-cpufreq.c
> index df1c941260d1..46f33c3a7316 100644
> --- a/drivers/cpufreq/armada-37xx-cpufreq.c
> +++ b/drivers/cpufreq/armada-37xx-cpufreq.c
> @@ -484,6 +484,12 @@ static int __init armada37xx_cpufreq_driver_init(void)
> /* late_initcall, to guarantee the driver is loaded after A37xx clock driver */
> late_initcall(armada37xx_cpufreq_driver_init);
>
> +static const struct of_device_id armada37xx_cpufreq_of_match[] = {
> + { .compatible = "marvell,armada-3700-nb-pm" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, armada37xx_cpufreq_of_match);
> +
> MODULE_AUTHOR("Gregory CLEMENT <gregory.clement@free-electrons.com>");
> MODULE_DESCRIPTION("Armada 37xx cpufreq driver");
> MODULE_LICENSE("GPL");
Applied. Thanks.
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-08 5:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-07 13:27 [PATCH] cpufreq: armada-37xx: Add missing MODULE_DEVICE_TABLE Pali Rohár
2020-09-07 14:38 ` Andrew Lunn
2020-09-08 5:00 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).