* [PATCH] arm64: dts: marvell: espressobin: Simplify v7 ethernet port labeling
@ 2020-09-08 7:30 Andre Heider
2020-09-08 7:33 ` Pali Rohár
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andre Heider @ 2020-09-08 7:30 UTC (permalink / raw)
To: Jason Cooper, Andrew Lunn, Gregory Clement,
Sebastian Hesselbarth, Rob Herring, Tomasz Maciej Nowak,
Pali Rohár
Cc: devicetree, linux-kernel, linux-arm-kernel
Now that the switch ports have a label in the .dtsi, simplify the whole
"switch0" block for the v7 dts files.
Signed-off-by: Andre Heider <a.heider@gmail.com>
---
This goes on top of Pali's patch:
"arm64: dts: marvell: espressobin: Add ethernet switch aliases"
The resulting .dtb files are the same.
.../armada-3720-espressobin-v7-emmc.dts | 18 +++++-------------
.../dts/marvell/armada-3720-espressobin-v7.dts | 18 +++++-------------
2 files changed, 10 insertions(+), 26 deletions(-)
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
index 215d2f702623..61d49d6a2a2a 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
@@ -28,20 +28,12 @@ aliases {
};
};
-&switch0 {
- ports {
- switch0port1: port@1 {
- reg = <1>;
- label = "lan1";
- phy-handle = <&switch0phy0>;
- };
+&switch0port1 {
+ label = "lan1";
+};
- switch0port3: port@3 {
- reg = <3>;
- label = "wan";
- phy-handle = <&switch0phy2>;
- };
- };
+&switch0port3 {
+ label = "wan";
};
/* U11 */
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
index b6f4af8ebafb..44dbe9a21cc7 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
@@ -27,18 +27,10 @@ aliases {
};
};
-&switch0 {
- ports {
- switch0port1: port@1 {
- reg = <1>;
- label = "lan1";
- phy-handle = <&switch0phy0>;
- };
+&switch0port1 {
+ label = "lan1";
+};
- switch0port3: port@3 {
- reg = <3>;
- label = "wan";
- phy-handle = <&switch0phy2>;
- };
- };
+&switch0port3 {
+ label = "wan";
};
--
2.28.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: marvell: espressobin: Simplify v7 ethernet port labeling
2020-09-08 7:30 [PATCH] arm64: dts: marvell: espressobin: Simplify v7 ethernet port labeling Andre Heider
@ 2020-09-08 7:33 ` Pali Rohár
2020-09-08 12:13 ` Andrew Lunn
2020-09-23 15:02 ` Gregory CLEMENT
2 siblings, 0 replies; 4+ messages in thread
From: Pali Rohár @ 2020-09-08 7:33 UTC (permalink / raw)
To: Andre Heider
Cc: Tomasz Maciej Nowak, Andrew Lunn, Jason Cooper, devicetree,
Gregory Clement, linux-kernel, Rob Herring, linux-arm-kernel,
Sebastian Hesselbarth
On Tuesday 08 September 2020 09:30:50 Andre Heider wrote:
> Now that the switch ports have a label in the .dtsi, simplify the whole
> "switch0" block for the v7 dts files.
>
> Signed-off-by: Andre Heider <a.heider@gmail.com>
Thank you, looks good!
Reviewed-by: Pali Rohár <pali@kernel.org>
> ---
>
> This goes on top of Pali's patch:
> "arm64: dts: marvell: espressobin: Add ethernet switch aliases"
>
> The resulting .dtb files are the same.
>
> .../armada-3720-espressobin-v7-emmc.dts | 18 +++++-------------
> .../dts/marvell/armada-3720-espressobin-v7.dts | 18 +++++-------------
> 2 files changed, 10 insertions(+), 26 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> index 215d2f702623..61d49d6a2a2a 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> @@ -28,20 +28,12 @@ aliases {
> };
> };
>
> -&switch0 {
> - ports {
> - switch0port1: port@1 {
> - reg = <1>;
> - label = "lan1";
> - phy-handle = <&switch0phy0>;
> - };
> +&switch0port1 {
> + label = "lan1";
> +};
>
> - switch0port3: port@3 {
> - reg = <3>;
> - label = "wan";
> - phy-handle = <&switch0phy2>;
> - };
> - };
> +&switch0port3 {
> + label = "wan";
> };
>
> /* U11 */
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> index b6f4af8ebafb..44dbe9a21cc7 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> @@ -27,18 +27,10 @@ aliases {
> };
> };
>
> -&switch0 {
> - ports {
> - switch0port1: port@1 {
> - reg = <1>;
> - label = "lan1";
> - phy-handle = <&switch0phy0>;
> - };
> +&switch0port1 {
> + label = "lan1";
> +};
>
> - switch0port3: port@3 {
> - reg = <3>;
> - label = "wan";
> - phy-handle = <&switch0phy2>;
> - };
> - };
> +&switch0port3 {
> + label = "wan";
> };
> --
> 2.28.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: marvell: espressobin: Simplify v7 ethernet port labeling
2020-09-08 7:30 [PATCH] arm64: dts: marvell: espressobin: Simplify v7 ethernet port labeling Andre Heider
2020-09-08 7:33 ` Pali Rohár
@ 2020-09-08 12:13 ` Andrew Lunn
2020-09-23 15:02 ` Gregory CLEMENT
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2020-09-08 12:13 UTC (permalink / raw)
To: Andre Heider
Cc: Tomasz Maciej Nowak, devicetree, Jason Cooper, Gregory Clement,
linux-kernel, Rob Herring, Pali Rohár, linux-arm-kernel,
Sebastian Hesselbarth
On Tue, Sep 08, 2020 at 09:30:50AM +0200, Andre Heider wrote:
> Now that the switch ports have a label in the .dtsi, simplify the whole
> "switch0" block for the v7 dts files.
>
> Signed-off-by: Andre Heider <a.heider@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: marvell: espressobin: Simplify v7 ethernet port labeling
2020-09-08 7:30 [PATCH] arm64: dts: marvell: espressobin: Simplify v7 ethernet port labeling Andre Heider
2020-09-08 7:33 ` Pali Rohár
2020-09-08 12:13 ` Andrew Lunn
@ 2020-09-23 15:02 ` Gregory CLEMENT
2 siblings, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2020-09-23 15:02 UTC (permalink / raw)
To: Andre Heider, Jason Cooper, Andrew Lunn, Sebastian Hesselbarth,
Rob Herring, Tomasz Maciej Nowak, Pali Rohár
Cc: devicetree, linux-kernel, linux-arm-kernel
Hi Andre,
> Now that the switch ports have a label in the .dtsi, simplify the whole
> "switch0" block for the v7 dts files.
>
> Signed-off-by: Andre Heider <a.heider@gmail.com>
Applied on mvebu/dt64
Thanks,
Gregory
> ---
>
> This goes on top of Pali's patch:
> "arm64: dts: marvell: espressobin: Add ethernet switch aliases"
>
> The resulting .dtb files are the same.
>
> .../armada-3720-espressobin-v7-emmc.dts | 18 +++++-------------
> .../dts/marvell/armada-3720-espressobin-v7.dts | 18 +++++-------------
> 2 files changed, 10 insertions(+), 26 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> index 215d2f702623..61d49d6a2a2a 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> @@ -28,20 +28,12 @@ aliases {
> };
> };
>
> -&switch0 {
> - ports {
> - switch0port1: port@1 {
> - reg = <1>;
> - label = "lan1";
> - phy-handle = <&switch0phy0>;
> - };
> +&switch0port1 {
> + label = "lan1";
> +};
>
> - switch0port3: port@3 {
> - reg = <3>;
> - label = "wan";
> - phy-handle = <&switch0phy2>;
> - };
> - };
> +&switch0port3 {
> + label = "wan";
> };
>
> /* U11 */
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> index b6f4af8ebafb..44dbe9a21cc7 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> @@ -27,18 +27,10 @@ aliases {
> };
> };
>
> -&switch0 {
> - ports {
> - switch0port1: port@1 {
> - reg = <1>;
> - label = "lan1";
> - phy-handle = <&switch0phy0>;
> - };
> +&switch0port1 {
> + label = "lan1";
> +};
>
> - switch0port3: port@3 {
> - reg = <3>;
> - label = "wan";
> - phy-handle = <&switch0phy2>;
> - };
> - };
> +&switch0port3 {
> + label = "wan";
> };
> --
> 2.28.0
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-23 15:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-08 7:30 [PATCH] arm64: dts: marvell: espressobin: Simplify v7 ethernet port labeling Andre Heider
2020-09-08 7:33 ` Pali Rohár
2020-09-08 12:13 ` Andrew Lunn
2020-09-23 15:02 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).