* Re: [PATCH] arm64: dts: marvell: espressobin: Get rid of duplicate serial aliases
2020-09-21 16:48 [PATCH] arm64: dts: marvell: espressobin: Get rid of duplicate serial aliases Andre Heider
@ 2020-09-21 16:53 ` Pali Rohár
2020-09-21 16:57 ` Andre Heider
2020-09-22 4:28 ` [PATCH v2] " Andre Heider
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Pali Rohár @ 2020-09-21 16:53 UTC (permalink / raw)
To: Andre Heider
Cc: Tomasz Maciej Nowak, Andrew Lunn, Jason Cooper, devicetree,
Gregory Clement, linux-kernel, Rob Herring, linux-arm-kernel,
Sebastian Hesselbarth
On Monday 21 September 2020 18:48:30 Andre Heider wrote:
> The included armada-372x.dtsi already defines these two aliases.
Where? I do not see it in that file:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-372x.dtsi
>
> Signed-off-by: Andre Heider <a.heider@gmail.com>
> ---
>
> This goes on top of Pali's patch:
> "arm64: dts: marvell: espressobin: Add ethernet switch aliases"
>
> The resulting .dtb files are the same.
>
> arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> index 0775c16e0ec8..3169a820558f 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> @@ -17,8 +17,6 @@ aliases {
> ethernet1 = &switch0port1;
> ethernet2 = &switch0port2;
> ethernet3 = &switch0port3;
> - serial0 = &uart0;
> - serial1 = &uart1;
> };
>
> chosen {
> --
> 2.28.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: marvell: espressobin: Get rid of duplicate serial aliases
2020-09-21 16:53 ` Pali Rohár
@ 2020-09-21 16:57 ` Andre Heider
2020-09-21 17:14 ` Pali Rohár
0 siblings, 1 reply; 7+ messages in thread
From: Andre Heider @ 2020-09-21 16:57 UTC (permalink / raw)
To: Pali Rohár
Cc: Tomasz Maciej Nowak, Andrew Lunn, Jason Cooper, devicetree,
Gregory Clement, linux-kernel, Rob Herring, linux-arm-kernel,
Sebastian Hesselbarth
On 21/09/2020 18:53, Pali Rohár wrote:
> On Monday 21 September 2020 18:48:30 Andre Heider wrote:
>> The included armada-372x.dtsi already defines these two aliases.
>
> Where? I do not see it in that file:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-372x.dtsi
Oh sorry, it's in armada-37xx.dtsi:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-37xx.dtsi#n20
>
>>
>> Signed-off-by: Andre Heider <a.heider@gmail.com>
>> ---
>>
>> This goes on top of Pali's patch:
>> "arm64: dts: marvell: espressobin: Add ethernet switch aliases"
>>
>> The resulting .dtb files are the same.
>>
>> arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
>> index 0775c16e0ec8..3169a820558f 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
>> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
>> @@ -17,8 +17,6 @@ aliases {
>> ethernet1 = &switch0port1;
>> ethernet2 = &switch0port2;
>> ethernet3 = &switch0port3;
>> - serial0 = &uart0;
>> - serial1 = &uart1;
>> };
>>
>> chosen {
>> --
>> 2.28.0
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: marvell: espressobin: Get rid of duplicate serial aliases
2020-09-21 16:57 ` Andre Heider
@ 2020-09-21 17:14 ` Pali Rohár
0 siblings, 0 replies; 7+ messages in thread
From: Pali Rohár @ 2020-09-21 17:14 UTC (permalink / raw)
To: Andre Heider
Cc: Tomasz Maciej Nowak, Andrew Lunn, Jason Cooper, devicetree,
Gregory Clement, linux-kernel, Rob Herring, linux-arm-kernel,
Sebastian Hesselbarth
On Monday 21 September 2020 18:57:46 Andre Heider wrote:
> On 21/09/2020 18:53, Pali Rohár wrote:
> > On Monday 21 September 2020 18:48:30 Andre Heider wrote:
> > > The included armada-372x.dtsi already defines these two aliases.
> >
> > Where? I do not see it in that file:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-372x.dtsi
>
> Oh sorry, it's in armada-37xx.dtsi:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-37xx.dtsi#n20
Ok, with fixing file in commit message you can add my:
Reviewed-by: Pali Rohár <pali@kernel.org>
> >
> > >
> > > Signed-off-by: Andre Heider <a.heider@gmail.com>
> > > ---
> > >
> > > This goes on top of Pali's patch:
> > > "arm64: dts: marvell: espressobin: Add ethernet switch aliases"
> > >
> > > The resulting .dtb files are the same.
> > >
> > > arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> > > index 0775c16e0ec8..3169a820558f 100644
> > > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> > > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> > > @@ -17,8 +17,6 @@ aliases {
> > > ethernet1 = &switch0port1;
> > > ethernet2 = &switch0port2;
> > > ethernet3 = &switch0port3;
> > > - serial0 = &uart0;
> > > - serial1 = &uart1;
> > > };
> > > chosen {
> > > --
> > > 2.28.0
> > >
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] arm64: dts: marvell: espressobin: Get rid of duplicate serial aliases
2020-09-21 16:48 [PATCH] arm64: dts: marvell: espressobin: Get rid of duplicate serial aliases Andre Heider
2020-09-21 16:53 ` Pali Rohár
@ 2020-09-22 4:28 ` Andre Heider
2020-09-22 4:31 ` [PATCH v3] " Andre Heider
2020-09-23 15:10 ` [PATCH] " Gregory CLEMENT
3 siblings, 0 replies; 7+ messages in thread
From: Andre Heider @ 2020-09-22 4:28 UTC (permalink / raw)
To: Jason Cooper, Andrew Lunn, Gregory Clement,
Sebastian Hesselbarth, Rob Herring, Tomasz Maciej Nowak,
Pali Rohár
Cc: devicetree, linux-kernel, linux-arm-kernel
The included armada-3xxx.dtsi already defines these two aliases.
Signed-off-by: Andre Heider <a.heider@gmail.com>
Reviewed-by: Pali Rohár <pali@kernel.org>
---
v2: fix filename in commit message
This goes on top of Pali's patch:
"arm64: dts: marvell: espressobin: Add ethernet switch aliases"
The resulting .dtb files are the same.
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
index 0775c16e0ec8..3169a820558f 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
@@ -17,8 +17,6 @@ aliases {
ethernet1 = &switch0port1;
ethernet2 = &switch0port2;
ethernet3 = &switch0port3;
- serial0 = &uart0;
- serial1 = &uart1;
};
chosen {
--
2.28.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v3] arm64: dts: marvell: espressobin: Get rid of duplicate serial aliases
2020-09-21 16:48 [PATCH] arm64: dts: marvell: espressobin: Get rid of duplicate serial aliases Andre Heider
2020-09-21 16:53 ` Pali Rohár
2020-09-22 4:28 ` [PATCH v2] " Andre Heider
@ 2020-09-22 4:31 ` Andre Heider
2020-09-23 15:10 ` [PATCH] " Gregory CLEMENT
3 siblings, 0 replies; 7+ messages in thread
From: Andre Heider @ 2020-09-22 4:31 UTC (permalink / raw)
To: Jason Cooper, Andrew Lunn, Gregory Clement,
Sebastian Hesselbarth, Rob Herring, Tomasz Maciej Nowak,
Pali Rohár
Cc: devicetree, linux-kernel, linux-arm-kernel
The included armada-37xx.dtsi already defines these two aliases.
Signed-off-by: Andre Heider <a.heider@gmail.com>
Reviewed-by: Pali Rohár <pali@kernel.org>
---
v3: really fix filename, sorry for the spam... too early, not enough coffee
v2: fix filename in commit message
This goes on top of Pali's patch:
"arm64: dts: marvell: espressobin: Add ethernet switch aliases"
The resulting .dtb files are the same.
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
index 0775c16e0ec8..3169a820558f 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
@@ -17,8 +17,6 @@ aliases {
ethernet1 = &switch0port1;
ethernet2 = &switch0port2;
ethernet3 = &switch0port3;
- serial0 = &uart0;
- serial1 = &uart1;
};
chosen {
--
2.28.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: marvell: espressobin: Get rid of duplicate serial aliases
2020-09-21 16:48 [PATCH] arm64: dts: marvell: espressobin: Get rid of duplicate serial aliases Andre Heider
` (2 preceding siblings ...)
2020-09-22 4:31 ` [PATCH v3] " Andre Heider
@ 2020-09-23 15:10 ` Gregory CLEMENT
3 siblings, 0 replies; 7+ messages in thread
From: Gregory CLEMENT @ 2020-09-23 15:10 UTC (permalink / raw)
To: Andre Heider, Jason Cooper, Andrew Lunn, Sebastian Hesselbarth,
Rob Herring, Tomasz Maciej Nowak, Pali Rohár
Cc: devicetree, linux-kernel, linux-arm-kernel
Hi Andre,
> The included armada-372x.dtsi already defines these two aliases.
>
> Signed-off-by: Andre Heider <a.heider@gmail.com>
Applied on mvebu/dt
Thanks,
Gregory
> ---
>
> This goes on top of Pali's patch:
> "arm64: dts: marvell: espressobin: Add ethernet switch aliases"
>
> The resulting .dtb files are the same.
>
> arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> index 0775c16e0ec8..3169a820558f 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> @@ -17,8 +17,6 @@ aliases {
> ethernet1 = &switch0port1;
> ethernet2 = &switch0port2;
> ethernet3 = &switch0port3;
> - serial0 = &uart0;
> - serial1 = &uart1;
> };
>
> chosen {
> --
> 2.28.0
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread