From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Sverdlin,
Alexander \(Nokia - DE/Ulm\)" <alexander.sverdlin@nokia.co>,
Rob Herring <robh+dt@kernel.org>,
Matija Glavinic Pecotic <matija.glavinic-pecotic.ext@nokia.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: Support initrd with address in boot alias region
Date: Wed, 30 Sep 2020 11:35:22 +0100 [thread overview]
Message-ID: <20200930103521.GD1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <58e39504-3970-597f-8146-5180babc6e16@gmail.com>
On Tue, Sep 29, 2020 at 10:21:35AM -0700, Florian Fainelli wrote:
> +Rob, Russell,
>
> On 9/29/2020 12:54 AM, Matija Glavinic Pecotic wrote:
> > If bootloader passes address of initrd in boot alias region, initrd
> > will fail on memblock_is_region_memory as memblock with such address
> > doesn't exist.
> >
> > Issue was observed with kexec which passed initrd address in boot alias
> > region, while bootloader will typically pass physical address. Commit
> > fe7db7570379 ("of/fdt: Populate phys_initrd_start/phys_initrd_size from FDT")
> > uncovered problem by removing virt_to_phys on the initrd physical
> > address. __virt_to_phys on our platform coincidentally fixed address.
> >
> > Fix by trying to correct address in case of invalid physical address.
> >
> > Signed-off-by: Matija Glavinic Pecotic <matija.glavinic-pecotic.ext@nokia.com>
>
> This should have a Fixes tag:
>
> fe7db7570379 ("of/fdt: Populate phys_initrd_start/phys_initrd_size from
> FDT")
>
> I am not familiar enough with how the identity map works, but it seems to do
> what you want it to.
It seems strange to pass the initrd in using an address that is not
listed as part of the system memory map, especially as the initrd is
freed during kernel initialisation.
Which boot loader is this, and is there a reason it operates this way?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-30 10:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 7:54 [PATCH] arm: Support initrd with address in boot alias region Matija Glavinic Pecotic
2020-09-29 17:21 ` Florian Fainelli
2020-09-30 10:35 ` Russell King - ARM Linux admin [this message]
2020-09-30 11:07 ` Matija Glavinic Pecotic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930103521.GD1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexander.sverdlin@nokia.co \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=matija.glavinic-pecotic.ext@nokia.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).