* [PATCH] arm64: dts imx8mn: Remove non-existent USB OTG2
@ 2020-10-08 15:19 Adam Ford
2020-10-08 17:09 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Adam Ford @ 2020-10-08 15:19 UTC (permalink / raw)
To: linux-arm-kernel
Cc: devicetree, Fabio Estevam, Anson Huang, Adam Ford, Sascha Hauer,
aford, linux-kernel, Rob Herring, NXP Linux Team,
Pengutronix Kernel Team, Shawn Guo
According to the i.MX8MN TRM, there is only one OTG port. The
address for OTG2 is reserved on Nano.
This patch removes the non-existent OTG2.
Fixes: 6c3debcbae47 ("arm64: dts: freescale: Add i.MX8MN dtsi support")
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index 746faf1cf2fb..ac206e1f2dad 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -791,21 +791,6 @@ usbmisc1: usbmisc@32e40200 {
reg = <0x32e40200 0x200>;
};
- usbotg2: usb@32e50000 {
- compatible = "fsl,imx8mn-usb", "fsl,imx7d-usb";
- reg = <0x32e50000 0x200>;
- interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clk IMX8MN_CLK_USB1_CTRL_ROOT>;
- clock-names = "usb1_ctrl_root_clk";
- assigned-clocks = <&clk IMX8MN_CLK_USB_BUS>,
- <&clk IMX8MN_CLK_USB_CORE_REF>;
- assigned-clock-parents = <&clk IMX8MN_SYS_PLL2_500M>,
- <&clk IMX8MN_SYS_PLL1_100M>;
- fsl,usbphy = <&usbphynop2>;
- fsl,usbmisc = <&usbmisc2 0>;
- status = "disabled";
- };
-
usbmisc2: usbmisc@32e50200 {
compatible = "fsl,imx8mn-usbmisc", "fsl,imx7d-usbmisc";
#index-cells = <1>;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts imx8mn: Remove non-existent USB OTG2
2020-10-08 15:19 [PATCH] arm64: dts imx8mn: Remove non-existent USB OTG2 Adam Ford
@ 2020-10-08 17:09 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-08 17:09 UTC (permalink / raw)
To: Adam Ford
Cc: devicetree, Anson Huang, Fabio Estevam, Sascha Hauer, aford,
linux-kernel, Rob Herring, NXP Linux Team,
Pengutronix Kernel Team, Shawn Guo, linux-arm-kernel
On Thu, Oct 08, 2020 at 10:19:33AM -0500, Adam Ford wrote:
> According to the i.MX8MN TRM, there is only one OTG port. The
> address for OTG2 is reserved on Nano.
>
> This patch removes the non-existent OTG2.
>
> Fixes: 6c3debcbae47 ("arm64: dts: freescale: Add i.MX8MN dtsi support")
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> index 746faf1cf2fb..ac206e1f2dad 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> @@ -791,21 +791,6 @@ usbmisc1: usbmisc@32e40200 {
> reg = <0x32e40200 0x200>;
> };
>
> - usbotg2: usb@32e50000 {
> - compatible = "fsl,imx8mn-usb", "fsl,imx7d-usb";
> - reg = <0x32e50000 0x200>;
> - interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clk IMX8MN_CLK_USB1_CTRL_ROOT>;
> - clock-names = "usb1_ctrl_root_clk";
> - assigned-clocks = <&clk IMX8MN_CLK_USB_BUS>,
> - <&clk IMX8MN_CLK_USB_CORE_REF>;
> - assigned-clock-parents = <&clk IMX8MN_SYS_PLL2_500M>,
> - <&clk IMX8MN_SYS_PLL1_100M>;
> - fsl,usbphy = <&usbphynop2>;
> - fsl,usbmisc = <&usbmisc2 0>;
> - status = "disabled";
> - };
> -
> usbmisc2: usbmisc@32e50200 {
> compatible = "fsl,imx8mn-usbmisc", "fsl,imx7d-usbmisc";
> #index-cells = <1>;
Good catch but please also remove usbmisc2 and the usbphy nodes.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-08 17:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-08 15:19 [PATCH] arm64: dts imx8mn: Remove non-existent USB OTG2 Adam Ford
2020-10-08 17:09 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).