From: Sudeep Holla <sudeep.holla@arm.com>
To: Etienne Carriere <etienne.carriere@linaro.org>
Cc: Souvik Chakravarty <Souvik.Chakravarty@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sudeep Holla <sudeep.holla@arm.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Cristian Marussi <cristian.marussi@arm.com>
Subject: Re: [PATCH 1/5] firmware: arm_scmi: always initialize protocols
Date: Thu, 8 Oct 2020 20:17:27 +0100 [thread overview]
Message-ID: <20201008191727.ht26r5dnh3iwqj5n@bogus> (raw)
In-Reply-To: <20201008143722.21888-1-etienne.carriere@linaro.org>
On Thu, Oct 08, 2020 at 04:37:18PM +0200, Etienne Carriere wrote:
> Remove the IDR replacement that prevent initializing an SCMI protocol
> when it has already been initialized. This is needed when there are
> several SCMI agents that do implement a given SCMI protocol unless
> what only the related SCMI protocol communication is initialized only
> for first probed agent.
>
Can you please elaborate on your usecase please. What do you mean by several
SCMI agents here. OSPM is the only agent we are interested here. What
other agents is this driver supposed to handle here. We allocate memory
in init and calling init multiple times messes up the allocated and
initialised structures.
So NACK for this patch as it needs more work if we need this at all.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-08 19:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 14:37 [PATCH 1/5] firmware: arm_scmi: always initialize protocols Etienne Carriere
2020-10-08 14:37 ` [PATCH 2/5] firmware: arm_scmi: fix transfer missing re-initialization Etienne Carriere
2020-10-08 21:18 ` Sudeep Holla
2020-10-09 12:38 ` Etienne Carriere
2020-10-09 15:20 ` Sudeep Holla
2020-10-12 14:17 ` [PATCH] firmware: arm_scmi: Add missing Rx size re-initialisation Sudeep Holla
2020-10-13 9:58 ` Etienne Carriere
2020-10-13 10:16 ` Sudeep Holla
2020-10-13 10:50 ` Sudeep Holla
2020-10-08 14:37 ` [PATCH 3/5] firmware: arm_scmi: add config dependency for smc transport Etienne Carriere
2020-10-08 21:08 ` Sudeep Holla
2020-10-09 12:33 ` Etienne Carriere
2020-10-09 15:58 ` Sudeep Holla
2020-10-12 10:11 ` Etienne Carriere
2020-10-08 14:37 ` [PATCH 4/5] firmware: arm_scmi: smc transport supports multi-message pool Etienne Carriere
2020-10-08 21:11 ` Sudeep Holla
2020-10-09 12:43 ` Etienne Carriere
2020-10-09 15:17 ` Sudeep Holla
2020-10-12 8:57 ` Sudeep Holla
2020-10-12 9:12 ` Etienne Carriere
2020-10-08 14:37 ` [PATCH 5/5] firmware: arm_scmi: fix ARCH_COLD_RESET Etienne Carriere
2020-10-08 21:16 ` Sudeep Holla
2020-10-08 19:17 ` Sudeep Holla [this message]
2020-10-09 12:31 ` [PATCH 1/5] firmware: arm_scmi: always initialize protocols Etienne Carriere
2020-10-09 16:31 ` Cristian Marussi
2020-10-12 9:32 ` Sudeep Holla
2020-10-13 10:45 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008191727.ht26r5dnh3iwqj5n@bogus \
--to=sudeep.holla@arm.com \
--cc=Souvik.Chakravarty@arm.com \
--cc=cristian.marussi@arm.com \
--cc=etienne.carriere@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).