* [PATCH] arm64: Fix a broken copyright header in gen_vdso_offsets.sh
@ 2020-10-17 0:26 Palmer Dabbelt
2020-10-20 11:32 ` Will Deacon
2020-10-20 17:57 ` Will Deacon
0 siblings, 2 replies; 4+ messages in thread
From: Palmer Dabbelt @ 2020-10-17 0:26 UTC (permalink / raw)
To: Will Deacon
Cc: kernel-team, nickhu, catalin.marinas, Palmer Dabbelt,
linux-kernel, green.hu, deanbo422, will, linux-arm-kernel
From: Palmer Dabbelt <palmerdabbelt@google.com>
I was going to copy this but I didn't want to chase around the build
system stuff so I did it a different way.
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
---
arch/arm64/kernel/vdso/gen_vdso_offsets.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/vdso/gen_vdso_offsets.sh b/arch/arm64/kernel/vdso/gen_vdso_offsets.sh
index 0664acaf61ff..8b806eacd0a6 100755
--- a/arch/arm64/kernel/vdso/gen_vdso_offsets.sh
+++ b/arch/arm64/kernel/vdso/gen_vdso_offsets.sh
@@ -8,7 +8,7 @@
# Doing this inside the Makefile will break the $(filter-out) function,
# causing Kbuild to rebuild the vdso-offsets header file every time.
#
-# Author: Will Deacon <will.deacon@arm.com
+# Author: Will Deacon <will.deacon@arm.com>
#
LC_ALL=C
--
2.29.0.rc1.297.gfa9743e501-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: Fix a broken copyright header in gen_vdso_offsets.sh
2020-10-17 0:26 [PATCH] arm64: Fix a broken copyright header in gen_vdso_offsets.sh Palmer Dabbelt
@ 2020-10-20 11:32 ` Will Deacon
2020-11-06 2:48 ` Palmer Dabbelt
2020-10-20 17:57 ` Will Deacon
1 sibling, 1 reply; 4+ messages in thread
From: Will Deacon @ 2020-10-20 11:32 UTC (permalink / raw)
To: Palmer Dabbelt
Cc: nickhu, Will Deacon, catalin.marinas, Palmer Dabbelt,
linux-kernel, green.hu, deanbo422, kernel-team, linux-arm-kernel
On Fri, Oct 16, 2020 at 05:26:37PM -0700, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmerdabbelt@google.com>
>
> I was going to copy this but I didn't want to chase around the build
> system stuff so I did it a different way.
How did you end up doing it? I remember trying to parse the ELF object at
one time of day and not getting very far.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: Fix a broken copyright header in gen_vdso_offsets.sh
2020-10-17 0:26 [PATCH] arm64: Fix a broken copyright header in gen_vdso_offsets.sh Palmer Dabbelt
2020-10-20 11:32 ` Will Deacon
@ 2020-10-20 17:57 ` Will Deacon
1 sibling, 0 replies; 4+ messages in thread
From: Will Deacon @ 2020-10-20 17:57 UTC (permalink / raw)
To: Will Deacon, Palmer Dabbelt
Cc: nickhu, catalin.marinas, Palmer Dabbelt, linux-kernel,
Will Deacon, green.hu, deanbo422, kernel-team, linux-arm-kernel
On Fri, 16 Oct 2020 17:26:37 -0700, Palmer Dabbelt wrote:
> I was going to copy this but I didn't want to chase around the build
> system stuff so I did it a different way.
Applied to arm64 (for-next/core), thanks!
[1/1] arm64: Fix a broken copyright header in gen_vdso_offsets.sh
https://git.kernel.org/arm64/c/7bdf468a5b40
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: Fix a broken copyright header in gen_vdso_offsets.sh
2020-10-20 11:32 ` Will Deacon
@ 2020-11-06 2:48 ` Palmer Dabbelt
0 siblings, 0 replies; 4+ messages in thread
From: Palmer Dabbelt @ 2020-11-06 2:48 UTC (permalink / raw)
To: will
Cc: nickhu, Will Deacon, catalin.marinas, linux-kernel, green.hu,
deanbo422, kernel-team, linux-arm-kernel
On Tue, 20 Oct 2020 04:32:08 PDT (-0700), will@kernel.org wrote:
> On Fri, Oct 16, 2020 at 05:26:37PM -0700, Palmer Dabbelt wrote:
>> From: Palmer Dabbelt <palmerdabbelt@google.com>
>>
>> I was going to copy this but I didn't want to chase around the build
>> system stuff so I did it a different way.
>
> How did you end up doing it? I remember trying to parse the ELF object at
> one time of day and not getting very far.
Mine really isn't any cleaner: I use nm and sed to produce an assembler file
full of absolute symbols, which I compile to produce the object. That way I
don't need a header file, which means I don't need to mess around with build
ordering or change any of the other code (which was already using symbols).
I don't really like this whole thing we do where we just assume that symbols
with a small offset from absolute address zero. We're sort of depending on
that for undefined weak symbols, but that's only for actually zero not almost
zero. Given that, I figured it'd be easier to just do it this way rather than
trying to mess with build stuff.
I probably wouldn't bother changing unless there's something actively bad about
that build stuff (I didn't really look).
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-06 2:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-17 0:26 [PATCH] arm64: Fix a broken copyright header in gen_vdso_offsets.sh Palmer Dabbelt
2020-10-20 11:32 ` Will Deacon
2020-11-06 2:48 ` Palmer Dabbelt
2020-10-20 17:57 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).