linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: vf610-zii-dev-rev-b: Fix MDIO over clocking
@ 2020-10-30  0:55 Andrew Lunn
  2020-10-30 15:46 ` Chris Healy
  2020-11-01  9:29 ` Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Andrew Lunn @ 2020-10-30  0:55 UTC (permalink / raw)
  To: Shawn Guo; +Cc: Andrew Lunn, Chris Healy, linux ARM

The ZII devel B board has two generations of Marvell Switches.  The
mv88e6352 supports an MDIO clock of 12MHz. However the older 88e6185
does not like 12MHz, and often fails to probe.

Reduce the clock speed to 5MHz, which seems to work reliably.

Cc: Chris Healy <cphealy@gmail.com>
Fixes: b955387667ec ("ARM: dts: ZII: update MDIO speed and preamble")
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
 arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
index e500911ce0a5..6f1e0f0d4f0a 100644
--- a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
+++ b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
@@ -406,6 +406,9 @@ i2c@4 {
 	};
 };
 
+&mdio1 {
+	clock-frequency = <5000000>;
+};
 
 &iomuxc {
 	pinctrl_gpio_e6185_eeprom_sel: pinctrl-gpio-e6185-eeprom-spi0 {
-- 
2.28.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: Fix MDIO over clocking
  2020-10-30  0:55 [PATCH] ARM: dts: vf610-zii-dev-rev-b: Fix MDIO over clocking Andrew Lunn
@ 2020-10-30 15:46 ` Chris Healy
  2020-11-01  9:29 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Chris Healy @ 2020-10-30 15:46 UTC (permalink / raw)
  To: Andrew Lunn; +Cc: Shawn Guo, linux ARM

Reviewed-by: Chris Healy <cphealy@gmail.com>

On Thu, Oct 29, 2020 at 5:55 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> The ZII devel B board has two generations of Marvell Switches.  The
> mv88e6352 supports an MDIO clock of 12MHz. However the older 88e6185
> does not like 12MHz, and often fails to probe.
>
> Reduce the clock speed to 5MHz, which seems to work reliably.
>
> Cc: Chris Healy <cphealy@gmail.com>
> Fixes: b955387667ec ("ARM: dts: ZII: update MDIO speed and preamble")
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
>  arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
> index e500911ce0a5..6f1e0f0d4f0a 100644
> --- a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
> +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
> @@ -406,6 +406,9 @@ i2c@4 {
>         };
>  };
>
> +&mdio1 {
> +       clock-frequency = <5000000>;
> +};
>
>  &iomuxc {
>         pinctrl_gpio_e6185_eeprom_sel: pinctrl-gpio-e6185-eeprom-spi0 {
> --
> 2.28.0
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: Fix MDIO over clocking
  2020-10-30  0:55 [PATCH] ARM: dts: vf610-zii-dev-rev-b: Fix MDIO over clocking Andrew Lunn
  2020-10-30 15:46 ` Chris Healy
@ 2020-11-01  9:29 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2020-11-01  9:29 UTC (permalink / raw)
  To: Andrew Lunn; +Cc: Chris Healy, linux ARM

On Fri, Oct 30, 2020 at 01:55:28AM +0100, Andrew Lunn wrote:
> The ZII devel B board has two generations of Marvell Switches.  The
> mv88e6352 supports an MDIO clock of 12MHz. However the older 88e6185
> does not like 12MHz, and often fails to probe.
> 
> Reduce the clock speed to 5MHz, which seems to work reliably.
> 
> Cc: Chris Healy <cphealy@gmail.com>
> Fixes: b955387667ec ("ARM: dts: ZII: update MDIO speed and preamble")
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>

Applied, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-01  9:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-30  0:55 [PATCH] ARM: dts: vf610-zii-dev-rev-b: Fix MDIO over clocking Andrew Lunn
2020-10-30 15:46 ` Chris Healy
2020-11-01  9:29 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).