* [PATCH] ARM: dts: stm32: Add DHCOM based PicoITX board
@ 2020-11-03 18:11 Marek Vasut
2020-11-04 10:53 ` [Linux-stm32] " Ahmad Fatoum
2020-11-17 11:32 ` Alexandre Torgue
0 siblings, 2 replies; 7+ messages in thread
From: Marek Vasut @ 2020-11-03 18:11 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Marek Vasut, Alexandre Torgue, Patrice Chotard, Patrick Delaunay,
Maxime Coquelin, linux-stm32
Add DT for DH PicoITX unit, which is a bare-bones carrier board for
the DHCOM. The board has ethernet port, USB, CAN, LEDs and a custom
board-to-board expansion connector.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
Cc: linux-stm32@st-md-mailman.stormreply.com
To: linux-arm-kernel@lists.infradead.org
---
arch/arm/boot/dts/Makefile | 1 +
.../boot/dts/stm32mp157c-dhcom-picoitx.dts | 35 +++++
.../boot/dts/stm32mp15xx-dhcom-picoitx.dtsi | 143 ++++++++++++++++++
3 files changed, 179 insertions(+)
create mode 100644 arch/arm/boot/dts/stm32mp157c-dhcom-picoitx.dts
create mode 100644 arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index db0223cf47da..36ec449a8b4e 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -1066,6 +1066,7 @@ dtb-$(CONFIG_ARCH_STM32) += \
stm32mp157a-iot-box.dtb \
stm32mp157a-stinger96.dtb \
stm32mp157c-dhcom-pdk2.dtb \
+ stm32mp157c-dhcom-picoitx.dtb \
stm32mp157c-dk2.dtb \
stm32mp157c-ed1.dtb \
stm32mp157c-ev1.dtb \
diff --git a/arch/arm/boot/dts/stm32mp157c-dhcom-picoitx.dts b/arch/arm/boot/dts/stm32mp157c-dhcom-picoitx.dts
new file mode 100644
index 000000000000..cfb8f8a0c82d
--- /dev/null
+++ b/arch/arm/boot/dts/stm32mp157c-dhcom-picoitx.dts
@@ -0,0 +1,35 @@
+// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause
+/*
+ * Copyright (C) 2020 Marek Vasut <marex@denx.de>
+ *
+ * DHCOM STM32MP1 variant:
+ * DHCM-STM32MP157C-C065-R102-F0819-SPI-E-CAN2-SD-RTC-T-DSI-I-01D2
+ * DHCOM PCB number: 587-200 or newer
+ * PicoITX PCB number: 487-600 or newer
+ */
+/dts-v1/;
+
+#include "stm32mp157.dtsi"
+#include "stm32mp15xc.dtsi"
+#include "stm32mp15xx-dhcom-som.dtsi"
+#include "stm32mp15xx-dhcom-picoitx.dtsi"
+
+/ {
+ model = "DH electronics STM32MP157C DHCOM PicoITX";
+ compatible = "dh,stm32mp157c-dhcom-picoitx", "dh,stm32mp157c-dhcom-som",
+ "st,stm32mp157";
+};
+
+&m_can1 {
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <&m_can1_pins_a>;
+ pinctrl-1 = <&m_can1_sleep_pins_a>;
+ status = "okay";
+};
+
+&m_can2 {
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <&m_can2_pins_a>;
+ pinctrl-1 = <&m_can2_sleep_pins_a>;
+ status = "okay";
+};
diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
new file mode 100644
index 000000000000..356150d28c42
--- /dev/null
+++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
@@ -0,0 +1,143 @@
+// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause
+/*
+ * Copyright (C) 2020 Marek Vasut <marex@denx.de>
+ */
+
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/pwm/pwm.h>
+
+/ {
+ aliases {
+ serial0 = &uart4;
+ serial1 = &usart3;
+ serial2 = &uart8;
+ };
+
+ chosen {
+ stdout-path = "serial0:115200n8";
+ };
+
+ led {
+ compatible = "gpio-leds";
+
+ led-0 {
+ label = "yellow:led";
+ gpios = <&gpioi 3 GPIO_ACTIVE_HIGH>;
+ default-state = "off";
+ };
+ };
+};
+
+&adc {
+ status = "disabled";
+};
+
+&dac {
+ status = "disabled";
+};
+
+&gpioa {
+ /*
+ * NOTE: The USB Port on the PicoITX needs a PWR_EN signal to enable
+ * port power. This signal should be handled by USB power sequencing
+ * in order to turn on port power when USB bus is powered up, but so
+ * far there is no such functionality.
+ */
+ usb-port-power {
+ gpio-hog;
+ gpios = <13 GPIO_ACTIVE_LOW>;
+ output-low;
+ line-name = "usb-port-power";
+ };
+};
+
+&gpioc {
+ gpio-line-names = "", "", "", "",
+ "", "", "In1", "",
+ "", "", "", "",
+ "", "", "", "";
+};
+
+&gpiod {
+ gpio-line-names = "", "", "", "",
+ "", "", "", "",
+ "", "", "", "Out1",
+ "Out2", "", "", "";
+};
+
+&gpiog {
+ gpio-line-names = "In2", "", "", "",
+ "", "", "", "",
+ "", "", "", "",
+ "", "", "", "";
+};
+
+&i2c2 { /* On board-to-board connector (optional) */
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c2_pins_a>;
+ i2c-scl-rising-time-ns = <185>;
+ i2c-scl-falling-time-ns = <20>;
+ status = "okay";
+ /* spare dmas for other usage */
+ /delete-property/dmas;
+ /delete-property/dma-names;
+};
+
+&i2c5 { /* On board-to-board connector */
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c5_pins_a>;
+ i2c-scl-rising-time-ns = <185>;
+ i2c-scl-falling-time-ns = <20>;
+ status = "okay";
+ /* spare dmas for other usage */
+ /delete-property/dmas;
+ /delete-property/dma-names;
+};
+
+&usart3 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&usart3_pins_a>;
+ status = "okay";
+};
+
+&uart8 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart8_pins_a &uart8_rtscts_pins_a>;
+ status = "okay";
+};
+
+&usbh_ehci {
+ phys = <&usbphyc_port0>;
+ status = "okay";
+};
+
+&usbh_ohci {
+ phys = <&usbphyc_port0>;
+ status = "okay";
+};
+
+&usbotg_hs {
+ dr_mode = "otg";
+ pinctrl-0 = <&usbotg_hs_pins_a>;
+ pinctrl-names = "default";
+ phy-names = "usb2-phy";
+ phys = <&usbphyc_port1 0>;
+ vbus-supply = <&vbus_otg>;
+ status = "okay";
+};
+
+&usbphyc {
+ status = "okay";
+};
+
+&usbphyc_port0 {
+ phy-supply = <&vdd_usb>;
+ vdda1v1-supply = <®11>;
+ vdda1v8-supply = <®18>;
+};
+
+&usbphyc_port1 {
+ phy-supply = <&vdd_usb>;
+ vdda1v1-supply = <®11>;
+ vdda1v8-supply = <®18>;
+};
--
2.28.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Linux-stm32] [PATCH] ARM: dts: stm32: Add DHCOM based PicoITX board
2020-11-03 18:11 [PATCH] ARM: dts: stm32: Add DHCOM based PicoITX board Marek Vasut
@ 2020-11-04 10:53 ` Ahmad Fatoum
2020-11-04 12:18 ` Marek Vasut
2020-11-17 11:32 ` Alexandre Torgue
1 sibling, 1 reply; 7+ messages in thread
From: Ahmad Fatoum @ 2020-11-04 10:53 UTC (permalink / raw)
To: Marek Vasut, linux-arm-kernel
Cc: Maxime Coquelin, Patrick Delaunay, linux-stm32
Hello Marek,
On 11/3/20 7:11 PM, Marek Vasut wrote:
> Add DT for DH PicoITX unit, which is a bare-bones carrier board for
> the DHCOM. The board has ethernet port, USB, CAN, LEDs and a custom
> board-to-board expansion connector.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: linux-stm32@st-md-mailman.stormreply.com
> To: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm/boot/dts/Makefile | 1 +
> .../boot/dts/stm32mp157c-dhcom-picoitx.dts | 35 +++++
> .../boot/dts/stm32mp15xx-dhcom-picoitx.dtsi | 143 ++++++++++++++++++
> 3 files changed, 179 insertions(+)
> create mode 100644 arch/arm/boot/dts/stm32mp157c-dhcom-picoitx.dts
> create mode 100644 arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index db0223cf47da..36ec449a8b4e 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1066,6 +1066,7 @@ dtb-$(CONFIG_ARCH_STM32) += \
> stm32mp157a-iot-box.dtb \
> stm32mp157a-stinger96.dtb \
> stm32mp157c-dhcom-pdk2.dtb \
> + stm32mp157c-dhcom-picoitx.dtb \
> stm32mp157c-dk2.dtb \
> stm32mp157c-ed1.dtb \
> stm32mp157c-ev1.dtb \
> diff --git a/arch/arm/boot/dts/stm32mp157c-dhcom-picoitx.dts b/arch/arm/boot/dts/stm32mp157c-dhcom-picoitx.dts
> new file mode 100644
> index 000000000000..cfb8f8a0c82d
> --- /dev/null
> +++ b/arch/arm/boot/dts/stm32mp157c-dhcom-picoitx.dts
> @@ -0,0 +1,35 @@
> +// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause
> +/*
> + * Copyright (C) 2020 Marek Vasut <marex@denx.de>
> + *
> + * DHCOM STM32MP1 variant:
> + * DHCM-STM32MP157C-C065-R102-F0819-SPI-E-CAN2-SD-RTC-T-DSI-I-01D2
> + * DHCOM PCB number: 587-200 or newer
> + * PicoITX PCB number: 487-600 or newer
> + */
> +/dts-v1/;
> +
> +#include "stm32mp157.dtsi"
> +#include "stm32mp15xc.dtsi"
> +#include "stm32mp15xx-dhcom-som.dtsi"
> +#include "stm32mp15xx-dhcom-picoitx.dtsi"
> +
> +/ {
> + model = "DH electronics STM32MP157C DHCOM PicoITX";
> + compatible = "dh,stm32mp157c-dhcom-picoitx", "dh,stm32mp157c-dhcom-som",
> + "st,stm32mp157";
Is there a separate dt-bindings patch documenting these new compatibles?
> +};
> +
> +&m_can1 {
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&m_can1_pins_a>;
> + pinctrl-1 = <&m_can1_sleep_pins_a>;
> + status = "okay";
> +};
> +
> +&m_can2 {
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&m_can2_pins_a>;
> + pinctrl-1 = <&m_can2_sleep_pins_a>;
> + status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> new file mode 100644
> index 000000000000..356150d28c42
> --- /dev/null
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> @@ -0,0 +1,143 @@
> +// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause
> +/*
> + * Copyright (C) 2020 Marek Vasut <marex@denx.de>
> + */
> +
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/pwm/pwm.h>
> +
> +/ {
> + aliases {
> + serial0 = &uart4;
> + serial1 = &usart3;
> + serial2 = &uart8;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +
> + led {
> + compatible = "gpio-leds";
> +
> + led-0 {
> + label = "yellow:led";
> + gpios = <&gpioi 3 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> + };
> +};
> +
> +&adc {
> + status = "disabled";
> +};
> +
> +&dac {
> + status = "disabled";
> +};
> +
> +&gpioa {
> + /*
> + * NOTE: The USB Port on the PicoITX needs a PWR_EN signal to enable
> + * port power. This signal should be handled by USB power sequencing
> + * in order to turn on port power when USB bus is powered up, but so
> + * far there is no such functionality.
> + */
> + usb-port-power {
> + gpio-hog;
> + gpios = <13 GPIO_ACTIVE_LOW>;
> + output-low;
> + line-name = "usb-port-power";
> + };
> +};
> +
> +&gpioc {
> + gpio-line-names = "", "", "", "",
> + "", "", "In1", "",
> + "", "", "", "",
> + "", "", "", "";
> +};
> +
> +&gpiod {
> + gpio-line-names = "", "", "", "",
> + "", "", "", "",
> + "", "", "", "Out1",
> + "Out2", "", "", "";
> +};
> +
> +&gpiog {
> + gpio-line-names = "In2", "", "", "",
> + "", "", "", "",
> + "", "", "", "",
> + "", "", "", "";
> +};
> +
> +&i2c2 { /* On board-to-board connector (optional) */
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c2_pins_a>;
> + i2c-scl-rising-time-ns = <185>;
> + i2c-scl-falling-time-ns = <20>;
> + status = "okay";
> + /* spare dmas for other usage */
> + /delete-property/dmas;
> + /delete-property/dma-names;
> +};
> +
> +&i2c5 { /* On board-to-board connector */
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c5_pins_a>;
> + i2c-scl-rising-time-ns = <185>;
> + i2c-scl-falling-time-ns = <20>;
> + status = "okay";
> + /* spare dmas for other usage */
> + /delete-property/dmas;
> + /delete-property/dma-names;
> +};
> +
> +&usart3 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&usart3_pins_a>;
> + status = "okay";
> +};
> +
> +&uart8 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart8_pins_a &uart8_rtscts_pins_a>;
> + status = "okay";
> +};
> +
> +&usbh_ehci {
> + phys = <&usbphyc_port0>;
> + status = "okay";
> +};
> +
> +&usbh_ohci {
> + phys = <&usbphyc_port0>;
> + status = "okay";
> +};
> +
> +&usbotg_hs {
> + dr_mode = "otg";
> + pinctrl-0 = <&usbotg_hs_pins_a>;
> + pinctrl-names = "default";
> + phy-names = "usb2-phy";
> + phys = <&usbphyc_port1 0>;
> + vbus-supply = <&vbus_otg>;
> + status = "okay";
> +};
> +
> +&usbphyc {
> + status = "okay";
> +};
> +
> +&usbphyc_port0 {
> + phy-supply = <&vdd_usb>;
> + vdda1v1-supply = <®11>;
> + vdda1v8-supply = <®18>;
> +};
> +
> +&usbphyc_port1 {
> + phy-supply = <&vdd_usb>;
> + vdda1v1-supply = <®11>;
> + vdda1v8-supply = <®18>;
> +};
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Linux-stm32] [PATCH] ARM: dts: stm32: Add DHCOM based PicoITX board
2020-11-04 10:53 ` [Linux-stm32] " Ahmad Fatoum
@ 2020-11-04 12:18 ` Marek Vasut
2020-11-04 12:19 ` Ahmad Fatoum
0 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2020-11-04 12:18 UTC (permalink / raw)
To: Ahmad Fatoum, linux-arm-kernel
Cc: Maxime Coquelin, Patrick Delaunay, linux-stm32
On 11/4/20 11:53 AM, Ahmad Fatoum wrote:
> Hello Marek,
Hi,
[...]
>> +#include "stm32mp157.dtsi"
>> +#include "stm32mp15xc.dtsi"
>> +#include "stm32mp15xx-dhcom-som.dtsi"
>> +#include "stm32mp15xx-dhcom-picoitx.dtsi"
>> +
>> +/ {
>> + model = "DH electronics STM32MP157C DHCOM PicoITX";
>> + compatible = "dh,stm32mp157c-dhcom-picoitx", "dh,stm32mp157c-dhcom-som",
>> + "st,stm32mp157";
>
> Is there a separate dt-bindings patch documenting these new compatibles?
Which ones ? The dh is in vendor-prefixes.yaml .
[...]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Linux-stm32] [PATCH] ARM: dts: stm32: Add DHCOM based PicoITX board
2020-11-04 12:18 ` Marek Vasut
@ 2020-11-04 12:19 ` Ahmad Fatoum
2020-11-04 12:20 ` Ahmad Fatoum
2020-11-08 22:19 ` Marek Vasut
0 siblings, 2 replies; 7+ messages in thread
From: Ahmad Fatoum @ 2020-11-04 12:19 UTC (permalink / raw)
To: Marek Vasut, linux-arm-kernel
Cc: Maxime Coquelin, Patrick Delaunay, linux-stm32
Hello,
On 11/4/20 1:18 PM, Marek Vasut wrote:
> On 11/4/20 11:53 AM, Ahmad Fatoum wrote:
>> Hello Marek,
>
> Hi,
>
> [...]
>
>>> +#include "stm32mp157.dtsi"
>>> +#include "stm32mp15xc.dtsi"
>>> +#include "stm32mp15xx-dhcom-som.dtsi"
>>> +#include "stm32mp15xx-dhcom-picoitx.dtsi"
>>> +
>>> +/ {
>>> + model = "DH electronics STM32MP157C DHCOM PicoITX";
>>> + compatible = "dh,stm32mp157c-dhcom-picoitx", "dh,stm32mp157c-dhcom-som",
>>> + "st,stm32mp157";
>>
>> Is there a separate dt-bindings patch documenting these new compatibles?
>
> Which ones ? The dh is in vendor-prefixes.yaml .
Documentation/devicetree/bindings/arm/stm32/stm32.yaml
Should list the board compatibles in use, otherwise dt_binding_check complains.
>
> [...]
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Linux-stm32] [PATCH] ARM: dts: stm32: Add DHCOM based PicoITX board
2020-11-04 12:19 ` Ahmad Fatoum
@ 2020-11-04 12:20 ` Ahmad Fatoum
2020-11-08 22:19 ` Marek Vasut
1 sibling, 0 replies; 7+ messages in thread
From: Ahmad Fatoum @ 2020-11-04 12:20 UTC (permalink / raw)
To: Marek Vasut, linux-arm-kernel
Cc: Patrick Delaunay, Maxime Coquelin, linux-stm32
On 11/4/20 1:19 PM, Ahmad Fatoum wrote:
>>>> +#include "stm32mp157.dtsi"
>>>> +#include "stm32mp15xc.dtsi"
>>>> +#include "stm32mp15xx-dhcom-som.dtsi"
>>>> +#include "stm32mp15xx-dhcom-picoitx.dtsi"
>>>> +
>>>> +/ {
>>>> + model = "DH electronics STM32MP157C DHCOM PicoITX";
>>>> + compatible = "dh,stm32mp157c-dhcom-picoitx", "dh,stm32mp157c-dhcom-som",
>>>> + "st,stm32mp157";
>>>
>>> Is there a separate dt-bindings patch documenting these new compatibles?
>>
>> Which ones ? The dh is in vendor-prefixes.yaml .
>
> Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>
> Should list the board compatibles in use, otherwise dt_binding_check complains.
s/dt_binding_check/dtbs_check/
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Linux-stm32] [PATCH] ARM: dts: stm32: Add DHCOM based PicoITX board
2020-11-04 12:19 ` Ahmad Fatoum
2020-11-04 12:20 ` Ahmad Fatoum
@ 2020-11-08 22:19 ` Marek Vasut
1 sibling, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2020-11-08 22:19 UTC (permalink / raw)
To: Ahmad Fatoum, linux-arm-kernel
Cc: Maxime Coquelin, Patrick Delaunay, linux-stm32
On 11/4/20 1:19 PM, Ahmad Fatoum wrote:
> Hello,
Hi,
> On 11/4/20 1:18 PM, Marek Vasut wrote:
>> On 11/4/20 11:53 AM, Ahmad Fatoum wrote:
>>> Hello Marek,
>>
>> Hi,
>>
>> [...]
>>
>>>> +#include "stm32mp157.dtsi"
>>>> +#include "stm32mp15xc.dtsi"
>>>> +#include "stm32mp15xx-dhcom-som.dtsi"
>>>> +#include "stm32mp15xx-dhcom-picoitx.dtsi"
>>>> +
>>>> +/ {
>>>> + model = "DH electronics STM32MP157C DHCOM PicoITX";
>>>> + compatible = "dh,stm32mp157c-dhcom-picoitx", "dh,stm32mp157c-dhcom-som",
>>>> + "st,stm32mp157";
>>>
>>> Is there a separate dt-bindings patch documenting these new compatibles?
>>
>> Which ones ? The dh is in vendor-prefixes.yaml .
>
> Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>
> Should list the board compatibles in use, otherwise dt_binding_check complains.
I hope this [1] should fix that without colliding with [2].
[1]
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20201108221438.310406-1-marex@denx.de/
[2]
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20201104113932.30702-1-a.fatoum@pengutronix.de/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: stm32: Add DHCOM based PicoITX board
2020-11-03 18:11 [PATCH] ARM: dts: stm32: Add DHCOM based PicoITX board Marek Vasut
2020-11-04 10:53 ` [Linux-stm32] " Ahmad Fatoum
@ 2020-11-17 11:32 ` Alexandre Torgue
1 sibling, 0 replies; 7+ messages in thread
From: Alexandre Torgue @ 2020-11-17 11:32 UTC (permalink / raw)
To: Marek Vasut, linux-arm-kernel
Cc: Patrick Delaunay, Patrice Chotard, Maxime Coquelin, linux-stm32
Hi Marek,
On 11/3/20 7:11 PM, Marek Vasut wrote:
> Add DT for DH PicoITX unit, which is a bare-bones carrier board for
> the DHCOM. The board has ethernet port, USB, CAN, LEDs and a custom
> board-to-board expansion connector.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: linux-stm32@st-md-mailman.stormreply.com
> To: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm/boot/dts/Makefile | 1 +
> .../boot/dts/stm32mp157c-dhcom-picoitx.dts | 35 +++++
> .../boot/dts/stm32mp15xx-dhcom-picoitx.dtsi | 143 ++++++++++++++++++
> 3 files changed, 179 insertions(+)
> create mode 100644 arch/arm/boot/dts/stm32mp157c-dhcom-picoitx.dts
> create mode 100644 arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>
Thanks to enhance STM32 family.
Applied on stm32-next.
Thanks.
Alex
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index db0223cf47da..36ec449a8b4e 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1066,6 +1066,7 @@ dtb-$(CONFIG_ARCH_STM32) += \
> stm32mp157a-iot-box.dtb \
> stm32mp157a-stinger96.dtb \
> stm32mp157c-dhcom-pdk2.dtb \
> + stm32mp157c-dhcom-picoitx.dtb \
> stm32mp157c-dk2.dtb \
> stm32mp157c-ed1.dtb \
> stm32mp157c-ev1.dtb \
> diff --git a/arch/arm/boot/dts/stm32mp157c-dhcom-picoitx.dts b/arch/arm/boot/dts/stm32mp157c-dhcom-picoitx.dts
> new file mode 100644
> index 000000000000..cfb8f8a0c82d
> --- /dev/null
> +++ b/arch/arm/boot/dts/stm32mp157c-dhcom-picoitx.dts
> @@ -0,0 +1,35 @@
> +// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause
> +/*
> + * Copyright (C) 2020 Marek Vasut <marex@denx.de>
> + *
> + * DHCOM STM32MP1 variant:
> + * DHCM-STM32MP157C-C065-R102-F0819-SPI-E-CAN2-SD-RTC-T-DSI-I-01D2
> + * DHCOM PCB number: 587-200 or newer
> + * PicoITX PCB number: 487-600 or newer
> + */
> +/dts-v1/;
> +
> +#include "stm32mp157.dtsi"
> +#include "stm32mp15xc.dtsi"
> +#include "stm32mp15xx-dhcom-som.dtsi"
> +#include "stm32mp15xx-dhcom-picoitx.dtsi"
> +
> +/ {
> + model = "DH electronics STM32MP157C DHCOM PicoITX";
> + compatible = "dh,stm32mp157c-dhcom-picoitx", "dh,stm32mp157c-dhcom-som",
> + "st,stm32mp157";
> +};
> +
> +&m_can1 {
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&m_can1_pins_a>;
> + pinctrl-1 = <&m_can1_sleep_pins_a>;
> + status = "okay";
> +};
> +
> +&m_can2 {
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&m_can2_pins_a>;
> + pinctrl-1 = <&m_can2_sleep_pins_a>;
> + status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> new file mode 100644
> index 000000000000..356150d28c42
> --- /dev/null
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> @@ -0,0 +1,143 @@
> +// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause
> +/*
> + * Copyright (C) 2020 Marek Vasut <marex@denx.de>
> + */
> +
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/pwm/pwm.h>
> +
> +/ {
> + aliases {
> + serial0 = &uart4;
> + serial1 = &usart3;
> + serial2 = &uart8;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +
> + led {
> + compatible = "gpio-leds";
> +
> + led-0 {
> + label = "yellow:led";
> + gpios = <&gpioi 3 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> + };
> +};
> +
> +&adc {
> + status = "disabled";
> +};
> +
> +&dac {
> + status = "disabled";
> +};
> +
> +&gpioa {
> + /*
> + * NOTE: The USB Port on the PicoITX needs a PWR_EN signal to enable
> + * port power. This signal should be handled by USB power sequencing
> + * in order to turn on port power when USB bus is powered up, but so
> + * far there is no such functionality.
> + */
> + usb-port-power {
> + gpio-hog;
> + gpios = <13 GPIO_ACTIVE_LOW>;
> + output-low;
> + line-name = "usb-port-power";
> + };
> +};
> +
> +&gpioc {
> + gpio-line-names = "", "", "", "",
> + "", "", "In1", "",
> + "", "", "", "",
> + "", "", "", "";
> +};
> +
> +&gpiod {
> + gpio-line-names = "", "", "", "",
> + "", "", "", "",
> + "", "", "", "Out1",
> + "Out2", "", "", "";
> +};
> +
> +&gpiog {
> + gpio-line-names = "In2", "", "", "",
> + "", "", "", "",
> + "", "", "", "",
> + "", "", "", "";
> +};
> +
> +&i2c2 { /* On board-to-board connector (optional) */
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c2_pins_a>;
> + i2c-scl-rising-time-ns = <185>;
> + i2c-scl-falling-time-ns = <20>;
> + status = "okay";
> + /* spare dmas for other usage */
> + /delete-property/dmas;
> + /delete-property/dma-names;
> +};
> +
> +&i2c5 { /* On board-to-board connector */
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c5_pins_a>;
> + i2c-scl-rising-time-ns = <185>;
> + i2c-scl-falling-time-ns = <20>;
> + status = "okay";
> + /* spare dmas for other usage */
> + /delete-property/dmas;
> + /delete-property/dma-names;
> +};
> +
> +&usart3 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&usart3_pins_a>;
> + status = "okay";
> +};
> +
> +&uart8 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart8_pins_a &uart8_rtscts_pins_a>;
> + status = "okay";
> +};
> +
> +&usbh_ehci {
> + phys = <&usbphyc_port0>;
> + status = "okay";
> +};
> +
> +&usbh_ohci {
> + phys = <&usbphyc_port0>;
> + status = "okay";
> +};
> +
> +&usbotg_hs {
> + dr_mode = "otg";
> + pinctrl-0 = <&usbotg_hs_pins_a>;
> + pinctrl-names = "default";
> + phy-names = "usb2-phy";
> + phys = <&usbphyc_port1 0>;
> + vbus-supply = <&vbus_otg>;
> + status = "okay";
> +};
> +
> +&usbphyc {
> + status = "okay";
> +};
> +
> +&usbphyc_port0 {
> + phy-supply = <&vdd_usb>;
> + vdda1v1-supply = <®11>;
> + vdda1v8-supply = <®18>;
> +};
> +
> +&usbphyc_port1 {
> + phy-supply = <&vdd_usb>;
> + vdda1v1-supply = <®11>;
> + vdda1v8-supply = <®18>;
> +};
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-11-17 11:34 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-03 18:11 [PATCH] ARM: dts: stm32: Add DHCOM based PicoITX board Marek Vasut
2020-11-04 10:53 ` [Linux-stm32] " Ahmad Fatoum
2020-11-04 12:18 ` Marek Vasut
2020-11-04 12:19 ` Ahmad Fatoum
2020-11-04 12:20 ` Ahmad Fatoum
2020-11-08 22:19 ` Marek Vasut
2020-11-17 11:32 ` Alexandre Torgue
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).