From: Maxime Ripard <maxime@cerno.tech>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] arm64: allwinner: dts: a64: add DT for PineTab developer sample
Date: Tue, 10 Nov 2020 11:39:25 +0100 [thread overview]
Message-ID: <20201110103925.rbej5ueo2fefbmlp@gilmour.lan> (raw)
In-Reply-To: <20201107125332.2223197-1-icenowy@aosc.io>
[-- Attachment #1.1: Type: text/plain, Size: 1990 bytes --]
On Sat, Nov 07, 2020 at 08:53:32PM +0800, Icenowy Zheng wrote:
> Some developers received PineTab samples that used an old LCD panel.
>
> Add device tree for these samples.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> arch/arm64/boot/dts/allwinner/Makefile | 1 +
> .../dts/allwinner/sun50i-a64-pinetab-dev.dts | 28 +++++++++++++++++++
> 2 files changed, 29 insertions(+)
> create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab-dev.dts
>
> diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile
> index 211d1e9d4701..a221dcebfad4 100644
> --- a/arch/arm64/boot/dts/allwinner/Makefile
> +++ b/arch/arm64/boot/dts/allwinner/Makefile
> @@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.0.dtb
> dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.1.dtb
> dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.2.dtb
> dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab.dtb
> +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab-dev.dtb
> dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb
> dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb
> dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab-dev.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab-dev.dts
> new file mode 100644
> index 000000000000..3a4153890f3e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab-dev.dts
> @@ -0,0 +1,28 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (C) 2020 Icenowy Zheng <icenowy@aosc.io>
> + *
> + */
> +
> +/dts-v1/;
> +
> +#include "sun50i-a64-pinetab.dts"
> +
> +/ {
> + model = "PineTab Developer Sample";
> + compatible = "pine64,pinetab-dev", "allwinner,sun50i-a64";
> +};
Changing the DT and the compatible half-way through it isn't ok. Please
add a new DT with the newer revision like we did for the pinephone
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-10 10:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 12:49 [PATCH 0/3] Switch PineTab DT LCD panel to retail one Icenowy Zheng
2020-11-07 12:50 ` [PATCH 1/3] arm64: allwinner: dts: a64: pinetab: switch LCD panel to production one Icenowy Zheng
2020-11-07 12:52 ` [PATCH 2/3] dt-bindings: arm: sunxi: add PineTab developer sample DT binding Icenowy Zheng
2020-11-09 22:02 ` Rob Herring
2020-11-07 12:53 ` [PATCH 3/3] arm64: allwinner: dts: a64: add DT for PineTab developer sample Icenowy Zheng
2020-11-10 10:39 ` Maxime Ripard [this message]
2020-11-10 10:41 ` Icenowy Zheng
2020-11-16 15:55 ` Maxime Ripard
2020-11-16 18:36 ` [linux-sunxi] " Icenowy Zheng
2020-11-20 15:59 ` Maxime Ripard
2020-11-20 23:30 ` Icenowy Zheng
2020-11-21 2:51 ` Samuel Holland
2020-11-23 11:15 ` Maxime Ripard
2020-11-23 11:25 ` Icenowy Zheng
2020-11-23 12:53 ` Maxime Ripard
2020-11-23 13:10 ` Icenowy Zheng
2020-11-28 10:38 ` Maxime Ripard
2020-11-28 11:28 ` Icenowy Zheng
2020-11-28 11:54 ` Clément Péron
2020-11-28 11:59 ` Icenowy Zheng
2020-11-28 21:07 ` Clément Péron
2020-12-01 10:35 ` Maxime Ripard
2020-12-06 21:03 ` Clément Péron
2020-12-07 10:07 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110103925.rbej5ueo2fefbmlp@gilmour.lan \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).