* [PATCH] ARM: dts: sun7i: pcduino3-nano: enable RGMII RX/TX delay on PHY
@ 2020-11-23 17:47 Adam Sampson
2020-11-24 14:24 ` Maxime Ripard
0 siblings, 1 reply; 4+ messages in thread
From: Adam Sampson @ 2020-11-23 17:47 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec, Adam Sampson,
linux-sunxi, devicetree, linux-arm-kernel, Andrew Lunn
Cc: Chen-Yu Tsai
The RX/TX delays for the Ethernet PHY on the Linksprite pcDuino 3 Nano
are configured in hardware, using resistors that are populated to pull
the RTL8211E's RXDLY/TXDLY pins low or high as needed.
phy-mode should be set to rgmii-id to reflect this. Previously it was
set to rgmii, which used to work but now results in the delays being
disabled again as a result of the bugfix in commit bbc4d71d6354 ("net:
phy: realtek: fix rtl8211e rx/tx delay config").
Tested on two pcDuino 3 Nano boards purchased in 2015. Without this fix,
Ethernet works unreliably on one board and doesn't work at all on the
other.
Fixes: 061035d456c9 ("ARM: dts: sun7i: Add dts file for pcDuino 3 Nano board")
Signed-off-by: Adam Sampson <ats@offog.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Chen-Yu Tsai <wens@csie.org>
---
arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts b/arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts
index fce2f7fcd084..bf38c66c1815 100644
--- a/arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts
+++ b/arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts
@@ -1,5 +1,5 @@
/*
- * Copyright 2015 Adam Sampson <ats@offog.org>
+ * Copyright 2015-2020 Adam Sampson <ats@offog.org>
*
* This file is dual-licensed: you can use it either under the terms
* of the GPL or the X11 license, at your option. Note that this dual
@@ -115,7 +115,7 @@ &gmac {
pinctrl-names = "default";
pinctrl-0 = <&gmac_rgmii_pins>;
phy-handle = <&phy1>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
status = "okay";
};
--
2.29.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: sun7i: pcduino3-nano: enable RGMII RX/TX delay on PHY
2020-11-23 17:47 [PATCH] ARM: dts: sun7i: pcduino3-nano: enable RGMII RX/TX delay on PHY Adam Sampson
@ 2020-11-24 14:24 ` Maxime Ripard
0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2020-11-24 14:24 UTC (permalink / raw)
To: Adam Sampson
Cc: devicetree, Jernej Skrabec, Andrew Lunn, Chen-Yu Tsai,
linux-sunxi, Chen-Yu Tsai, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 954 bytes --]
On Mon, Nov 23, 2020 at 05:47:39PM +0000, Adam Sampson wrote:
> The RX/TX delays for the Ethernet PHY on the Linksprite pcDuino 3 Nano
> are configured in hardware, using resistors that are populated to pull
> the RTL8211E's RXDLY/TXDLY pins low or high as needed.
>
> phy-mode should be set to rgmii-id to reflect this. Previously it was
> set to rgmii, which used to work but now results in the delays being
> disabled again as a result of the bugfix in commit bbc4d71d6354 ("net:
> phy: realtek: fix rtl8211e rx/tx delay config").
>
> Tested on two pcDuino 3 Nano boards purchased in 2015. Without this fix,
> Ethernet works unreliably on one board and doesn't work at all on the
> other.
>
> Fixes: 061035d456c9 ("ARM: dts: sun7i: Add dts file for pcDuino 3 Nano board")
> Signed-off-by: Adam Sampson <ats@offog.org>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Acked-by: Chen-Yu Tsai <wens@csie.org>
Applied, thanks
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: sun7i: pcduino3-nano: enable RGMII RX/TX delay on PHY
2020-10-25 14:01 Adam Sampson
@ 2020-10-25 16:34 ` Andrew Lunn
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2020-10-25 16:34 UTC (permalink / raw)
To: Adam Sampson; +Cc: devicetree, linux-sunxi, linux-arm-kernel
On Sun, Oct 25, 2020 at 02:01:44PM +0000, Adam Sampson wrote:
> The RX/TX delays for the Ethernet PHY on the Linksprite pcDuino 3 Nano
> are configured in hardware, using resistors that are populated to pull
> the RTL8211E's RXDLY/TXDLY pins low or high as needed.
>
> phy-mode should be set to rgmii-id to reflect this. Previously it was
> set to rgmii, which used to work but now results in the delays being
> disabled again as a result of the bugfix in commit bbc4d71d6354 ("net:
> phy: realtek: fix rtl8211e rx/tx delay config").
>
> Tested on two pcDuino 3 Nano boards purchased in 2015. Without this fix,
> Ethernet works unreliably on one board and doesn't work at all on the
> other.
>
> Fixes: 061035d456c9 ("ARM: dts: sun7i: Add dts file for pcDuino 3 Nano board")
> Signed-off-by: Adam Sampson <ats@offog.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: sun7i: pcduino3-nano: enable RGMII RX/TX delay on PHY
@ 2020-10-25 14:01 Adam Sampson
2020-10-25 16:34 ` Andrew Lunn
0 siblings, 1 reply; 4+ messages in thread
From: Adam Sampson @ 2020-10-25 14:01 UTC (permalink / raw)
To: linux-sunxi, devicetree, linux-arm-kernel; +Cc: Adam Sampson
The RX/TX delays for the Ethernet PHY on the Linksprite pcDuino 3 Nano
are configured in hardware, using resistors that are populated to pull
the RTL8211E's RXDLY/TXDLY pins low or high as needed.
phy-mode should be set to rgmii-id to reflect this. Previously it was
set to rgmii, which used to work but now results in the delays being
disabled again as a result of the bugfix in commit bbc4d71d6354 ("net:
phy: realtek: fix rtl8211e rx/tx delay config").
Tested on two pcDuino 3 Nano boards purchased in 2015. Without this fix,
Ethernet works unreliably on one board and doesn't work at all on the
other.
Fixes: 061035d456c9 ("ARM: dts: sun7i: Add dts file for pcDuino 3 Nano board")
Signed-off-by: Adam Sampson <ats@offog.org>
---
arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts b/arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts
index fce2f7fcd084..bf38c66c1815 100644
--- a/arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts
+++ b/arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts
@@ -1,5 +1,5 @@
/*
- * Copyright 2015 Adam Sampson <ats@offog.org>
+ * Copyright 2015-2020 Adam Sampson <ats@offog.org>
*
* This file is dual-licensed: you can use it either under the terms
* of the GPL or the X11 license, at your option. Note that this dual
@@ -115,7 +115,7 @@ &gmac {
pinctrl-names = "default";
pinctrl-0 = <&gmac_rgmii_pins>;
phy-handle = <&phy1>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
status = "okay";
};
--
2.29.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-24 14:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-23 17:47 [PATCH] ARM: dts: sun7i: pcduino3-nano: enable RGMII RX/TX delay on PHY Adam Sampson
2020-11-24 14:24 ` Maxime Ripard
-- strict thread matches above, loose matches on Subject: below --
2020-10-25 14:01 Adam Sampson
2020-10-25 16:34 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).