linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx6qdl-kontron-samx6i: fix pwms for lcd-backlight
@ 2020-12-02 18:05 Marco Felsch
  2020-12-03  6:45 ` Uwe Kleine-König
  2021-01-05  3:06 ` Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Marco Felsch @ 2020-12-02 18:05 UTC (permalink / raw)
  To: robh+dt, shawnguo, festevam, u.kleine-koenig
  Cc: devicetree, kernel, linux-arm-kernel

The pwms property have to specify the no-/inverted flag since
commit fa28d8212ede ("ARM: dts: imx: default to #pwm-cells = <3>
in the SoC dtsi files").

Fixes: fa28d8212ede ("ARM: dts: imx: default to #pwm-cells = <3> in the SoC dtsi files")
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 arch/arm/boot/dts/imx6qdl-kontron-samx6i.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-kontron-samx6i.dtsi b/arch/arm/boot/dts/imx6qdl-kontron-samx6i.dtsi
index d6df598bd1c2..36c2f0d9ce16 100644
--- a/arch/arm/boot/dts/imx6qdl-kontron-samx6i.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-kontron-samx6i.dtsi
@@ -137,7 +137,7 @@
 
 	lcd_backlight: lcd-backlight {
 		compatible = "pwm-backlight";
-		pwms = <&pwm4 0 5000000>;
+		pwms = <&pwm4 0 5000000 0>;
 		pwm-names = "LCD_BKLT_PWM";
 
 		brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>;
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: imx6qdl-kontron-samx6i: fix pwms for lcd-backlight
  2020-12-02 18:05 [PATCH] ARM: dts: imx6qdl-kontron-samx6i: fix pwms for lcd-backlight Marco Felsch
@ 2020-12-03  6:45 ` Uwe Kleine-König
  2021-01-05  3:06 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2020-12-03  6:45 UTC (permalink / raw)
  To: Marco Felsch
  Cc: devicetree, shawnguo, robh+dt, kernel, festevam, linux-arm-kernel


[-- Attachment #1.1: Type: text/plain, Size: 699 bytes --]

Hello,

On Wed, Dec 02, 2020 at 07:05:58PM +0100, Marco Felsch wrote:
> The pwms property have to specify the no-/inverted flag since
> commit fa28d8212ede ("ARM: dts: imx: default to #pwm-cells = <3>
> in the SoC dtsi files").
> 
> Fixes: fa28d8212ede ("ARM: dts: imx: default to #pwm-cells = <3> in the SoC dtsi files")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>

Yeah, I missed this because this .dtsi isn't used in any .dts.

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: imx6qdl-kontron-samx6i: fix pwms for lcd-backlight
  2020-12-02 18:05 [PATCH] ARM: dts: imx6qdl-kontron-samx6i: fix pwms for lcd-backlight Marco Felsch
  2020-12-03  6:45 ` Uwe Kleine-König
@ 2021-01-05  3:06 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2021-01-05  3:06 UTC (permalink / raw)
  To: Marco Felsch
  Cc: devicetree, robh+dt, kernel, u.kleine-koenig, festevam, linux-arm-kernel

On Wed, Dec 02, 2020 at 07:05:58PM +0100, Marco Felsch wrote:
> The pwms property have to specify the no-/inverted flag since
> commit fa28d8212ede ("ARM: dts: imx: default to #pwm-cells = <3>
> in the SoC dtsi files").
> 
> Fixes: fa28d8212ede ("ARM: dts: imx: default to #pwm-cells = <3> in the SoC dtsi files")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>

Applied, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-05  3:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-02 18:05 [PATCH] ARM: dts: imx6qdl-kontron-samx6i: fix pwms for lcd-backlight Marco Felsch
2020-12-03  6:45 ` Uwe Kleine-König
2021-01-05  3:06 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).