* [PATCH] ARM: picoxcell: fix missing interrupt-parent properties
@ 2020-12-30 15:20 Arnd Bergmann
2020-12-31 12:49 ` Jamie Iles
2021-01-02 18:03 ` Jamie Iles
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2020-12-30 15:20 UTC (permalink / raw)
To: Jamie Iles, Rob Herring
Cc: devicetree, Arnd Bergmann, linux-kernel, Krzysztof Kozlowski,
soc, Olof Johansson, linux-arm-kernel
From: Arnd Bergmann <arnd@arndb.de>
dtc points out that the interrupts for some devices are not parsable:
picoxcell-pc3x2.dtsi:45.19-49.5: Warning (interrupts_property): /paxi/gem@30000: Missing interrupt-parent
picoxcell-pc3x2.dtsi:51.21-55.5: Warning (interrupts_property): /paxi/dmac@40000: Missing interrupt-parent
picoxcell-pc3x2.dtsi:57.21-61.5: Warning (interrupts_property): /paxi/dmac@50000: Missing interrupt-parent
picoxcell-pc3x2.dtsi:233.21-237.5: Warning (interrupts_property): /rwid-axi/axi2pico@c0000000: Missing interrupt-parent
There are two VIC instances, so it's not clear which one needs to be
used. I found the BSP sources that reference VIC0, so use that:
https://github.com/r1mikey/meta-picoxcell/blob/master/recipes-kernel/linux/linux-picochip-3.0/0001-picoxcell-support-for-Picochip-picoXcell-SoC.patch
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/boot/dts/picoxcell-pc3x2.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/picoxcell-pc3x2.dtsi b/arch/arm/boot/dts/picoxcell-pc3x2.dtsi
index c4c6c7e9e37b..5898879a3038 100644
--- a/arch/arm/boot/dts/picoxcell-pc3x2.dtsi
+++ b/arch/arm/boot/dts/picoxcell-pc3x2.dtsi
@@ -45,18 +45,21 @@ paxi {
emac: gem@30000 {
compatible = "cadence,gem";
reg = <0x30000 0x10000>;
+ interrupt-parent = <&vic0>;
interrupts = <31>;
};
dmac1: dmac@40000 {
compatible = "snps,dw-dmac";
reg = <0x40000 0x10000>;
+ interrupt-parent = <&vic0>;
interrupts = <25>;
};
dmac2: dmac@50000 {
compatible = "snps,dw-dmac";
reg = <0x50000 0x10000>;
+ interrupt-parent = <&vic0>;
interrupts = <26>;
};
@@ -233,6 +236,7 @@ ebi@50000000 {
axi2pico@c0000000 {
compatible = "picochip,axi2pico-pc3x2";
reg = <0xc0000000 0x10000>;
+ interrupt-parent = <&vic0>;
interrupts = <13 14 15 16 17 18 19 20 21>;
};
};
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: picoxcell: fix missing interrupt-parent properties
2020-12-30 15:20 [PATCH] ARM: picoxcell: fix missing interrupt-parent properties Arnd Bergmann
@ 2020-12-31 12:49 ` Jamie Iles
2021-01-02 10:54 ` Arnd Bergmann
2021-01-02 18:03 ` Jamie Iles
1 sibling, 1 reply; 4+ messages in thread
From: Jamie Iles @ 2020-12-31 12:49 UTC (permalink / raw)
To: Arnd Bergmann
Cc: devicetree, Arnd Bergmann, linux-kernel, Krzysztof Kozlowski,
soc, Rob Herring, Olof Johansson, Jamie Iles, linux-arm-kernel
Hi Arnd,
On Wed, Dec 30, 2020 at 04:20:05PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> dtc points out that the interrupts for some devices are not parsable:
>
> picoxcell-pc3x2.dtsi:45.19-49.5: Warning (interrupts_property): /paxi/gem@30000: Missing interrupt-parent
> picoxcell-pc3x2.dtsi:51.21-55.5: Warning (interrupts_property): /paxi/dmac@40000: Missing interrupt-parent
> picoxcell-pc3x2.dtsi:57.21-61.5: Warning (interrupts_property): /paxi/dmac@50000: Missing interrupt-parent
> picoxcell-pc3x2.dtsi:233.21-237.5: Warning (interrupts_property): /rwid-axi/axi2pico@c0000000: Missing interrupt-parent
>
> There are two VIC instances, so it's not clear which one needs to be
> used. I found the BSP sources that reference VIC0, so use that:
>
> https://github.com/r1mikey/meta-picoxcell/blob/master/recipes-kernel/linux/linux-picochip-3.0/0001-picoxcell-support-for-Picochip-picoXcell-SoC.patch
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Rob has a series to remove Picoxcell as there's no active development on
this anymore and Intel have stopped producing the chips.
Thanks,
Jamie
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: picoxcell: fix missing interrupt-parent properties
2020-12-31 12:49 ` Jamie Iles
@ 2021-01-02 10:54 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2021-01-02 10:54 UTC (permalink / raw)
To: Jamie Iles
Cc: DTML, Arnd Bergmann, linux-kernel, Krzysztof Kozlowski, SoC Team,
Rob Herring, Olof Johansson, Linux ARM
On Thu, Dec 31, 2020 at 1:49 PM Jamie Iles <jamie@jamieiles.com> wrote:
>
> Hi Arnd,
>
> On Wed, Dec 30, 2020 at 04:20:05PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > dtc points out that the interrupts for some devices are not parsable:
> >
> > picoxcell-pc3x2.dtsi:45.19-49.5: Warning (interrupts_property): /paxi/gem@30000: Missing interrupt-parent
> > picoxcell-pc3x2.dtsi:51.21-55.5: Warning (interrupts_property): /paxi/dmac@40000: Missing interrupt-parent
> > picoxcell-pc3x2.dtsi:57.21-61.5: Warning (interrupts_property): /paxi/dmac@50000: Missing interrupt-parent
> > picoxcell-pc3x2.dtsi:233.21-237.5: Warning (interrupts_property): /rwid-axi/axi2pico@c0000000: Missing interrupt-parent
> >
> > There are two VIC instances, so it's not clear which one needs to be
> > used. I found the BSP sources that reference VIC0, so use that:
> >
> > https://github.com/r1mikey/meta-picoxcell/blob/master/recipes-kernel/linux/linux-picochip-3.0/0001-picoxcell-support-for-Picochip-picoXcell-SoC.patch
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Rob has a series to remove Picoxcell as there's no active development on
> this anymore and Intel have stopped producing the chips.
Right, I am aware of Rob's series. My patch was a little older but I only got
around to submitting it now. I'd still like to merge it as a bugfix for v5.11
though and have it backported to avoid the warnings with new dtc on
stable kernels, while doing the platform removal for v5.12.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: picoxcell: fix missing interrupt-parent properties
2020-12-30 15:20 [PATCH] ARM: picoxcell: fix missing interrupt-parent properties Arnd Bergmann
2020-12-31 12:49 ` Jamie Iles
@ 2021-01-02 18:03 ` Jamie Iles
1 sibling, 0 replies; 4+ messages in thread
From: Jamie Iles @ 2021-01-02 18:03 UTC (permalink / raw)
To: Arnd Bergmann
Cc: devicetree, Arnd Bergmann, linux-kernel, Krzysztof Kozlowski,
soc, Rob Herring, Olof Johansson, Jamie Iles, linux-arm-kernel
On Wed, Dec 30, 2020 at 04:20:05PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> dtc points out that the interrupts for some devices are not parsable:
>
> picoxcell-pc3x2.dtsi:45.19-49.5: Warning (interrupts_property): /paxi/gem@30000: Missing interrupt-parent
> picoxcell-pc3x2.dtsi:51.21-55.5: Warning (interrupts_property): /paxi/dmac@40000: Missing interrupt-parent
> picoxcell-pc3x2.dtsi:57.21-61.5: Warning (interrupts_property): /paxi/dmac@50000: Missing interrupt-parent
> picoxcell-pc3x2.dtsi:233.21-237.5: Warning (interrupts_property): /rwid-axi/axi2pico@c0000000: Missing interrupt-parent
>
> There are two VIC instances, so it's not clear which one needs to be
> used. I found the BSP sources that reference VIC0, so use that:
>
> https://github.com/r1mikey/meta-picoxcell/blob/master/recipes-kernel/linux/linux-picochip-3.0/0001-picoxcell-support-for-Picochip-picoXcell-SoC.patch
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Jamie Iles <jamie@jamieiles.com>
Thanks Arnd!
Jamie
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-02 18:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-30 15:20 [PATCH] ARM: picoxcell: fix missing interrupt-parent properties Arnd Bergmann
2020-12-31 12:49 ` Jamie Iles
2021-01-02 10:54 ` Arnd Bergmann
2021-01-02 18:03 ` Jamie Iles
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).