linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: sun5i: add A10s/A13 display frontend support fallback
@ 2021-01-07 10:59 Sergio Sota
  2021-01-08  9:22 ` Maxime Ripard
  0 siblings, 1 reply; 2+ messages in thread
From: Sergio Sota @ 2021-01-07 10:59 UTC (permalink / raw)
  To: robh+dt
  Cc: devicetree, jernej.skrabec, linux-kernel, mripard, wens,
	Sergio Sota, linux-arm-kernel

The A10s/A13 display frontend driver is not implemented
Set A10 display frontend driver as a fallback for A10s/A13
Tested with Olimex-A13-SOM / Olimex-A13-OlinuXino-MICRO
"modetest -M sun4i-drm -s 49@47:800x480-60"  ( 7.0" tft lcd)
"modetest -M sun4i-drm -s 49@47:1024x600-60" (10.1" tft lcd)

Signed-off-by: Sergio Sota <sergiosota@fanamoel.com>
---
 arch/arm/boot/dts/sun5i.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun5i.dtsi b/arch/arm/boot/dts/sun5i.dtsi
index c2b4fbf552a3..4ef14a8695ef 100644
--- a/arch/arm/boot/dts/sun5i.dtsi
+++ b/arch/arm/boot/dts/sun5i.dtsi
@@ -734,7 +734,8 @@ timer@1c60000 {
 		};
 
 		fe0: display-frontend@1e00000 {
-			compatible = "allwinner,sun5i-a13-display-frontend";
+			compatible = "allwinner,sun5i-a13-display-frontend",
+				     "allwinner,sun4i-a10-display-frontend";
 			reg = <0x01e00000 0x20000>;
 			interrupts = <47>;
 			clocks = <&ccu CLK_DE_FE>, <&ccu CLK_DE_FE>,
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: sun5i: add A10s/A13 display frontend support fallback
  2021-01-07 10:59 [PATCH] ARM: dts: sun5i: add A10s/A13 display frontend support fallback Sergio Sota
@ 2021-01-08  9:22 ` Maxime Ripard
  0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2021-01-08  9:22 UTC (permalink / raw)
  To: Sergio Sota
  Cc: devicetree, jernej.skrabec, linux-kernel, wens, robh+dt,
	linux-arm-kernel

Hi,

On Thu, Jan 07, 2021 at 11:59:27AM +0100, Sergio Sota wrote:
> The A10s/A13 display frontend driver is not implemented
> Set A10 display frontend driver as a fallback for A10s/A13
> Tested with Olimex-A13-SOM / Olimex-A13-OlinuXino-MICRO
> "modetest -M sun4i-drm -s 49@47:800x480-60"  ( 7.0" tft lcd)
> "modetest -M sun4i-drm -s 49@47:1024x600-60" (10.1" tft lcd)
> 
> Signed-off-by: Sergio Sota <sergiosota@fanamoel.com>
> ---

You should mention the version number (using -v in git send-email or
format-patch), and add a changelog here

>  arch/arm/boot/dts/sun5i.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/sun5i.dtsi b/arch/arm/boot/dts/sun5i.dtsi
> index c2b4fbf552a3..4ef14a8695ef 100644
> --- a/arch/arm/boot/dts/sun5i.dtsi
> +++ b/arch/arm/boot/dts/sun5i.dtsi
> @@ -734,7 +734,8 @@ timer@1c60000 {
>  		};
>  
>  		fe0: display-frontend@1e00000 {
> -			compatible = "allwinner,sun5i-a13-display-frontend";
> +			compatible = "allwinner,sun5i-a13-display-frontend",
> +				     "allwinner,sun4i-a10-display-frontend";

The comment on the first version still apply here, even more so with the
additional details you provided in the commit message

Maxime

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-08  9:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-07 10:59 [PATCH] ARM: dts: sun5i: add A10s/A13 display frontend support fallback Sergio Sota
2021-01-08  9:22 ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).