* [PATCH] arm64: dts: rockchip: fix vopl iommu irq on px30
@ 2021-01-08 11:06 Heiko Stuebner
2021-01-08 12:08 ` Ezequiel Garcia
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Heiko Stuebner @ 2021-01-08 11:06 UTC (permalink / raw)
To: linux-rockchip
Cc: Heiko Stuebner, Sandy Huang, paul.kocialkowski, ezequiel,
linux-arm-kernel, christoph.muellner
From: Sandy Huang <hjc@rock-chips.com>
The vop-mmu shares the irq with its matched vop but not the vpu.
Fixes: 7053e06b1422 ("arm64: dts: rockchip: add core dtsi file for PX30 SoCs")
Signed-off-by: Sandy Huang <hjc@rock-chips.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
arch/arm64/boot/dts/rockchip/px30.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi
index 39b54093d858..4f762968f75f 100644
--- a/arch/arm64/boot/dts/rockchip/px30.dtsi
+++ b/arch/arm64/boot/dts/rockchip/px30.dtsi
@@ -1110,7 +1110,7 @@ vopl_out_lvds: endpoint@1 {
vopl_mmu: iommu@ff470f00 {
compatible = "rockchip,iommu";
reg = <0x0 0xff470f00 0x0 0x100>;
- interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "vopl_mmu";
clocks = <&cru ACLK_VOPL>, <&cru HCLK_VOPL>;
clock-names = "aclk", "iface";
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: rockchip: fix vopl iommu irq on px30
2021-01-08 11:06 [PATCH] arm64: dts: rockchip: fix vopl iommu irq on px30 Heiko Stuebner
@ 2021-01-08 12:08 ` Ezequiel Garcia
2021-01-08 15:43 ` Paul Kocialkowski
2021-01-09 15:39 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Ezequiel Garcia @ 2021-01-08 12:08 UTC (permalink / raw)
To: Heiko Stuebner, linux-rockchip
Cc: paul.kocialkowski, Sandy Huang, linux-arm-kernel, christoph.muellner
Hi Heiko,
On Fri, 2021-01-08 at 12:06 +0100, Heiko Stuebner wrote:
> From: Sandy Huang <hjc@rock-chips.com>
>
> The vop-mmu shares the irq with its matched vop but not the vpu.
>
> Fixes: 7053e06b1422 ("arm64: dts: rockchip: add core dtsi file for PX30 SoCs")
> Signed-off-by: Sandy Huang <hjc@rock-chips.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>
Thanks,
Ezequiel
> ---
> arch/arm64/boot/dts/rockchip/px30.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi
> index 39b54093d858..4f762968f75f 100644
> --- a/arch/arm64/boot/dts/rockchip/px30.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi
> @@ -1110,7 +1110,7 @@ vopl_out_lvds: endpoint@1 {
> vopl_mmu: iommu@ff470f00 {
> compatible = "rockchip,iommu";
> reg = <0x0 0xff470f00 0x0 0x100>;
> - interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
> + interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "vopl_mmu";
> clocks = <&cru ACLK_VOPL>, <&cru HCLK_VOPL>;
> clock-names = "aclk", "iface";
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: rockchip: fix vopl iommu irq on px30
2021-01-08 11:06 [PATCH] arm64: dts: rockchip: fix vopl iommu irq on px30 Heiko Stuebner
2021-01-08 12:08 ` Ezequiel Garcia
@ 2021-01-08 15:43 ` Paul Kocialkowski
2021-01-09 15:39 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Paul Kocialkowski @ 2021-01-08 15:43 UTC (permalink / raw)
To: Heiko Stuebner
Cc: linux-rockchip, ezequiel, Sandy Huang, linux-arm-kernel,
christoph.muellner
[-- Attachment #1.1: Type: text/plain, Size: 1374 bytes --]
Hi,
On Fri 08 Jan 21, 12:06, Heiko Stuebner wrote:
> From: Sandy Huang <hjc@rock-chips.com>
>
> The vop-mmu shares the irq with its matched vop but not the vpu.
This is:
Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
and:
Tested-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Thanks!
Paul
> Fixes: 7053e06b1422 ("arm64: dts: rockchip: add core dtsi file for PX30 SoCs")
> Signed-off-by: Sandy Huang <hjc@rock-chips.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> arch/arm64/boot/dts/rockchip/px30.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi
> index 39b54093d858..4f762968f75f 100644
> --- a/arch/arm64/boot/dts/rockchip/px30.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi
> @@ -1110,7 +1110,7 @@ vopl_out_lvds: endpoint@1 {
> vopl_mmu: iommu@ff470f00 {
> compatible = "rockchip,iommu";
> reg = <0x0 0xff470f00 0x0 0x100>;
> - interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
> + interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "vopl_mmu";
> clocks = <&cru ACLK_VOPL>, <&cru HCLK_VOPL>;
> clock-names = "aclk", "iface";
> --
> 2.29.2
>
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: rockchip: fix vopl iommu irq on px30
2021-01-08 11:06 [PATCH] arm64: dts: rockchip: fix vopl iommu irq on px30 Heiko Stuebner
2021-01-08 12:08 ` Ezequiel Garcia
2021-01-08 15:43 ` Paul Kocialkowski
@ 2021-01-09 15:39 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2021-01-09 15:39 UTC (permalink / raw)
To: linux-rockchip, Heiko Stuebner
Cc: paul.kocialkowski, ezequiel, Sandy Huang, linux-arm-kernel,
christoph.muellner
On Fri, 8 Jan 2021 12:06:27 +0100, Heiko Stuebner wrote:
> The vop-mmu shares the irq with its matched vop but not the vpu.
Applied, thanks!
[1/1] arm64: dts: rockchip: fix vopl iommu irq on px30
commit: 656c648354e1561fa4f445b0b3252ec1d24e3951
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-09 15:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-08 11:06 [PATCH] arm64: dts: rockchip: fix vopl iommu irq on px30 Heiko Stuebner
2021-01-08 12:08 ` Ezequiel Garcia
2021-01-08 15:43 ` Paul Kocialkowski
2021-01-09 15:39 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).