* [PATCH 0/2] ARM: dts: rockchip: minor tweaks for rk3288-miqi.This series adds a missing mali GPU node and two additional CPU opp points
@ 2021-01-08 15:10 Demetris Ierokipides
2021-01-08 15:10 ` [PATCH 1/2] ARM: dts: rockchip: add gpu node to rk3288-miqi Demetris Ierokipides
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Demetris Ierokipides @ 2021-01-08 15:10 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, linux-arm-kernel, linux-rockchip,
devicetree, linux-kernel
Cc: Demetris Ierokipides
From: Ntemis <ierokipides.dem@gmail.com>
Demetris Ierokipides (2):
ARM: dts: rockchip: add gpu node to rk3288-miqi
ARM: dts: rockchip: add extra cpu opp points to rk3288-miqi
arch/arm/boot/dts/rk3288-miqi.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] ARM: dts: rockchip: add gpu node to rk3288-miqi
2021-01-08 15:10 [PATCH 0/2] ARM: dts: rockchip: minor tweaks for rk3288-miqi.This series adds a missing mali GPU node and two additional CPU opp points Demetris Ierokipides
@ 2021-01-08 15:10 ` Demetris Ierokipides
2021-01-08 15:10 ` [PATCH 2/2] ARM: dts: rockchip: add extra cpu opp points " Demetris Ierokipides
2021-01-09 15:39 ` (subset) [PATCH 0/2] ARM: dts: rockchip: minor tweaks for rk3288-miqi.This series adds a missing mali GPU node and two additional CPU opp points Heiko Stuebner
2 siblings, 0 replies; 5+ messages in thread
From: Demetris Ierokipides @ 2021-01-08 15:10 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, linux-arm-kernel, linux-rockchip,
devicetree, linux-kernel
Cc: Demetris Ierokipides
Add the Mali GPU node to the MiQi device-tree.
Signed-off-by: Demetris Ierokipides <ierokipides.dem@gmail.com>
---
arch/arm/boot/dts/rk3288-miqi.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288-miqi.dts b/arch/arm/boot/dts/rk3288-miqi.dts
index cf54d5ffff2f..713f55e143c6 100644
--- a/arch/arm/boot/dts/rk3288-miqi.dts
+++ b/arch/arm/boot/dts/rk3288-miqi.dts
@@ -123,6 +123,11 @@ &gmac {
status = "okay";
};
+&gpu {
+ mali-supply = <&vdd_gpu>;
+ status = "okay";
+};
+
&hdmi {
ddc-i2c-bus = <&i2c5>;
status = "okay";
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] ARM: dts: rockchip: add extra cpu opp points to rk3288-miqi
2021-01-08 15:10 [PATCH 0/2] ARM: dts: rockchip: minor tweaks for rk3288-miqi.This series adds a missing mali GPU node and two additional CPU opp points Demetris Ierokipides
2021-01-08 15:10 ` [PATCH 1/2] ARM: dts: rockchip: add gpu node to rk3288-miqi Demetris Ierokipides
@ 2021-01-08 15:10 ` Demetris Ierokipides
2021-01-09 13:40 ` Heiko Stübner
2021-01-09 15:39 ` (subset) [PATCH 0/2] ARM: dts: rockchip: minor tweaks for rk3288-miqi.This series adds a missing mali GPU node and two additional CPU opp points Heiko Stuebner
2 siblings, 1 reply; 5+ messages in thread
From: Demetris Ierokipides @ 2021-01-08 15:10 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, linux-arm-kernel, linux-rockchip,
devicetree, linux-kernel
Cc: Demetris Ierokipides
Add extra 1.7GHz and 1.8GHz opp points to the MiQi device-tree to improve
performance.
Signed-off-by: Demetris Ierokipides <ierokipides.dem@gmail.com>
---
arch/arm/boot/dts/rk3288-miqi.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288-miqi.dts b/arch/arm/boot/dts/rk3288-miqi.dts
index 713f55e143c6..1b48855db6ff 100644
--- a/arch/arm/boot/dts/rk3288-miqi.dts
+++ b/arch/arm/boot/dts/rk3288-miqi.dts
@@ -96,6 +96,18 @@ &cpu3 {
cpu-supply = <&vdd_cpu>;
};
+&cpu_opp_table {
+ opp-1704000000 {
+ opp-hz = /bits/ 64 <1704000000>;
+ opp-microvolt = <1350000>;
+ };
+
+ opp-1800000000 {
+ opp-hz = /bits/ 64 <1800000000>;
+ opp-microvolt = <1350000>;
+ };
+};
+
&emmc {
bus-width = <8>;
cap-mmc-highspeed;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] ARM: dts: rockchip: add extra cpu opp points to rk3288-miqi
2021-01-08 15:10 ` [PATCH 2/2] ARM: dts: rockchip: add extra cpu opp points " Demetris Ierokipides
@ 2021-01-09 13:40 ` Heiko Stübner
0 siblings, 0 replies; 5+ messages in thread
From: Heiko Stübner @ 2021-01-09 13:40 UTC (permalink / raw)
To: Rob Herring, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel, Demetris Ierokipides
Cc: Demetris Ierokipides
Hi Demetris,
Am Freitag, 8. Januar 2021, 16:10:36 CET schrieb Demetris Ierokipides:
> Add extra 1.7GHz and 1.8GHz opp points to the MiQi device-tree to improve
> performance.
>
> Signed-off-by: Demetris Ierokipides <ierokipides.dem@gmail.com>
> ---
> arch/arm/boot/dts/rk3288-miqi.dts | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-miqi.dts b/arch/arm/boot/dts/rk3288-miqi.dts
> index 713f55e143c6..1b48855db6ff 100644
> --- a/arch/arm/boot/dts/rk3288-miqi.dts
> +++ b/arch/arm/boot/dts/rk3288-miqi.dts
> @@ -96,6 +96,18 @@ &cpu3 {
> cpu-supply = <&vdd_cpu>;
> };
>
> +&cpu_opp_table {
> + opp-1704000000 {
> + opp-hz = /bits/ 64 <1704000000>;
> + opp-microvolt = <1350000>;
> + };
> +
> + opp-1800000000 {
> + opp-hz = /bits/ 64 <1800000000>;
> + opp-microvolt = <1350000>;
> + };
> +};
> +
sorry, but no .
The OPPs in the mainline kernel match the specifications released by the
soc vendor. Going outside these specs _may_ affect things like stability
on some boards or in general simply the lifetime of the chip itself.
So yes, while boards may generally work with these higher frequencies
I don't think this should be the default coming from the mainline kernel.
If board-owners feel the need to exceed the specs they can still modify
the dts, but we shouldn't force this decision on everyone.
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: (subset) [PATCH 0/2] ARM: dts: rockchip: minor tweaks for rk3288-miqi.This series adds a missing mali GPU node and two additional CPU opp points
2021-01-08 15:10 [PATCH 0/2] ARM: dts: rockchip: minor tweaks for rk3288-miqi.This series adds a missing mali GPU node and two additional CPU opp points Demetris Ierokipides
2021-01-08 15:10 ` [PATCH 1/2] ARM: dts: rockchip: add gpu node to rk3288-miqi Demetris Ierokipides
2021-01-08 15:10 ` [PATCH 2/2] ARM: dts: rockchip: add extra cpu opp points " Demetris Ierokipides
@ 2021-01-09 15:39 ` Heiko Stuebner
2 siblings, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2021-01-09 15:39 UTC (permalink / raw)
To: Demetris Ierokipides, Rob Herring, linux-arm-kernel,
linux-kernel, devicetree, linux-rockchip
Cc: Heiko Stuebner
On Fri, 8 Jan 2021 17:10:34 +0200, Demetris Ierokipides wrote:
> Demetris Ierokipides (2):
> ARM: dts: rockchip: add gpu node to rk3288-miqi
> ARM: dts: rockchip: add extra cpu opp points to rk3288-miqi
>
> arch/arm/boot/dts/rk3288-miqi.dts | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
Applied, thanks!
[1/2] ARM: dts: rockchip: add gpu node to rk3288-miqi
commit: 36948ec3d4d0d1b9260d87b550a56fab8d86d17d
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-09 15:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-08 15:10 [PATCH 0/2] ARM: dts: rockchip: minor tweaks for rk3288-miqi.This series adds a missing mali GPU node and two additional CPU opp points Demetris Ierokipides
2021-01-08 15:10 ` [PATCH 1/2] ARM: dts: rockchip: add gpu node to rk3288-miqi Demetris Ierokipides
2021-01-08 15:10 ` [PATCH 2/2] ARM: dts: rockchip: add extra cpu opp points " Demetris Ierokipides
2021-01-09 13:40 ` Heiko Stübner
2021-01-09 15:39 ` (subset) [PATCH 0/2] ARM: dts: rockchip: minor tweaks for rk3288-miqi.This series adds a missing mali GPU node and two additional CPU opp points Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).