* [PATCH 1/2] ARM: s3c: irq-s3c24xx: include headers for missing declarations
@ 2021-02-06 13:36 Krzysztof Kozlowski
2021-02-06 13:36 ` [PATCH 2/2] ARM: s3c: irq-s3c24xx: staticize local functions Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2021-02-06 13:36 UTC (permalink / raw)
To: Krzysztof Kozlowski, Russell King, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: kernel test robot, Arnd Bergmann
Include headers to fix W=1 build warnings:
arch/arm/mach-s3c/irq-s3c24xx.c:389:5: warning:
no previous prototype for ‘s3c24xx_set_fiq’ [-Wmissing-prototypes]
arch/arm/mach-s3c/irq-s3c24xx.c:683:13: warning:
no previous prototype for ‘s3c2410_init_irq’ [-Wmissing-prototypes]
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm/mach-s3c/irq-s3c24xx.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-s3c/irq-s3c24xx.c b/arch/arm/mach-s3c/irq-s3c24xx.c
index 79b5f19af7a5..3368159d3f3e 100644
--- a/arch/arm/mach-s3c/irq-s3c24xx.c
+++ b/arch/arm/mach-s3c/irq-s3c24xx.c
@@ -21,6 +21,7 @@
#include <linux/of.h>
#include <linux/of_irq.h>
#include <linux/of_address.h>
+#include <linux/spi/s3c24xx.h>
#include <asm/exception.h>
#include <asm/mach/irq.h>
@@ -32,6 +33,7 @@
#include "cpu.h"
#include "regs-irqtype.h"
#include "pm.h"
+#include "s3c24xx.h"
#define S3C_IRQTYPE_NONE 0
#define S3C_IRQTYPE_EINT 1
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] ARM: s3c: irq-s3c24xx: staticize local functions
2021-02-06 13:36 [PATCH 1/2] ARM: s3c: irq-s3c24xx: include headers for missing declarations Krzysztof Kozlowski
@ 2021-02-06 13:36 ` Krzysztof Kozlowski
2021-02-08 17:10 ` (subset) [PATCH 1/2] ARM: s3c: irq-s3c24xx: include headers for missing declarations Krzysztof Kozlowski
2021-02-08 17:10 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2021-02-06 13:36 UTC (permalink / raw)
To: Krzysztof Kozlowski, Russell King, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: kernel test robot, Arnd Bergmann
Make functions used only in this module static to fix W=1 build warnings:
arch/arm/mach-s3c/irq-s3c24xx.c:360:39: warning:
no previous prototype for ‘s3c24xx_handle_irq’ [-Wmissing-prototypes]
arch/arm/mach-s3c/irq-s3c24xx.c:1308:12: warning:
no previous prototype for ‘s3c2410_init_intc_of’ [-Wmissing-prototypes]
arch/arm/mach-s3c/irq-s3c24xx.c:1330:12: warning:
no previous prototype for ‘s3c2416_init_intc_of’ [-Wmissing-prototypes]
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm/mach-s3c/irq-s3c24xx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-s3c/irq-s3c24xx.c b/arch/arm/mach-s3c/irq-s3c24xx.c
index 3368159d3f3e..0c631c14a817 100644
--- a/arch/arm/mach-s3c/irq-s3c24xx.c
+++ b/arch/arm/mach-s3c/irq-s3c24xx.c
@@ -359,7 +359,7 @@ static inline int s3c24xx_handle_intc(struct s3c_irq_intc *intc,
return true;
}
-asmlinkage void __exception_irq_entry s3c24xx_handle_irq(struct pt_regs *regs)
+static asmlinkage void __exception_irq_entry s3c24xx_handle_irq(struct pt_regs *regs)
{
do {
if (likely(s3c_intc[0]))
@@ -1307,7 +1307,7 @@ static struct s3c24xx_irq_of_ctrl s3c2410_ctrl[] = {
}
};
-int __init s3c2410_init_intc_of(struct device_node *np,
+static int __init s3c2410_init_intc_of(struct device_node *np,
struct device_node *interrupt_parent)
{
return s3c_init_intc_of(np, interrupt_parent,
@@ -1329,7 +1329,7 @@ static struct s3c24xx_irq_of_ctrl s3c2416_ctrl[] = {
}
};
-int __init s3c2416_init_intc_of(struct device_node *np,
+static int __init s3c2416_init_intc_of(struct device_node *np,
struct device_node *interrupt_parent)
{
return s3c_init_intc_of(np, interrupt_parent,
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: (subset) [PATCH 1/2] ARM: s3c: irq-s3c24xx: include headers for missing declarations
2021-02-06 13:36 [PATCH 1/2] ARM: s3c: irq-s3c24xx: include headers for missing declarations Krzysztof Kozlowski
2021-02-06 13:36 ` [PATCH 2/2] ARM: s3c: irq-s3c24xx: staticize local functions Krzysztof Kozlowski
@ 2021-02-08 17:10 ` Krzysztof Kozlowski
2021-02-08 17:10 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2021-02-08 17:10 UTC (permalink / raw)
To: linux-kernel, Krzysztof Kozlowski, linux-arm-kernel,
linux-samsung-soc, Russell King
Cc: kernel test robot, Arnd Bergmann
On Sat, 6 Feb 2021 14:36:14 +0100, Krzysztof Kozlowski wrote:
> Include headers to fix W=1 build warnings:
>
> arch/arm/mach-s3c/irq-s3c24xx.c:389:5: warning:
> no previous prototype for ‘s3c24xx_set_fiq’ [-Wmissing-prototypes]
> arch/arm/mach-s3c/irq-s3c24xx.c:683:13: warning:
> no previous prototype for ‘s3c2410_init_irq’ [-Wmissing-prototypes]
Applied, thanks!
[1/2] ARM: s3c: irq-s3c24xx: include headers for missing declarations
commit: 49dc85ca3c78d938d9eb41e05efcd85c92626e84
Best regards,
--
Krzysztof Kozlowski <krzk@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: (subset) [PATCH 1/2] ARM: s3c: irq-s3c24xx: include headers for missing declarations
2021-02-06 13:36 [PATCH 1/2] ARM: s3c: irq-s3c24xx: include headers for missing declarations Krzysztof Kozlowski
2021-02-06 13:36 ` [PATCH 2/2] ARM: s3c: irq-s3c24xx: staticize local functions Krzysztof Kozlowski
2021-02-08 17:10 ` (subset) [PATCH 1/2] ARM: s3c: irq-s3c24xx: include headers for missing declarations Krzysztof Kozlowski
@ 2021-02-08 17:10 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2021-02-08 17:10 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-samsung-soc, linux-arm-kernel,
Russell King, linux-kernel
Cc: kernel test robot, Arnd Bergmann
On Sat, 6 Feb 2021 14:36:14 +0100, Krzysztof Kozlowski wrote:
> Include headers to fix W=1 build warnings:
>
> arch/arm/mach-s3c/irq-s3c24xx.c:389:5: warning:
> no previous prototype for ‘s3c24xx_set_fiq’ [-Wmissing-prototypes]
> arch/arm/mach-s3c/irq-s3c24xx.c:683:13: warning:
> no previous prototype for ‘s3c2410_init_irq’ [-Wmissing-prototypes]
Applied, thanks!
[2/2] ARM: s3c: irq-s3c24xx: staticize local functions
commit: f503878564f5e68c1aeb1ea01e437060bf905c50
Best regards,
--
Krzysztof Kozlowski <krzk@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-08 17:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-06 13:36 [PATCH 1/2] ARM: s3c: irq-s3c24xx: include headers for missing declarations Krzysztof Kozlowski
2021-02-06 13:36 ` [PATCH 2/2] ARM: s3c: irq-s3c24xx: staticize local functions Krzysztof Kozlowski
2021-02-08 17:10 ` (subset) [PATCH 1/2] ARM: s3c: irq-s3c24xx: include headers for missing declarations Krzysztof Kozlowski
2021-02-08 17:10 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).