From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org,
david@protonic.nl
Subject: Re: [PATCH] ARM: dts: imx6dl-plybas: Fix gpio-keys W=1 warnings
Date: Tue, 9 Feb 2021 10:21:48 +0100 [thread overview]
Message-ID: <20210209092148.77dliclrtv6gbe4h@pengutronix.de> (raw)
In-Reply-To: <20210208142123.587551-1-festevam@gmail.com>
On Mon, Feb 08, 2021 at 11:21:23AM -0300, Fabio Estevam wrote:
> Remove the unnecessary #address-cells/#size-cells and rename the node
> names to fix the following W=1 dtc warnings:
>
> arch/arm/boot/dts/imx6dl-plybas.dts:26.13-30.5: Warning (unit_address_vs_reg): /gpio_keys/button@20: node has a unit name, but no reg or ranges property
> arch/arm/boot/dts/imx6dl-plybas.dts:32.13-36.5: Warning (unit_address_vs_reg): /gpio_keys/button@21: node has a unit name, but no reg or ranges property
> arch/arm/boot/dts/imx6dl-plybas.dts:20.12-37.4: Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Thank you!
> ---
> arch/arm/boot/dts/imx6dl-plybas.dts | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6dl-plybas.dts b/arch/arm/boot/dts/imx6dl-plybas.dts
> index 333c306aa946..e6e9721ceea2 100644
> --- a/arch/arm/boot/dts/imx6dl-plybas.dts
> +++ b/arch/arm/boot/dts/imx6dl-plybas.dts
> @@ -19,17 +19,15 @@ chosen {
>
> gpio_keys {
> compatible = "gpio-keys";
> - #address-cells = <1>;
> - #size-cells = <0>;
> autorepeat;
>
> - button@20 {
> + start-button {
> label = "START";
> linux,code = <31>;
> gpios = <&gpio5 8 GPIO_ACTIVE_LOW>;
> };
>
> - button@21 {
> + clean-button {
> label = "CLEAN";
> linux,code = <46>;
> gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
> --
> 2.25.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-09 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 14:21 [PATCH] ARM: dts: imx6dl-plybas: Fix gpio-keys W=1 warnings Fabio Estevam
2021-02-09 9:21 ` Oleksij Rempel [this message]
2021-03-05 11:07 ` Fabio Estevam
2021-03-07 1:31 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209092148.77dliclrtv6gbe4h@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=david@protonic.nl \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).